drivers/net/ethernet: check return value of e1e_rphy()
Subsystems (3)
PATCH v2 1/1 drivers/net/ethernet: check return value of e1e_rphy()
e1e_rphy() could return error value, which needs to be checked and reported for debugging and diagnose.
--- drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/e1000e/phy.c +17 -3
@@ -2697,9 +2697,14 @@ static s32 e1000_access_phy_wakeup_reg_bm(struct e1000_hw *hw, u32 offset,void e1000_power_up_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg &= ~BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg); }
@@ -2715,9 +2720,14 @@ void e1000_power_up_phy_copper(struct e1000_hw *hw)void e1000_power_down_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg |=BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg);usleep_range (1000 ,2000 );
@@ -3037,7 +3047,11 @@ s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw)return 0 ;/* Do not apply workaround if in PHY loopback bit 14 set */ -e1e_rphy (hw,MII_BMCR , &data); + ret_val =e1e_rphy (hw,MII_BMCR , &data); +if (ret_val) { +e_dbg ("Error reading PHY register\n" ); +return ret_val; + }if (data &BMCR_LOOPBACK )return 0 ;
Signature · 1 line
2.25.1
Quoted 47 lines · Li Zhong
e1e_rphy()could return error value, which needs to be checked and reported for debugging and diagnose.Signed-off-by Li Zhong <[email protected]>--- drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)drivers/net/ethernet/intel/e1000e/phy.c +12
-2@@ -2697,9 +2697,14 @@ static s32 e1000_access_phy_wakeup_reg_bm(struct e1000_hw *hw, u32 offset,void e1000_power_up_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg &= ~BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg); }@@ -2715,9 +2720,14 @@ void e1000_power_up_phy_copper(struct e1000_hw *hw)void e1000_power_down_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg |=BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg);usleep_range (1000 ,2000 );@@ -3037,7 +3047,11 @@ s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw)return 0 ;
drivers/net/ethernet/intel/e1000e/phy.c s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw) · line 3057
Quoted 10 lines
drivers/net/ethernet/intel/e1000e/phy.c +5
-1/* Do not apply workaround if in PHY loopback bit 14 set */ -e1e_rphy (hw,MII_BMCR , &data); + ret_val =e1e_rphy (hw,MII_BMCR , &data); +if (ret_val) { +e_dbg ("Error reading PHY register\n" ); +return ret_val; + }if (data &BMCR_LOOPBACK )return 0 ;
Generally, I am good with this patch. One question - it is old HW, any idea how to check it? (82577/82578 GbE LOM - from 2008) Li, how did you check it manually?
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Quoted 49 lines · Sasha
Quoted 47 lines · Li Zhong
e1e_rphy()could return error value, which needs to be checked and reported for debugging and diagnose.Signed-off-by Li Zhong <[email protected]>---
drivers/net/ethernet/intel/e1000e/phy.c| 20 +++++++++++++++++---1 file changed, 17 insertions(+), 3 deletions(-)drivers/net/ethernet/intel/e1000e/phy.c +12
-2@@ -2697,9 +2697,14 @@ static s32 e1000_access_phy_wakeup_reg_bm(struct e1000_hw *hw, u32 offset,void e1000_power_up_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg &= ~BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg); }@@ -2715,9 +2720,14 @@ void e1000_power_up_phy_copper(struct e1000_hw *hw)void e1000_power_down_phy_copper (struct e1000_hw *hw) {u16 mii_reg =0 ; +int ret;/* The PHY will retain its settings across a power down/up cycle */ -e1e_rphy (hw,MII_BMCR , &mii_reg); + ret =e1e_rphy (hw,MII_BMCR , &mii_reg); +if (ret) { +e_dbg ("Error reading PHY register\n" ); +return ; + } mii_reg |=BMCR_PDOWN ;e1e_wphy (hw,MII_BMCR , mii_reg);usleep_range (1000 ,2000 );@@ -3037,7 +3047,11 @@ s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw)return 0 ;
Quoted 13 lines
drivers/net/ethernet/intel/e1000e/phy.c s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw) · line 3057
Quoted 10 lines
drivers/net/ethernet/intel/e1000e/phy.c +5
-1/* Do not apply workaround if in PHY loopback bit 14 set */ -e1e_rphy (hw,MII_BMCR , &data); + ret_val =e1e_rphy (hw,MII_BMCR , &data); +if (ret_val) { +e_dbg ("Error reading PHY register\n" ); +return ret_val; + }if (data &BMCR_LOOPBACK )return 0 ;Generally, I am good with this patch. One question - it is old HW, any idea how to check it? (82577/82578 GbE LOM - from 2008)
Li, how did you check it manually?
These bugs are detected by static analysis. Therefore it's not run-time checked. However, since currently there is no error handling after e1e_rphy(), so I think it's necessary to at least check it and expect there is a chance to fail.
Tony Nguyen
maintainerOn 8/25/2022 11:56 PM, Li Zhong wrote:
nit: Could you mention the driver name in the commit title
e.g.
e1000e: check return value of e1e_rphy()
Thanks,
Tony
Quoted 7 lines
e1e_rphy()could return error value, which needs to be checked and reported for debugging and diagnose.Signed-off-by Li Zhong <[email protected]>--- drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan