Pull request: u-boot-dfu (04.01.2019)
Dear Marek,
The following changes since commit7436f5e54d35bcad53befec90e2e67288071f74e:
Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip
(2019-01-03 08:39:44 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-dfu.git
for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4:
dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platforms
arch/arm/dts/omap5-u-boot.dtsi | 5 +++++ drivers/usb/gadget/udc/Makefile | 3 ++- drivers/usb/gadget/udc/udc-uclass.c | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-)
Travis-Ci: https://travis-ci.org/lmajewski/u-boot-dfu/builds/475053011
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190104/f7660fdc/attachment.sig>
Quoted 14 lines · Lukasz Majewski
Dear Marek,
The following changes since commit
7436f5e54d35bcad53befec90e2e67288071f74e:Merge tag 'for-master-20190103' of
git://git.denx.de/u-boot-rockchip
(2019-01-03 08:39:44 -0500)are available in the git repository at:
git://git.denx.de/u-boot-dfu.gitfor you to fetch changes up to
deb73d0aea6ca09ecb56ea3431d3151427fff4a4:
Quoted 8 lines
dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: UseSEQ_ALIASto index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platforms
Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM .
Signature · 2 lines
Best regards, Marek Vasut
Quoted 18 lines · Marek Vasut
Quoted 17 lines · Lukasz Majewski
Dear Marek,
The following changes since commit
7436f5e54d35bcad53befec90e2e67288071f74e:Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip (2019-01-03 08:39:44 -0500)are available in the git repository at:
git://git.denx.de/u-boot-dfu.gitfor you to fetch changes up to
deb73d0aea6ca09ecb56ea3431d3151427fff4a4:dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
Quoted 8 lines
Quoted 5 lines
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: UseSEQ_ALIASto index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platformsWhy is
udc-uclass.ccompiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM .
It only adds the UCLASS_DRIVER definition for the USB gadget. The rest is compiled out inside udc-uclass.c
Quoted 1 line
Quoted 25 lines · Jean-Jacques Hiblot
Quoted 23 lines · Marek Vasut
Quoted 22 lines · Lukasz Majewski
Dear Marek,
The following changes since commit
7436f5e54d35bcad53befec90e2e67288071f74e:Merge tag 'for-master-20190103' of
git://git.denx.de/u-boot-rockchip
(2019-01-03 08:39:44 -0500)are available in the git repository at:
git://git.denx.de/u-boot-dfu.gitfor you to fetch changes up to
deb73d0aea6ca09ecb56ea3431d3151427fff4a4:dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: UseSEQ_ALIASto index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 6 lines
Quoted 3 lines
Why is
udc-uclass.ccompiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM .It only adds the
UCLASS_DRIVERdefinition for the USB gadget. The rest is compiled out insideudc-uclass.c
Why do we want it in unconditionally at all ?
Signature · 2 lines
Best regards, Marek Vasut
Quoted 25 lines · Marek Vasut
Quoted 24 lines · Jean-Jacques Hiblot
Quoted 23 lines · Marek Vasut
Quoted 22 lines · Lukasz Majewski
Dear Marek,
The following changes since commit
7436f5e54d35bcad53befec90e2e67288071f74e:Merge tag 'for-master-20190103' of
git://git.denx.de/u-boot-rockchip
(2019-01-03 08:39:44 -0500)are available in the git repository at:
git://git.denx.de/u-boot-dfu.gitfor you to fetch changes up to
deb73d0aea6ca09ecb56ea3431d3151427fff4a4:dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: UseSEQ_ALIASto index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Why is
udc-uclass.ccompiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM .It only adds the
UCLASS_DRIVERdefinition for the USB gadget. The rest is compiled out insideudc-uclass.cWhy do we want it in unconditionally at all ?
We don't really. I'll post something to make it conditional on USB_GADGET.
I'll take the opportunity to rename SPL_USB_GADGET_SUPPORT to SPL_USB_GADGET for consistency.
But this may take some time to verify (buildman and also boot check), and the current version seems to work for everyone so far.
JJ
Quoted 1 line
Quoted 36 lines · Jean-Jacques Hiblot
Quoted 27 lines · Marek Vasut
Quoted 26 lines · Jean-Jacques Hiblot
Quoted 25 lines · Marek Vasut
Quoted 24 lines · Lukasz Majewski
Dear Marek,
The following changes since commit
7436f5e54d35bcad53befec90e2e67288071f74e:Merge tag 'for-master-20190103' of
git://git.denx.de/u-boot-rockchip
(2019-01-03 08:39:44 -0500)are available in the git repository at:
git://git.denx.de/u-boot-dfu.gitfor you to fetch changes up to
deb73d0aea6ca09ecb56ea3431d3151427fff4a4:dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100)
----------------------------------------------------------------
Jean-Jacques Hiblot (3):
dm: usb: udc: UseSEQ_ALIASto index the USB gadget ports
ARM: dts: define USB aliases for all omap5 platforms
dm: usb: gadget: Fix boot breakage on sunxi platformsQuoted 6 lines
Quoted 5 lines
Quoted 3 lines
Why is
udc-uclass.ccompiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM .It only adds the
UCLASS_DRIVERdefinition for the USB gadget. The rest is compiled out insideudc-uclass.cWhy do we want it in unconditionally at all ?
Quoted 7 lines
We don't really. I'll post something to make it conditional on
USB_GADGET.I'll take the opportunity to rename
SPL_USB_GADGET_SUPPORTtoSPL_USB_GADGETfor consistency.But this may take some time to verify (buildman and also boot check), and the current version seems to work for everyone so far.
That's fine, there's still ~1 week till the release.
Signature · 2 lines
Best regards, Marek Vasut