Skip to contentSkip to conversation

2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined!

DISCUSSION Miles Lane 2 participants 2 messages Oct 10, 2006 Network drivers

lore
Share & tools
lore

Miles Lane

author
#0 lore raw

This stops the "make modules_install" process.

#1 lore raw
Quoted 1 line · Miles Lane

This stops the "make modules_install" process.

This is not only in -mm, but also in Linus' git tree. I just sent the patch below to Jeff (who is the author of the commit that broke it), which I believe might be correct:

[PATCH] fix reference to removed toshoboe_invalid_dev() in drivers/net/irda/donauboe.c

commit c31f28e778ab299a5035ea2bda64f245b8915d7c (which currently is in mainline) broke drivers/net/irda/donauboe.c, as it removes toshoboe_invalid_dev(), but this is called from toshoboe_interrupt() (your patch removed reference to it only from toshoboe_probeinterrupt().

drivers/net/irda/donauboe.c +0 -3
index 636d063..14cc217 100644
@@ -1158,9 +1158,6 @@ toshoboe_interrupt (int irq, void *dev_i
   __u8 irqstat;
   struct sk_buff *skb = NULL;
 
-  if (self == NULL && toshoboe_invalid_dev(irq))
-    return IRQ_NONE;
-
   irqstat = INB (OBOE_ISR);
 
 /* was it us */
Signature · 1 line
Jiri Kosina