Skip to contentSkip to conversation

configure: Do not intent to build WHPX on 32-bit host

PATCH In review Philippe Mathieu-Daudé 4 participants 5 messages Sep 10, 2020 – Sep 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 configure: Do not intent to build WHPX on 32-bit host

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +4 -1
index 4231d56bcc0..91c5d781845 100755
@@ -2980,7 +2980,10 @@ fi
 
 ##########################################
 # Windows Hypervisor Platform accelerator (WHPX) check
-if test "$whpx" != "no" ; then
+if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
+  error_exit "WHPX requires 64-bit host"
+fi
+if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
     if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
         whpx="yes"
     else
Signature · 1 line
2.26.2
Reviewed-by on v2 1/1
#1 lore raw

Am 10.09.20 um 07:45 schrieb Philippe Mathieu-Daudé:

Quoted 16 lines

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +0 -0
index 4231d56bcc0..91c5d781845 100755
@@ -2980,7 +2980,10 @@ fi
 

configure fi · line 2989

Quoted 10 lines
configure +4 -1
 ##########################################
 # Windows Hypervisor Platform accelerator (WHPX) check
-if test "$whpx" != "no" ; then
+if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
+  error_exit "WHPX requires 64-bit host"
+fi
+if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
     if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
         whpx="yes"
     else

Thanks!

#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 17 lines · Philippe Mathieu-Daudé

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +0 -0
index 4231d56bcc0..91c5d781845 100755
@@ -2980,7 +2980,10 @@ fi
 

configure fi · line 2989

Quoted 10 lines
configure +4 -1
 ##########################################
 # Windows Hypervisor Platform accelerator (WHPX) check
-if test "$whpx" != "no" ; then
+if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
+  error_exit "WHPX requires 64-bit host"
+fi
+if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
     if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
         whpx="yes"
     else

Queued this one instead.

Paolo

#3 lore raw
In reply to Philippe Mathieu-Daudé

On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote:

In the subject, s/intent/attempt/

Quoted 10 lines

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)

---
  configure | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org

#4 lore raw
Quoted 3 lines · Eric Blake

On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote:

In the subject, s/intent/attempt/

Oops thanks... Paolo can you fix that directly,
or should I repost?

Quoted 16 lines
Quoted 11 lines

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)
---
  configure | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)

--

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org