Skip to contentSkip to conversation

HID: usbhid: Fix use assignment in if condition

PATCH In review [email protected] 3 participants 3 messages Jul 11, 2023 – Jul 12, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 HID: usbhid: Fix use assignment in if condition

Fix the following checkpatch error(s):

drivers/hid/usbhid/usbkbd.c:238:240:242:246: ERROR: do not use assignment in if condition

---
 drivers/hid/usbhid/usbkbd.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)
drivers/hid/usbhid/usbkbd.c +0 -0
index c439ed2f16db..cde7f82b7070 100644
@@ -235,15 +235,29 @@ static void usb_kbd_close(struct input_dev *dev)
 
 static int usb_kbd_alloc_mem(struct usb_device *dev, struct usb_kbd 

*kbd)
{
- if (!(kbd->irq = usb_alloc_urb(0, GFP_KERNEL)))
+ kbd->irq = usb_alloc_urb(0, GFP_KERNEL)
+
+ if (!kbd->irq)

         return -1;

- if (!(kbd->led = usb_alloc_urb(0, GFP_KERNEL)))
+
+ kbd->led = usb_alloc_urb(0, GFP_KERNEL)
+
+ if (!kbd->led)

         return -1;

- if (!(kbd->new = usb_alloc_coherent(dev, 8, GFP_KERNEL, &kbd->new_dma)))
+
+ kbd->new = usb_alloc_coherent(dev, 8, GFP_KERNEL, &kbd->new_dma)
+
+ if (!kbd->new)

         return -1;

- if (!(kbd->cr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)))
+
+ kbd->cr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)
+
+ if (!kbd->cr)

         return -1;

- if (!(kbd->leds = usb_alloc_coherent(dev, 1, GFP_KERNEL, &kbd->leds_dma)))
+
+ kbd->leds = usb_alloc_coherent(dev, 1, GFP_KERNEL, &kbd->leds_dma)
+
+ if (!kbd->leds)

         return -1;

     return 0;
maintainer
#2 lore raw
Quoted 50 lines · On Tue, Jul 11, 2023 at 09:47:06AM +0800, [email protected] wrote:

Fix the following checkpatch error(s):

drivers/hid/usbhid/usbkbd.c:238:240:242:246: ERROR: do not use assignment in if condition

---
 drivers/hid/usbhid/usbkbd.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)
drivers/hid/usbhid/usbkbd.c +19 -5
index c439ed2f16db..cde7f82b7070 100644
@@ -235,15 +235,29 @@ static void usb_kbd_close(struct input_dev *dev)
 
 static int usb_kbd_alloc_mem(struct usb_device *dev, struct usb_kbd *kbd)
 {
-    if (!(kbd->irq = usb_alloc_urb(0, GFP_KERNEL)))
+    kbd->irq = usb_alloc_urb(0, GFP_KERNEL)
+
+    if (!kbd->irq)
         return -1;
-    if (!(kbd->led = usb_alloc_urb(0, GFP_KERNEL)))
+
+    kbd->led = usb_alloc_urb(0, GFP_KERNEL)
+
+    if (!kbd->led)
         return -1;
-    if (!(kbd->new = usb_alloc_coherent(dev, 8, GFP_KERNEL,
 &kbd->new_dma)))
+
+    kbd->new = usb_alloc_coherent(dev, 8, GFP_KERNEL, &kbd->new_dma)
+
+    if (!kbd->new)
         return -1;
-    if (!(kbd->cr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)))
+
+    kbd->cr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)
+
+    if (!kbd->cr)
         return -1;
-    if (!(kbd->leds = usb_alloc_coherent(dev, 1, GFP_KERNEL,
 &kbd->leds_dma)))
+
+    kbd->leds = usb_alloc_coherent(dev, 1, GFP_KERNEL, &kbd->leds_dma)
+
+    if (!kbd->leds)
         return -1;
Quoted 1 line
     return 0;

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#3 lore raw
Quoted 6 lines · Greg KH

You are receiving this message because of the following common error(s) as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this.

Hi Greg,

208suo.com people send their patches (including this one) using Roundcube, which is knwon to corrupt patches as you mentioned. Maybe I have to send Documentation/process/email-client.rst patch to mention this, right?

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara