staging: rtl8723bs: Delete unnecessary braces for single statement blocks in xmit_linux.c
PATCH v2 1/1 staging: rtl8723bs: Delete unnecessary braces for single statement blocks in xmit_linux.c
From: Jiwon Kim <[email protected]>
Delete braces {} for single statement blocks to shorten code.
---
v2: Fix commit message
--- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -2
@@ -144,9 +144,8 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb) psta = list_entry(plist, struct sta_info, asoc_list); stainfo_offset =rtw_stainfo_offset (pstapriv, psta); -if (stainfo_offset_valid (stainfo_offset)) { +if (stainfo_offset_valid (stainfo_offset)) chk_alive_list[chk_alive_num++] = stainfo_offset; - } }spin_unlock_bh (&pstapriv->asoc_list_lock);
Signature · 1 line
2.43.0
Quoted 1 line · On 8/4/24 13:32, [email protected] wrote:
From: Jiwon Kim <[email protected]>
please remove the above line. It is not needed
Quoted 6 lines
Delete braces {} for single statement blocks to shorten code.
Signed-off-by Jiwon Kim <[email protected]>---
v2: Fix commit message
You changed the description and the subject.
Quoted 9 lines
--- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/rtl8723bs/os_dep/xmit_linux.c +0
-0
drivers/staging/rtl8723bs/os_dep/xmit_linux.c static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb) · line 151
Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1
-2@@ -144,9 +144,8 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb) psta = list_entry(plist, struct sta_info, asoc_list); stainfo_offset =rtw_stainfo_offset (pstapriv, psta); -if (stainfo_offset_valid (stainfo_offset)) { +if (stainfo_offset_valid (stainfo_offset)) chk_alive_list[chk_alive_num++] = stainfo_offset; - } }spin_unlock_bh (&pstapriv->asoc_list_lock);
Hi Jiwon,
sorry for bothering again. Please fix above comments.
Please also remove the "net-next" in the subject. Sorry I missed to mention this earlier.
If you send in a third version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks for your support.
Bye Philipp