Skip to contentSkip to conversation

platform/x86: think-lmi: Add missing MODULE_DEVICE_TABLE

PATCH In review Zou Wei 3 participants 3 messages Jun 16, 2021 x86 platform drivers

lore
Share & tools
lore

Zou Wei

author
#0 lore raw

PATCH 1/1 platform/x86: think-lmi: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.

---
 drivers/platform/x86/think-lmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/think-lmi.c +1 -0
index 7771c93..6e1fbc4 100644
@@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = {
 	{ .guid_string = LENOVO_BIOS_SETTING_GUID },
 	{ }
 };
+MODULE_DEVICE_TABLE(vmi, tlmi_id_table);
 
 static struct wmi_driver tlmi_driver = {
 	.driver = {
Signature · 1 line
2.6.2
#1 lore raw
Quoted 15 lines · Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.

---
  drivers/platform/x86/think-lmi.c | 1 +
  1 file changed, 1 insertion(+)
drivers/platform/x86/think-lmi.c +0 -0
index 7771c93..6e1fbc4 100644

drivers/platform/x86/think-lmi.c static const struct wmi_device_id tlmi_id_table[] = { · line 876

Quoted 4 lines
drivers/platform/x86/think-lmi.c +1 -0
@@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = {
  	{ .guid_string = LENOVO_BIOS_SETTING_GUID },
  	{ }
  };
+MODULE_DEVICE_TABLE(vmi, tlmi_id_table);

I assume this should be "wmi", i.e.

    MODULE_DEVICE_TABLE(wmi, tlmi_id_table);

instead of "vmi"?

Regards,
Max

Quoted 4 lines
drivers/platform/x86/think-lmi.c +0 -0
  static struct wmi_driver tlmi_driver = {
  	.driver = {
 
#2 lore raw
In reply to Zou Wei

Hi,

Quoted 6 lines · Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I've fixed up the vmi typo notices by Maximillian while applying the patch.

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 17 lines
---
 drivers/platform/x86/think-lmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/think-lmi.c +1 -0
index 7771c93..6e1fbc4 100644
@@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = {
 	{ .guid_string = LENOVO_BIOS_SETTING_GUID },
 	{ }
 };
+MODULE_DEVICE_TABLE(vmi, tlmi_id_table);
 
 static struct wmi_driver tlmi_driver = {
 	.driver = {