drm/i915: Introduce .set_link_train() vfunc
Subsystems (3)
PATCH 1/4 drm/i915: Introduce .set_link_train() vfunc
From: Ville Syrjälä <[email protected]>
Sort out some of the mess between intel_ddi.c intel_dp.c by introducing a .set_link_train() vfunc.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 42 +++++ .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 148 ++++++++---------- 3 files changed, 107 insertions(+), 84 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +42 -0
@@ -3949,6 +3949,46 @@ static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp)udelay (600 ); } +static void intel_ddi_set_link_train (struct intel_dp *intel_dp, +u8 dp_train_pat) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_pat_mask =drm_dp_training_pattern_mask (intel_dp->dpcd); +enum port port =dp_to_dig_port (intel_dp)->base.port; +u32 temp; + + temp =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); + +if (dp_train_pat &DP_LINK_SCRAMBLING_DISABLE ) + temp |=DP_TP_CTL_SCRAMBLE_DISABLE ; +else + temp &= ~DP_TP_CTL_SCRAMBLE_DISABLE ; + + temp &= ~DP_TP_CTL_LINK_TRAIN_MASK ; +switch (dp_train_pat & train_pat_mask) { +case DP_TRAINING_PATTERN_DISABLE : + temp |=DP_TP_CTL_LINK_TRAIN_NORMAL ; +break ; +case DP_TRAINING_PATTERN_1 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT1 ; +break ; +case DP_TRAINING_PATTERN_2 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT2 ; +break ; +case DP_TRAINING_PATTERN_3 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT3 ; +break ; +case DP_TRAINING_PATTERN_4 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT4 ; +break ; + } + +intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, temp); + +intel_de_write (dev_priv,DDI_BUF_CTL (port), intel_dp->DP); +intel_de_posting_read (dev_priv,DDI_BUF_CTL (port)); +} +static bool intel_ddi_is_audio_enabled (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {
@@ -4393,6 +4433,8 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_dig_port->dp.output_reg =DDI_BUF_CTL (port); intel_dig_port->dp.prepare_link_retrain = intel_ddi_prepare_link_retrain; + intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; +if (INTEL_GEN (dev_priv) <12 ) { intel_dig_port->dp.regs.dp_tp_ctl =DP_TP_CTL (port); intel_dig_port->dp.regs.dp_tp_status =DP_TP_STATUS (port);
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1368,6 +1368,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp); +void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat);/* Displayport compliance testing */ struct intel_dp_compliance compliance;
drivers/gpu/drm/i915/display/intel_dp.c +64 -84
174 lines not on this page · raw message
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/4 drm/i915: Introduce .set_signal_levels() vfunc
From: Ville Syrjälä <[email protected]>
Sort out some of the mess between intel_ddi.c intel_dp.c by introducing a .set_signal_levels() vfunc.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 81 +++++++--- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 146 +++++++++++------- 3 files changed, 150 insertions(+), 78 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +60 -21
@@ -2659,38 +2659,66 @@ static u32 intel_ddi_dp_level(struct intel_dp *intel_dp)return translate_signal_level (signal_levels); } -u32 bxt_signal_levels (struct intel_dp *intel_dp) +static void +tgl_set_signal_levels (struct intel_dp *intel_dp) { -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv =to_i915 (dport->base.base.dev); -struct intel_encoder *encoder = &dport->base; +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base;int level =intel_ddi_dp_level (intel_dp); -if (INTEL_GEN (dev_priv) >=12 ) -tgl_ddi_vswing_sequence (encoder, intel_dp->link_rate, - level, encoder->type); -else if (INTEL_GEN (dev_priv) >=11 ) -icl_ddi_vswing_sequence (encoder, intel_dp->link_rate, - level, encoder->type); -else if (IS_CANNONLAKE (dev_priv)) -cnl_ddi_vswing_sequence (encoder, level, encoder->type); -else -bxt_ddi_vswing_sequence (encoder, level, encoder->type); - -return 0 ; +tgl_ddi_vswing_sequence (encoder, intel_dp->link_rate, + level, encoder->type); } -u32 ddi_signal_levels (struct intel_dp *intel_dp) +static void +icl_set_signal_levels (struct intel_dp *intel_dp) { -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv =to_i915 (dport->base.base.dev); -struct intel_encoder *encoder = &dport->base; +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base;int level =intel_ddi_dp_level (intel_dp); +icl_ddi_vswing_sequence (encoder, intel_dp->link_rate, + level, encoder->type); +} + +static void +cnl_set_signal_levels (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +int level =intel_ddi_dp_level (intel_dp); + +cnl_ddi_vswing_sequence (encoder, level, encoder->type); +} + +static void +bxt_set_signal_levels (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +int level =intel_ddi_dp_level (intel_dp); + +bxt_ddi_vswing_sequence (encoder, level, encoder->type); +} + +static void +hsw_set_signal_levels (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +int level =intel_ddi_dp_level (intel_dp); +enum port port = encoder->port; +u32 signal_levels; + + signal_levels =DDI_BUF_TRANS_SELECT (level); + +drm_dbg_kms (&dev_priv->drm,"Using signal levels %08x\n" , + signal_levels); + + intel_dp->DP &= ~DDI_BUF_EMP_MASK ; + intel_dp->DP |= signal_levels; +if (IS_GEN9_BC (dev_priv))skl_ddi_set_iboost (encoder, level, encoder->type); -return DDI_BUF_TRANS_SELECT (level); +intel_de_write (dev_priv,DDI_BUF_CTL (port), intel_dp->DP); +intel_de_posting_read (dev_priv,DDI_BUF_CTL (port)); } static inline
@@ -4435,6 +4463,17 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_ddi_prepare_link_retrain; intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; +if (INTEL_GEN (dev_priv) >=12 ) + intel_dig_port->dp.set_signal_levels = tgl_set_signal_levels; +else if (INTEL_GEN (dev_priv) >=11 ) + intel_dig_port->dp.set_signal_levels = icl_set_signal_levels; +else if (IS_CANNONLAKE (dev_priv)) + intel_dig_port->dp.set_signal_levels = cnl_set_signal_levels; +else if (IS_GEN9_LP (dev_priv)) + intel_dig_port->dp.set_signal_levels = bxt_set_signal_levels; +else + intel_dig_port->dp.set_signal_levels = hsw_set_signal_levels; +if (INTEL_GEN (dev_priv) <12 ) { intel_dig_port->dp.regs.dp_tp_ctl =DP_TP_CTL (port); intel_dig_port->dp.regs.dp_tp_status =DP_TP_STATUS (port);
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1369,6 +1369,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp);void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat); +void (*set_signal_levels)(struct intel_dp *intel_dp);/* Displayport compliance testing */ struct intel_dp_compliance compliance;
drivers/gpu/drm/i915/display/intel_dp.c +89 -57
257 lines not on this page · raw message
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/4] drm/i915: Introduce .set_signal_levels() vfunc
Quoted 4 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Sort out some of the mess between
intel_ddi.cintel_dp.cby introducing a .set_signal_levels() vfunc.
Quoted 445 lines
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 81 +++++++--- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 146 +++++++++++----- -- 3 files changed, 150 insertions(+), 78 deletions(-)drivers/gpu/drm/i915/display/intel_ddi.c +34
-20@@ -2659,38 +2659,66 @@ static u32 intel_ddi_dp_level(struct intel_dp *intel_dp)return translate_signal_level (signal_levels); } -u32 bxt_signal_levels (struct intel_dp *intel_dp) +static void +tgl_set_signal_levels (struct intel_dp *intel_dp) { -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv =to_i915 (dport- >base.base.dev); -struct intel_encoder *encoder = &dport->base; +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)- >base;int level =intel_ddi_dp_level (intel_dp); -if (INTEL_GEN (dev_priv) >=12 ) -tgl_ddi_vswing_sequence (encoder, intel_dp->link_rate, - level, encoder->type); -else if (INTEL_GEN (dev_priv) >=11 ) -icl_ddi_vswing_sequence (encoder, intel_dp->link_rate, - level, encoder->type); -else if (IS_CANNONLAKE (dev_priv)) -cnl_ddi_vswing_sequence (encoder, level, encoder->type); -else -bxt_ddi_vswing_sequence (encoder, level, encoder->type); - -return 0 ; +tgl_ddi_vswing_sequence (encoder, intel_dp->link_rate, + level, encoder->type); } -u32 ddi_signal_levels (struct intel_dp *intel_dp) +static void +icl_set_signal_levels (struct intel_dp *intel_dp) { -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv =to_i915 (dport- >base.base.dev); -struct intel_encoder *encoder = &dport->base; +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)- >base;int level =intel_ddi_dp_level (intel_dp); +icl_ddi_vswing_sequence (encoder, intel_dp->link_rate, + level, encoder->type); +} + +static void +cnl_set_signal_levels (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)- >base; +int level =intel_ddi_dp_level (intel_dp); + +cnl_ddi_vswing_sequence (encoder, level, encoder->type); +} + +static void +bxt_set_signal_levels (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)- >base; +int level =intel_ddi_dp_level (intel_dp); + +bxt_ddi_vswing_sequence (encoder, level, encoder->type); +} + +static void +hsw_set_signal_levels (struct intel_dp *intel_dp) +{ + struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)-Quoted 1 line
base;
drivers/gpu/drm/i915/display/intel_ddi.c +21
-1+struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +int level =intel_ddi_dp_level (intel_dp); +enum port port = encoder->port; +u32 signal_levels; + + signal_levels =DDI_BUF_TRANS_SELECT (level); + +drm_dbg_kms (&dev_priv->drm,"Using signal levels %08x\n" , + signal_levels); + + intel_dp->DP &= ~DDI_BUF_EMP_MASK ; + intel_dp->DP |= signal_levels; +if (IS_GEN9_BC (dev_priv))skl_ddi_set_iboost (encoder, level, encoder->type); -return DDI_BUF_TRANS_SELECT (level); +intel_de_write (dev_priv,DDI_BUF_CTL (port), intel_dp->DP); +intel_de_posting_read (dev_priv,DDI_BUF_CTL (port)); } static inline@@ -4435,6 +4463,17 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_ddi_prepare_link_retrain; intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; +if (INTEL_GEN (dev_priv) >=12 ) + intel_dig_port->dp.set_signal_levels = tgl_set_signal_levels; +else if (INTEL_GEN (dev_priv) >=11 ) + intel_dig_port->dp.set_signal_levels = icl_set_signal_levels; +else if (IS_CANNONLAKE (dev_priv)) + intel_dig_port->dp.set_signal_levels =
cnl_set_signal_levels;drivers/gpu/drm/i915/display/intel_ddi.c +2
-0+else if (IS_GEN9_LP (dev_priv)) + intel_dig_port->dp.set_signal_levels =
bxt_set_signal_levels;drivers/gpu/drm/i915/display/intel_ddi.c +2
-0+else + intel_dig_port->dp.set_signal_levels =
hsw_set_signal_levels;drivers/gpu/drm/i915/display/intel_ddi.c +1
-0+if (INTEL_GEN (dev_priv) <12 ) { intel_dig_port->dp.regs.dp_tp_ctl =DP_TP_CTL (port); intel_dig_port->dp.regs.dp_tp_status =
DP_TP_STATUS(port);drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1369,6 +1369,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp);void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat); +void (*set_signal_levels)(struct intel_dp *intel_dp);/* Displayport compliance testing */ drivers/gpu/drm/i915/display/intel_display_types.h +0
-0struct intel_dp_compliance compliance;drivers/gpu/drm/i915/display/intel_dp.c +1
-1@@ -4033,7 +4033,7 @@ intel_dp_pre_emphasis_max(struct intel_dp *intel_dp, u8 voltage_swing) } } -static u32 vlv_signal_levels (struct intel_dp *intel_dp) +static void vlv_set_signal_levels (struct intel_dp *intel_dp) { struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)-Quoted 1 line
base;
drivers/gpu/drm/i915/display/intel_dp.c +1
-1unsigned long demph_reg_value, preemph_reg_value,@@ -4061,7 +4061,7 @@ static u32 vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x5598DA3A ;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +1
-1case DP_TRAIN_PRE_EMPH_LEVEL_1 :@@ -4080,7 +4080,7 @@ static u32 vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +1
-1case DP_TRAIN_PRE_EMPH_LEVEL_2 :@@ -4095,7 +4095,7 @@ static u32 vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +3
-5case DP_TRAIN_PRE_EMPH_LEVEL_3 :@@ -4106,20 +4106,18 @@ static u32 vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +return ; }break ;default : -return 0 ; +return ; }vlv_set_phy_signal_level (encoder, demph_reg_value, preemph_reg_value, uniqtranscale_reg_value,0 ); - -return 0 ; } -static u32 chv_signal_levels (struct intel_dp *intel_dp) +static void chv_set_signal_levels (struct intel_dp *intel_dp) {struct
intel_encoder*encoder = &dp_to_dig_port(intel_dp)-Quoted 1 line
base;
drivers/gpu/drm/i915/display/intel_dp.c +1
-1u32 deemph_reg_value, margin_reg_value;@@ -4147,7 +4145,7 @@ static u32 chv_signal_levels(struct intel_dp *intel_dp) uniq_trans_scale = true;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +1
-1case DP_TRAIN_PRE_EMPH_LEVEL_1 :@@ -4165,7 +4163,7 @@ static u32 chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +1
-1case DP_TRAIN_PRE_EMPH_LEVEL_2 :@@ -4179,7 +4177,7 @@ static u32 chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +return ; }break ;drivers/gpu/drm/i915/display/intel_dp.c +26
-10case DP_TRAIN_PRE_EMPH_LEVEL_3 :@@ -4189,21 +4187,18 @@ static u32 chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +return ; }break ;default : -return 0 ; +return ; }chv_set_phy_signal_level (encoder, deemph_reg_value, margin_reg_value, uniq_trans_scale); - -return 0 ; } -static u32 -g4x_signal_levels (u8 train_set) +static u32 g4x_signal_levels (u8 train_set) {u32 signal_levels =0 ;@@ -4240,12 +4235,31 @@ g4x_signal_levels(u8 train_set)return signal_levels; } +static void +g4x_set_signal_levels (struct intel_dp *intel_dp) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_set = intel_dp->train_set[0 ]; +u32 signal_levels; + + signal_levels =g4x_signal_levels (train_set); + +drm_dbg_kms (&dev_priv->drm,"Using signal levels %08x\n" , + signal_levels); + + intel_dp->DP &= ~(DP_VOLTAGE_MASK |DP_PRE_EMPHASIS_MASK ); + intel_dp->DP |= signal_levels; + +intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); +intel_de_posting_read (dev_priv, intel_dp->output_reg); +} +/* SNB CPU eDP voltage swing and pre-emphasis control */ -static u32 -snb_cpu_edp_signal_levels (u8 train_set) +static u32 snb_cpu_edp_signal_levels (u8 train_set) { -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK ); +u8 signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | +DP_TRAIN_PRE_EMPHASIS_MASK ); +switch (signal_levels) { case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |
DP_TRAIN_PRE_EMPH_LEVEL_0:
caseDP_TRAIN_VOLTAGE_SWING_LEVEL_1|DP_TRAIN_PRE_EMPH_LEVEL_0:drivers/gpu/drm/i915/display/intel_dp.c +23
-4@@ -4268,12 +4282,31 @@ snb_cpu_edp_signal_levels(u8 train_set) } } +static void +snb_cpu_edp_set_signal_levels (struct intel_dp *intel_dp) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_set = intel_dp->train_set[0 ]; +u32 signal_levels; + + signal_levels =snb_cpu_edp_signal_levels (train_set); + +drm_dbg_kms (&dev_priv->drm,"Using signal levels %08x\n" , + signal_levels); + + intel_dp->DP &= ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB ; + intel_dp->DP |= signal_levels; + +intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); +intel_de_posting_read (dev_priv, intel_dp->output_reg); +} +/* IVB CPU eDP voltage swing and pre-emphasis control */ -static u32 -ivb_cpu_edp_signal_levels (u8 train_set) +static u32 ivb_cpu_edp_signal_levels (u8 train_set) { -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK ); +u8 signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | +DP_TRAIN_PRE_EMPHASIS_MASK ); +switch (signal_levels) { case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |
DP_TRAIN_PRE_EMPH_LEVEL_0:drivers/gpu/drm/i915/display/intel_dp.c +18
-27return EDP_LINK_TRAIN_400MV_0DB_IVB ;@@ -4299,38 +4332,29 @@ ivb_cpu_edp_signal_levels(u8 train_set) } } -void -intel_dp_set_signal_levels (struct intel_dp *intel_dp) +static void +ivb_cpu_edp_set_signal_levels (struct intel_dp *intel_dp) {struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -enum port port = intel_dig_port->base.port; -u32 signal_levels, mask =0 ;u8 train_set = intel_dp->train_set[0 ]; +u32 signal_levels; -if (IS_GEN9_LP (dev_priv) ||INTEL_GEN (dev_priv) >=10 ) { - signal_levels =bxt_signal_levels (intel_dp); - }else if (HAS_DDI (dev_priv)) { - signal_levels =ddi_signal_levels (intel_dp); - mask =DDI_BUF_EMP_MASK ; - }else if (IS_CHERRYVIEW (dev_priv)) { - signal_levels =chv_signal_levels (intel_dp); - }else if (IS_VALLEYVIEW (dev_priv)) { - signal_levels =vlv_signal_levels (intel_dp); - }else if (IS_IVYBRIDGE (dev_priv) && port ==PORT_A ) { - signal_levels =ivb_cpu_edp_signal_levels (train_set); - mask =EDP_LINK_TRAIN_VOL_EMP_MASK_IVB ; - }else if (IS_GEN (dev_priv,6 ) && port ==PORT_A ) { - signal_levels =snb_cpu_edp_signal_levels (train_set); - mask =EDP_LINK_TRAIN_VOL_EMP_MASK_SNB ; - }else { - signal_levels =g4x_signal_levels (train_set); - mask =DP_VOLTAGE_MASK |DP_PRE_EMPHASIS_MASK ; - } + signal_levels =ivb_cpu_edp_signal_levels (train_set); -if (mask) - drm_dbg_kms(&dev_priv->drm, "Using signal levels %08x\n", - signal_levels); + drm_dbg_kms(&dev_priv->drm,"Using signal levels %08x\n" , + signal_levels); + + intel_dp->DP &= ~EDP_LINK_TRAIN_VOL_EMP_MASK_IVB ; + intel_dp->DP |= signal_levels; + +intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); +intel_de_posting_read (dev_priv, intel_dp->output_reg); +} + +void intel_dp_set_signal_levels (struct intel_dp *intel_dp) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_set = intel_dp->train_set[0 ];drivers/gpu/drm/i915/display/intel_dp.c +1
-4drm_dbg_kms(&dev_priv->drm, "Using vswing level %d%s\n", train_set & DP_TRAIN_VOLTAGE_SWING_MASK,@@ -4341,10 +4365,7 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp) train_set &DP_TRAIN_MAX_PRE_EMPHASIS_REACHED ? " (max)" : ""); - intel_dp->DP = (intel_dp->DP & ~mask) | signal_levels; - -intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); -intel_de_posting_read (dev_priv, intel_dp->output_reg); + intel_dp->set_signal_levels (intel_dp); }void
drivers/gpu/drm/i915/display/intel_dp.c +6
-0@@ -8515,6 +8536,17 @@ bool intel_dp_init(struct drm_i915_private *dev_priv, else intel_dig_port->dp.set_link_train = g4x_set_link_train; +if (IS_CHERRYVIEW (dev_priv)) + intel_dig_port->dp.set_signal_levels = chv_set_signal_levels; +else if (IS_VALLEYVIEW (dev_priv)) + intel_dig_port->dp.set_signal_levels = vlv_set_signal_levels; +else if (IS_IVYBRIDGE (dev_priv) && port ==PORT_A ) + intel_dig_port->dp.set_signal_levels =
ivb_cpu_edp_set_signal_levels;drivers/gpu/drm/i915/display/intel_dp.c +2
-0+else if (IS_GEN (dev_priv,6 ) && port ==PORT_A ) + intel_dig_port->dp.set_signal_levels =
snb_cpu_edp_set_signal_levels;drivers/gpu/drm/i915/display/intel_dp.c +2
-0+else + intel_dig_port->dp.set_signal_levels =
g4x_set_signal_levels;
drivers/gpu/drm/i915/display/intel_dp.c bool intel_dp_init(struct drm_i915_private *dev_priv, · line 8552
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +1
-0+ intel_dig_port->dp.output_reg = output_reg; intel_dig_port->max_lanes =4 ; intel_dig_port->dp.regs.dp_tp_ctl =DP_TP_CTL (port);
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/4 drm/i915: Introduce .set_idle_link_train() vfunc
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Relocate a binch of DDI specific code from intel_dp.c to intel_ddi.c by introducing a .set_idle_link_train() vfunc.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 29 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 29 ++----------------- 3 files changed, 32 insertions(+), 27 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +29 -0
@@ -4017,6 +4017,34 @@ static void intel_ddi_set_link_train(struct intel_dp *intel_dp,intel_de_posting_read (dev_priv,DDI_BUF_CTL (port)); } +static void intel_ddi_set_idle_link_train (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +enum port port = encoder->port; +u32 val; + + val =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); + val &= ~DP_TP_CTL_LINK_TRAIN_MASK ; + val |=DP_TP_CTL_LINK_TRAIN_IDLE ; +intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, val); + +/* +* Until TGL on PORT_A we can have only eDP in SST mode. There the only +* reason we need to set idle transmission mode is to work around a HW +* issue where we enable the pipe while not in idle link-training mode. +* In this case there is requirement to wait for a minimum number of +* idle patterns to be sent. +*/ +if (port ==PORT_A &&INTEL_GEN (dev_priv) <12 ) +return ; + +if (intel_de_wait_for_set (dev_priv, intel_dp->regs.dp_tp_status, +DP_TP_STATUS_IDLE_DONE ,1 )) +drm_err (&dev_priv->drm, +"Timed out waiting for DP idle patterns\n" ); +} +static bool intel_ddi_is_audio_enabled (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {
@@ -4462,6 +4490,7 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_dig_port->dp.prepare_link_retrain = intel_ddi_prepare_link_retrain; intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; + intel_dig_port->dp.set_idle_link_train = intel_ddi_set_idle_link_train;if (INTEL_GEN (dev_priv) >=12 ) intel_dig_port->dp.set_signal_levels = tgl_set_signal_levels;
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1369,6 +1369,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp);void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat); +void (*set_idle_link_train)(struct intel_dp *intel_dp);void (*set_signal_levels)(struct intel_dp *intel_dp);/* Displayport compliance testing */
drivers/gpu/drm/i915/display/intel_dp.c +2 -27
@@ -4385,33 +4385,8 @@ intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,void intel_dp_set_idle_link_train (struct intel_dp *intel_dp) { -struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -enum port port = intel_dig_port->base.port; -u32 val; - -if (!HAS_DDI (dev_priv)) -return ; - - val =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); - val &= ~DP_TP_CTL_LINK_TRAIN_MASK ; - val |=DP_TP_CTL_LINK_TRAIN_IDLE ; -intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, val); - -/* -* Until TGL on PORT_A we can have only eDP in SST mode. There the only -* reason we need to set idle transmission mode is to work around a HW -* issue where we enable the pipe while not in idle link-training mode. -* In this case there is requirement to wait for a minimum number of -* idle patterns to be sent. -*/ -if (port ==PORT_A &&INTEL_GEN (dev_priv) <12 ) -return ; - -if (intel_de_wait_for_set (dev_priv, intel_dp->regs.dp_tp_status, -DP_TP_STATUS_IDLE_DONE ,1 )) -drm_err (&dev_priv->drm, -"Timed out waiting for DP idle patterns\n" ); +if (intel_dp->set_idle_link_train) + intel_dp->set_idle_link_train (intel_dp); } static void
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/4] drm/i915: Introduce .set_idle_link_train() vfunc
Quoted 3 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Relocate a binch of DDI specific code from
intel_dp.ctointel_ddi.c
bunch
Quoted 2 lines
by introducing a .set_idle_link_train() vfunc.
Quoted 122 lines
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 29 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 29 ++--------------- -- 3 files changed, 32 insertions(+), 27 deletions(-)drivers/gpu/drm/i915/display/intel_ddi.c +14
-0@@ -4017,6 +4017,34 @@ static void intel_ddi_set_link_train(structintel_dp *intel_dp,intel_de_posting_read (dev_priv ,DDI_BUF_CTL (port )); } +static void intel_ddi_set_idle_link_train (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)- >base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +enum port port = encoder->port; +u32 val; + + val =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); + val &= ~DP_TP_CTL_LINK_TRAIN_MASK ; + val |=DP_TP_CTL_LINK_TRAIN_IDLE ; +intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, val); + +/* +* Until TGL on PORT_A we can have only eDP in SST mode. There the only
drivers/gpu/drm/i915/display/intel_ddi.c +1
-0+* reason we need to set idle transmission mode is to work around a HW
drivers/gpu/drm/i915/display/intel_ddi.c +1
-0+* issue where we enable the pipe while not in idle link- training mode.
drivers/gpu/drm/i915/display/intel_ddi.c +1
-0+* In this case there is requirement to wait for a minimum number of
drivers/gpu/drm/i915/display/intel_ddi.c +6
-0+* idle patterns to be sent. +*/ +if (port ==PORT_A &&INTEL_GEN (dev_priv) <12 ) +return ; + + if (intel_de_wait_for_set(dev_priv, intel_dp-Quoted 1 line
regs.dp_tp_status,
drivers/gpu/drm/i915/display/intel_ddi.c +5
-0+ DP_TP_STATUS_IDLE_DONE, 1)) +drm_err (&dev_priv->drm, +"Timed out waiting for DP idle patterns\n" ); +} + static bool intel_ddi_is_audio_enabled(struct drm_i915_private
*dev_priv,drivers/gpu/drm/i915/display/intel_ddi.c +1
-0enum transcoder cpu_transcoder) {@@ -4462,6 +4490,7 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_dig_port->dp.prepare_link_retrain = intel_ddi_prepare_link_retrain; intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; + intel_dig_port->dp.set_idle_link_train = intel_ddi_set_idle_link_train;drivers/gpu/drm/i915/display/intel_ddi.c +0
-0if (INTEL_GEN (dev_priv) >=12 ) intel_dig_port->dp.set_signal_levels =
tgl_set_signal_levels;drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1369,6 +1369,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp);void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat); +void (*set_idle_link_train)(struct intel_dp *intel_dp);void (*set_signal_levels)(struct intel_dp *intel_dp);drivers/gpu/drm/i915/display/intel_display_types.h +0
-0/* Displayport compliance testing */ drivers/gpu/drm/i915/display/intel_dp.c +0
-15@@ -4385,33 +4385,8 @@ intel_dp_program_link_training_pattern(structintel_dp *intel_dp, void intel_dp_set_idle_link_train(struct intel_dp *intel_dp) { - struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp ); -enum port port = intel_dig_port->base.port; -u32 val; - -if (!HAS_DDI (dev_priv)) -return ; - - val =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); - val &= ~DP_TP_CTL_LINK_TRAIN_MASK ; - val |=DP_TP_CTL_LINK_TRAIN_IDLE ; -intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, val); - -/* -* Until TGL on PORT_A we can have only eDP in SST mode. There the only
drivers/gpu/drm/i915/display/intel_dp.c +0
-1-* reason we need to set idle transmission mode is to work around a HW
drivers/gpu/drm/i915/display/intel_dp.c +0
-1-* issue where we enable the pipe while not in idle link- training mode.
drivers/gpu/drm/i915/display/intel_dp.c +0
-1-* In this case there is requirement to wait for a minimum number of
drivers/gpu/drm/i915/display/intel_dp.c +0
-6-* idle patterns to be sent. -*/ -if (port ==PORT_A &&INTEL_GEN (dev_priv) <12 ) -return ; - - if (intel_de_wait_for_set(dev_priv, intel_dp-Quoted 1 line
regs.dp_tp_status,
drivers/gpu/drm/i915/display/intel_dp.c intel_dp_program_link_training_pattern(struct intel_dp *intel_dp, · line 4392
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp.c +2
-3- DP_TP_STATUS_IDLE_DONE, 1)) -drm_err (&dev_priv->drm, -"Timed out waiting for DP idle patterns\n" ); +if (intel_dp->set_idle_link_train) + intel_dp->set_idle_link_train (intel_dp); } static void
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/4 drm/i915: Split some long lines
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Split some overly long lines.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +8 -2
@@ -1261,7 +1261,10 @@ void hsw_fdi_link_train(struct intel_encoder *encoder,for (i =0 ; i <ARRAY_SIZE (hsw_ddi_translations_fdi) *2 ; i++) {/* Configure DP_TP_CTL with auto-training */ intel_de_write (dev_priv,DP_TP_CTL (PORT_E ), -DP_TP_CTL_FDI_AUTOTRAIN |DP_TP_CTL_ENHANCED_FRAME_ENABLE |DP_TP_CTL_LINK_TRAIN_PAT1 |DP_TP_CTL_ENABLE ); +DP_TP_CTL_FDI_AUTOTRAIN | +DP_TP_CTL_ENHANCED_FRAME_ENABLE | +DP_TP_CTL_LINK_TRAIN_PAT1 | +DP_TP_CTL_ENABLE );/* Configure and enable DDI_BUF_CTL for DDI E with next voltage. * DDI E does not support port reversal, the functionality is
@@ -1337,7 +1340,10 @@ void hsw_fdi_link_train(struct intel_encoder *encoder,/* Enable normal pixel sending for FDI */ intel_de_write (dev_priv,DP_TP_CTL (PORT_E ), -DP_TP_CTL_FDI_AUTOTRAIN |DP_TP_CTL_LINK_TRAIN_NORMAL |DP_TP_CTL_ENHANCED_FRAME_ENABLE |DP_TP_CTL_ENABLE ); +DP_TP_CTL_FDI_AUTOTRAIN | +DP_TP_CTL_LINK_TRAIN_NORMAL | +DP_TP_CTL_ENHANCED_FRAME_ENABLE | +DP_TP_CTL_ENABLE ); }static void intel_ddi_init_dp_buf_reg (struct intel_encoder *encoder)
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/4] drm/i915: Split some long lines
Quoted 3 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Split some overly long lines.
Quoted 37 lines
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_ddi.c +0
-1@@ -1261,7 +1261,10 @@ void hsw_fdi_link_train(struct intel_encoder *encoder, for (i = 0; i < ARRAY_SIZE(hsw_ddi_translations_fdi) * 2; i++) {/* Configure DP_TP_CTL with auto-training */ intel_de_write(dev_priv, DP_TP_CTL(PORT_E), - DP_TP_CTL_FDI_AUTOTRAIN |
DP_TP_CTL_ENHANCED_FRAME_ENABLE|DP_TP_CTL_LINK_TRAIN_PAT1|DP_TP_CTL_ENABLE);drivers/gpu/drm/i915/display/intel_ddi.c +4
-0+DP_TP_CTL_FDI_AUTOTRAIN | +DP_TP_CTL_ENHANCED_FRAME_ENABLE | +DP_TP_CTL_LINK_TRAIN_PAT1 | + DP_TP_CTL_ENABLE);/* Configure and enable DDI_BUF_CTL for DDI E with next voltage.
* DDI E does not support port reversal, the
functionality isdrivers/gpu/drm/i915/display/intel_ddi.c +0
-1@@ -1337,7 +1340,10 @@ void hsw_fdi_link_train(struct intel_encoder *encoder,/* Enable normal pixel sending for FDI */ intel_de_write(dev_priv, DP_TP_CTL(PORT_E), - DP_TP_CTL_FDI_AUTOTRAIN |
DP_TP_CTL_LINK_TRAIN_NORMAL|DP_TP_CTL_ENHANCED_FRAME_ENABLE|DP_TP_CTL_ENABLE);
drivers/gpu/drm/i915/display/intel_ddi.c void hsw_fdi_link_train(struct intel_encoder *encoder, · line 1349
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_ddi.c +4
-0+DP_TP_CTL_FDI_AUTOTRAIN | +DP_TP_CTL_LINK_TRAIN_NORMAL | +DP_TP_CTL_ENHANCED_FRAME_ENABLE | + DP_TP_CTL_ENABLE); }static void intel_ddi_init_dp_buf_reg (struct intel_encoder *encoder)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
URL : https://patchwork.freedesktop.org/series/76213/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8334 -> Patchwork_17391
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17391 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17391, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17391:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@mman:
- fi-bwr-2160: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-bwr-2160/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-bwr-2160/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17391 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-skl-6770hq: [DMESG-WARN][3] ([i915#203]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-skl-6770hq: [SKIP][5] ([fdo#109271]) -> [PASS][6] +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-skl-6770hq: [DMESG-WARN][7] ([i915#106]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#106]: https://gitlab.freedesktop.org/drm/intel/issues/106
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-cml-u2 fi-bdw-samus fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-skl-6700k2
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8334 -> Patchwork_17391
CI-20190529: 20190529
CI_DRM_8334: 123d6397d46c0bec471a43d2da881e87a30c5ea0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17391: 120669f6723eada8d373329f4c05d4450a56a70a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
120669f6723e drm/i915: Split some long lines 3fd36e18e77b drm/i915: Introduce .set_idle_link_train() vfunc e0f3557819bd drm/i915: Introduce .set_signal_levels() vfunc 5b77b9bf1103 drm/i915: Introduce .set_link_train() vfunc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Sort out some of the mess between
intel_ddi.cintel_dp.cby introducing a .set_link_train() vfunc.
Quoted 282 lines
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 42 +++++ .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 148 ++++++++------ ---- 3 files changed, 107 insertions(+), 84 deletions(-)drivers/gpu/drm/i915/display/intel_ddi.c +40
-0@@ -3949,6 +3949,46 @@ static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp) udelay(600); } +static void intel_ddi_set_link_train (struct intel_dp *intel_dp, +u8 dp_train_pat) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_pat_mask =drm_dp_training_pattern_mask (intel_dp- >dpcd); +enum port port =dp_to_dig_port (intel_dp)->base.port; +u32 temp; + + temp =intel_de_read (dev_priv, intel_dp->regs.dp_tp_ctl); + +if (dp_train_pat &DP_LINK_SCRAMBLING_DISABLE ) + temp |=DP_TP_CTL_SCRAMBLE_DISABLE ; +else + temp &= ~DP_TP_CTL_SCRAMBLE_DISABLE ; + + temp &= ~DP_TP_CTL_LINK_TRAIN_MASK ; +switch (dp_train_pat & train_pat_mask) { +case DP_TRAINING_PATTERN_DISABLE : + temp |=DP_TP_CTL_LINK_TRAIN_NORMAL ; +break ; +case DP_TRAINING_PATTERN_1 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT1 ; +break ; +case DP_TRAINING_PATTERN_2 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT2 ; +break ; +case DP_TRAINING_PATTERN_3 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT3 ; +break ; +case DP_TRAINING_PATTERN_4 : + temp |=DP_TP_CTL_LINK_TRAIN_PAT4 ; +break ; + } + +intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, temp); + +intel_de_write (dev_priv,DDI_BUF_CTL (port), intel_dp->DP); +intel_de_posting_read (dev_priv,DDI_BUF_CTL (port)); +} + static bool intel_ddi_is_audio_enabled(struct drm_i915_private
*dev_priv,drivers/gpu/drm/i915/display/intel_ddi.c +2
-0enum transcoder cpu_transcoder) {@@ -4393,6 +4433,8 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port) intel_dig_port->dp.output_reg = DDI_BUF_CTL(port); intel_dig_port->dp.prepare_link_retrain = intel_ddi_prepare_link_retrain; + intel_dig_port->dp.set_link_train = intel_ddi_set_link_train; +if (INTEL_GEN (dev_priv) <12 ) { intel_dig_port->dp.regs.dp_tp_ctl =DP_TP_CTL (port);
intel_dig_port->dp.regs.dp_tp_status=DP_TP_STATUS(port);drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1368,6 +1368,7 @@ struct intel_dp {/* This is called before a link training is starterd */ void (*prepare_link_retrain)(struct intel_dp *intel_dp); +void (*set_link_train)(struct intel_dp *intel_dp,u8 dp_train_pat);/* Displayport compliance testing */ drivers/gpu/drm/i915/display/intel_display_types.h +0
-0struct intel_dp_compliance compliance;drivers/gpu/drm/i915/display/intel_dp.c +24
-75@@ -3638,90 +3638,63 @@ static void chv_post_disable_dp(struct intel_atomic_state *state, }static void -_intel_dp_set_link_train (struct intel_dp *intel_dp, -u32 *DP , -u8 dp_train_pat) +cpt_set_link_train (struct intel_dp *intel_dp, +u8 dp_train_pat) {struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -enum port port = intel_dig_port->base.port; -u8 train_pat_mask =drm_dp_training_pattern_mask (intel_dp- >dpcd); - -if (dp_train_pat & train_pat_mask) +u32 *DP = &intel_dp->DP; + + *DP &= ~DP_LINK_TRAIN_MASK_CPT ; + +switch (dp_train_pat &DP_TRAINING_PATTERN_MASK ) { +case DP_TRAINING_PATTERN_DISABLE : + *DP |=DP_LINK_TRAIN_OFF_CPT ; +break ; +case DP_TRAINING_PATTERN_1 : + *DP |=DP_LINK_TRAIN_PAT_1_CPT ; +break ; +case DP_TRAINING_PATTERN_2 : + *DP |=DP_LINK_TRAIN_PAT_2_CPT ; +break ; +case DP_TRAINING_PATTERN_3 : drm_dbg_kms(&dev_priv->drm, -"Using DP training pattern TPS%d\n" , - dp_train_pat & train_pat_mask); - -if (HAS_DDI (dev_priv)) { -u32 temp =intel_de_read (dev_priv, intel_dp- >regs.dp_tp_ctl); - -if (dp_train_pat &DP_LINK_SCRAMBLING_DISABLE ) - temp |=DP_TP_CTL_SCRAMBLE_DISABLE ; -else - temp &= ~DP_TP_CTL_SCRAMBLE_DISABLE ; - - temp &= ~DP_TP_CTL_LINK_TRAIN_MASK ; -switch (dp_train_pat & train_pat_mask) { -case DP_TRAINING_PATTERN_DISABLE : - temp |=DP_TP_CTL_LINK_TRAIN_NORMAL ; - -break ; -case DP_TRAINING_PATTERN_1 : - temp |=DP_TP_CTL_LINK_TRAIN_PAT1 ; -break ; -case DP_TRAINING_PATTERN_2 : - temp |=DP_TP_CTL_LINK_TRAIN_PAT2 ; -break ; -case DP_TRAINING_PATTERN_3 : - temp |=DP_TP_CTL_LINK_TRAIN_PAT3 ; -break ; -case DP_TRAINING_PATTERN_4 : - temp |=DP_TP_CTL_LINK_TRAIN_PAT4 ; -break ; - } -intel_de_write (dev_priv, intel_dp->regs.dp_tp_ctl, temp); - - }else if ((IS_IVYBRIDGE (dev_priv) && port ==PORT_A ) || - (HAS_PCH_CPT (dev_priv) && port !=PORT_A )) { - *DP &= ~DP_LINK_TRAIN_MASK_CPT ; - -switch (dp_train_pat &DP_TRAINING_PATTERN_MASK ) { -case DP_TRAINING_PATTERN_DISABLE : - *DP |=DP_LINK_TRAIN_OFF_CPT ; -break ; -case DP_TRAINING_PATTERN_1 : - *DP |=DP_LINK_TRAIN_PAT_1_CPT ; -break ; -case DP_TRAINING_PATTERN_2 : - *DP |=DP_LINK_TRAIN_PAT_2_CPT ; -break ; -case DP_TRAINING_PATTERN_3 : -drm_dbg_kms (&dev_priv->drm, -"TPS3 not supported, using TPS2 instead\n"); - *DP |=DP_LINK_TRAIN_PAT_2_CPT ; -break ; - } + "TPS3 not supported, using TPS2 instead\n"); + *DP |=DP_LINK_TRAIN_PAT_2_CPT ; +break ; + } - }else { - *DP &= ~DP_LINK_TRAIN_MASK ; +intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); +intel_de_posting_read (dev_priv, intel_dp->output_reg); +} -switch (dp_train_pat &DP_TRAINING_PATTERN_MASK ) { -case DP_TRAINING_PATTERN_DISABLE : - *DP |=DP_LINK_TRAIN_OFF ; -break ; -case DP_TRAINING_PATTERN_1 : - *DP |=DP_LINK_TRAIN_PAT_1 ; -break ; -case DP_TRAINING_PATTERN_2 : - *DP |=DP_LINK_TRAIN_PAT_2 ; -break ; -case DP_TRAINING_PATTERN_3 : - drm_dbg_kms(&dev_priv->drm, - "TPS3 not supported, using TPS2instead\n");
drivers/gpu/drm/i915/display/intel_dp.c +22
-3- *DP |=DP_LINK_TRAIN_PAT_2 ; -break ; - } +static void +g4x_set_link_train (struct intel_dp *intel_dp, +u8 dp_train_pat) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u32 *DP = &intel_dp->DP; + + *DP &= ~DP_LINK_TRAIN_MASK ; + +switch (dp_train_pat &DP_TRAINING_PATTERN_MASK ) { +case DP_TRAINING_PATTERN_DISABLE : + *DP |=DP_LINK_TRAIN_OFF ; +break ; +case DP_TRAINING_PATTERN_1 : + *DP |=DP_LINK_TRAIN_PAT_1 ; +break ; +case DP_TRAINING_PATTERN_2 : + *DP |=DP_LINK_TRAIN_PAT_2 ; +break ; +case DP_TRAINING_PATTERN_3 : + drm_dbg_kms(&dev_priv->drm, + "TPS3 not supported, using TPS2instead\n");
drivers/gpu/drm/i915/display/intel_dp.c +12
-6+ *DP |=DP_LINK_TRAIN_PAT_2 ; +break ; } + +intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); +intel_de_posting_read (dev_priv, intel_dp->output_reg); } static void intel_dp_enable_port(struct intel_dp *intel_dp,@@ -4378,14 +4351,15 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp, u8 dp_train_pat) { -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv = -to_i915 (intel_dig_port->base.base.dev); +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +u8 train_pat_mask =drm_dp_training_pattern_mask (intel_dp- >dpcd); -_intel_dp_set_link_train (intel_dp, &intel_dp->DP, dp_train_pat); +if (dp_train_pat & train_pat_mask) +drm_dbg_kms (&dev_priv->drm, +"Using DP training pattern TPS%d\n" , + dp_train_pat & train_pat_mask); -intel_de_write (dev_priv, intel_dp->output_reg, intel_dp->DP); -intel_de_posting_read (dev_priv, intel_dp->output_reg); + intel_dp->set_link_train (intel_dp, dp_train_pat);}
void
intel_dp_set_idle_link_train(struct intel_dp *intel_dp)drivers/gpu/drm/i915/display/intel_dp.c +6
-0@@ -8535,6 +8509,12 @@ bool intel_dp_init(struct drm_i915_private *dev_priv, intel_encoder->post_disable = g4x_post_disable_dp; } +if ((IS_IVYBRIDGE (dev_priv) && port ==PORT_A ) || + (HAS_PCH_CPT (dev_priv) && port !=PORT_A )) + intel_dig_port->dp.set_link_train = cpt_set_link_train; +else + intel_dig_port->dp.set_link_train = g4x_set_link_train; + intel_dig_port->dp.output_reg = output_reg; intel_dig_port->max_lanes =4 ;
Quoted 1 line
intel_dig_port->dp.regs.dp_tp_ctl=DP_TP_CTL(port);
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
URL : https://patchwork.freedesktop.org/series/76213/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8334 -> Patchwork_17391
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/index.html
Known issues
------------
Here are the changes found in Patchwork_17391 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@mman:
- fi-bwr-2160: [PASS][1] -> [FAIL][2] ([i915#1763])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-bwr-2160/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-bwr-2160/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-skl-6770hq: [DMESG-WARN][3] ([i915#203]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-skl-6770hq: [SKIP][5] ([fdo#109271]) -> [PASS][6] +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-skl-6770hq: [DMESG-WARN][7] ([i915#106]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/fi-skl-6770hq/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/fi-skl-6770hq/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#106]: https://gitlab.freedesktop.org/drm/intel/issues/106
[i915#1763]: https://gitlab.freedesktop.org/drm/intel/issues/1763
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-cml-u2 fi-bdw-samus fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-skl-6700k2
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8334 -> Patchwork_17391
CI-20190529: 20190529
CI_DRM_8334: 123d6397d46c0bec471a43d2da881e87a30c5ea0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17391: 120669f6723eada8d373329f4c05d4450a56a70a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
120669f6723e drm/i915: Split some long lines 3fd36e18e77b drm/i915: Introduce .set_idle_link_train() vfunc e0f3557819bd drm/i915: Introduce .set_signal_levels() vfunc 5b77b9bf1103 drm/i915: Introduce .set_link_train() vfunc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
URL : https://patchwork.freedesktop.org/series/76213/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8334_full -> Patchwork_17391_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17391_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-hang@rcs0:
- shard-iclb: [PASS][1] -> [FAIL][2] ([i915#1622])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb1/igt@gem_ctx_persistence@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb3/igt@gem_ctx_persistence@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-apl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-apl6/igt@[email protected]
* igt@i915_selftest@live@requests:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([i915#1531] / [i915#1658])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-tglb7/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-tglb2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@vma:
- shard-snb: [PASS][7] -> [FAIL][8] ([i915#1763]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-snb2/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-snb2/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#69])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl9/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl4/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#1119] / [i915#93] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-kbl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#1119] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-apl4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-apl6/igt@[email protected]
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#128])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl8/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109349])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb8/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#1188])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-kbl1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl10/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl3/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][25] -> [FAIL][26] ([i915#173])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb2/igt@kms_psr@no_drrs.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Possible fixes ####
* igt@gem_ctx_persistence@engines-mixed-process@vecs0:
- shard-skl: [FAIL][29] ([i915#1528]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl4/igt@gem_ctx_persistence@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl2/igt@gem_ctx_persistence@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][31] ([i915#180]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-apl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-apl2/igt@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank@c-edp1}:
- shard-skl: [FAIL][33] ([i915#79]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl1/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl1/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-kbl1/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-kbl1/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-suspend@c-edp1}:
- shard-skl: [INCOMPLETE][37] ([i915#198]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl8/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][39] ([i915#1188]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][41] ([fdo#108145] / [i915#265]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-skl9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][45] ([i915#180] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-apl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-apl7/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-hsw: [INCOMPLETE][47] ([i915#61]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-hsw4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-hsw1/igt@[email protected]
* {igt@perf@polling-parameterized}:
- shard-hsw: [FAIL][49] ([i915#1542]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-hsw6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-hsw4/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][51] ([i915#588]) -> [SKIP][52] ([i915#658])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb8/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][53] ([i915#454]) -> [SKIP][54] ([i915#468])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-tglb8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-tglb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][55] ([i915#1515]) -> [WARN][56] ([i915#1515])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-iclb3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-iclb4/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-tglb: [DMESG-FAIL][57] ([i915#1744]) -> [DMESG-FAIL][58] ([i915#1759])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-tglb7/igt@i915_selftest@live@gt_pm.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-tglb2/igt@i915_selftest@live@gt_pm.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: [FAIL][59] ([fdo#108145] / [i915#265]) -> [FAIL][60] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8334/shard-kbl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/shard-kbl7/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1531]: https://gitlab.freedesktop.org/drm/intel/issues/1531
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1622]: https://gitlab.freedesktop.org/drm/intel/issues/1622
[i915#1658]: https://gitlab.freedesktop.org/drm/intel/issues/1658
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1744]: https://gitlab.freedesktop.org/drm/intel/issues/1744
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1763]: https://gitlab.freedesktop.org/drm/intel/issues/1763
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8334 -> Patchwork_17391
CI-20190529: 20190529
CI_DRM_8334: 123d6397d46c0bec471a43d2da881e87a30c5ea0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17391: 120669f6723eada8d373329f4c05d4450a56a70a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17391/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx