block: nbd: fix order of cleaning up the queue and freeing the tagset
Subsystems (2)
PATCH 1/1 block: nbd: fix order of cleaning up the queue and freeing the tagset
Must release the queue before freeing the tagset.
--- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/nbd.c +1 -1
@@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)if (disk) {del_gendisk (disk); -blk_mq_free_tag_set (&nbd->tag_set);blk_cleanup_disk (disk); +blk_mq_free_tag_set (&nbd->tag_set); }/*
Signature · 1 line
2.7.4
Quoted 4 lines · Wang Qing
Must release the queue before freeing the tagset.
Fixes 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")Reported-and-tested-by [email protected]
Did syzbot actually test the change?
Quoted 2 lines
Signed-off-by Wang Qing <[email protected]>Signed-off-by Guoqing Jiang <[email protected]>
I don't mind you sent it quickly, but pls remove my outdated mail account.
Guoqing
Quoted 9 lines · Wang Qing
Quoted 4 lines
Must release the queue before freeing the tagset.
Fixes 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")Reported-and-tested-by [email protected]Did syzbot actually test the change?
Yes, I have initiated the test, and did not report this error again, but still reported other known errors, so I think the test passed. And this is an obvious problem, it needs to be fixed anyway.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Wang Qing <[email protected]>Signed-off-by Guoqing Jiang <[email protected]>I don't mind you sent it quickly, but pls remove my outdated mail account.
Sorry about this, you can re-initiate a patch if you don't mind, as if you still have one thing to modify.
Qing
Quoted 2 lines
Guoqing
PATCH v2 1/1 nbd: fix order of cleaning up the queue and freeing the tagset
In reply to Wang QingFrom: Wang Qing <[email protected]>
We must release the queue before freeing the tagset.
---
V2 changes: Correct the fixes tag and mail address.
drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/nbd.c +1 -1
@@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)if (disk) {del_gendisk (disk); -blk_mq_free_tag_set (&nbd->tag_set);blk_cleanup_disk (disk); +blk_mq_free_tag_set (&nbd->tag_set); }/*
Signature · 1 line
2.25.1
Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
Quoted 8 lines · Guoqing Jiang
From: Wang Qing <[email protected]>
We must release the queue before freeing the tagset.
Fixes 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")Reported-and-tested-by [email protected]Signed-off-by Wang Qing <[email protected]>Signed-off-by Guoqing Jiang <[email protected]>
Looks good,
Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
In reply to Guoqing JiangJens, can you pick this up?
Quoted 31 lines · Guoqing Jiang
From: Wang Qing <[email protected]>
We must release the queue before freeing the tagset.
Fixes 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")Reported-and-tested-by [email protected]Signed-off-by Wang Qing <[email protected]>Signed-off-by Guoqing Jiang <[email protected]>---
V2 changes: Correct the fixes tag and mail address.drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/block/nbd.c +1
-1@@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)if (disk) {del_gendisk (disk); -blk_mq_free_tag_set (&nbd->tag_set);blk_cleanup_disk (disk); +blk_mq_free_tag_set (&nbd->tag_set); }/* Signature · 1 line
2.25.1
---end quoted text---
Quoted 1 line · Wang Qing
Must release the queue before freeing the tagset.
Applied, thanks.
Signature · 1 line
Jens Axboe