utils/genrandconfing: randomly enable BR2_REPRODUCIBLE 10% of the times
PATCH v2 1/1 utils/genrandconfing: randomly enable BR2_REPRODUCIBLE 10% of the times
Initial patch to start reproducibility testing.
Also enable tar filesystem to compare images since diffoscope works well with tar.
---
Changes v1 -> v2:
- Remove unnecessary lines that were default anyway (suggested by Arnout)
--- utils/genrandconfig | 6 ++++++ 1 file changed, 6 insertions(+)
utils/genrandconfig +6 -0
@@ -366,6 +366,12 @@ def gen_config(args): if randint(0, 4) == 0: configlines.append("BR2_SYSTEM_ENABLE_NLS=y\n") + # Randomly enable BR2_REPRODUCIBLE 10% of times + # also enable tar filesystem images for testing + if randint(0, 10) == 0: + configlines.append("BR2_REPRODUCIBLE=y\n") + configlines.append("BR2_TARGET_ROOTFS_TAR=y\n") + # Write out the configuration file if not os.path.exists(args.outputdir): os.makedirs(args.outputdir)
Signature · 1 line
2.20.1
PATCH v2 1/1 utils/genrandconfing: randomly enable BR2_REPRODUCIBLE 10% of the times
Quoted 6 lines · Atharva Lele
Initial patch to start reproducibility testing.
Also enable tar filesystem to compare images since diffoscope works well with tar.
Signed-off-by Atharva Lele <[email protected]>
You forgot to add my
(note that patchwork will automatically pick it up, so when someone applies the patch, it will have my Reviewed-by tag now.)
Quoted 6 lines
---
Changes v1 -> v2:
- Remove unnecessary lines that were default anyway (suggested by Arnout)Signed-off-by Atharva Lele <[email protected]>
This second Sob is not needed. But there's no harm in it, it will be stripped
off automatically when applying.
Regards,
Arnout
Quoted 22 lines
--- utils/genrandconfig | 6 ++++++ 1 file changed, 6 insertions(+)utils/genrandconfig +6
-0@@ -366,6 +366,12 @@ def gen_config(args): if randint(0, 4) == 0: configlines.append("BR2_SYSTEM_ENABLE_NLS=y\n") + # Randomly enable BR2_REPRODUCIBLE 10% of times + # also enable tar filesystem images for testing + if randint(0, 10) == 0: + configlines.append("BR2_REPRODUCIBLE=y\n") + configlines.append("BR2_TARGET_ROOTFS_TAR=y\n") + # Write out the configuration file if not os.path.exists(args.outputdir): os.makedirs(args.outputdir)
PATCH v2 1/1 utils/genrandconfing: randomly enable BR2_REPRODUCIBLE 10% of the times
Hmm, something funky happened with my editor and it added the second signed-off
and remove the reviewed by. Anyway, I'll make sure that its alright next time.
Regards,
Atharva Lele
Quoted 45 lines · Arnout Vandecappelle
Quoted 6 lines · Atharva Lele
Initial patch to start reproducibility testing.
Also enable tar filesystem to compare images since diffoscope works well with tar.
Signed-off-by Atharva Lele <[email protected]>You forgot to add my
(note that patchwork will automatically pick it up, so when someone applies the
patch, it will have my Reviewed-by tag now.)Quoted 4 lines
---
Changes v1 -> v2:
- Remove unnecessary lines that were default anyway (suggested byArnout)
Quoted 2 lines
Signed-off-by Atharva Lele <[email protected]>This second Sob is not needed. But there's no harm in it, it will be
stripped
off automatically when applying.Regards,
ArnoutQuoted 12 lines
--- utils/genrandconfig | 6 ++++++ 1 file changed, 6 insertions(+)utils/genrandconfig +0
-0@@ -366,6 +366,12 @@ def gen_config(args): if randint(0, 4) == 0: configlines.append("BR2_SYSTEM_ENABLE_NLS=y\n")
Quoted 11 lines
utils/genrandconfig def gen_config(args): · line 377
Quoted 10 lines
utils/genrandconfig +6
-0+ # Randomly enable BR2_REPRODUCIBLE 10% of times + # also enable tar filesystem images for testing + if randint(0, 10) == 0: + configlines.append("BR2_REPRODUCIBLE=y\n") + configlines.append("BR2_TARGET_ROOTFS_TAR=y\n") + # Write out the configuration file if not os.path.exists(args.outputdir): os.makedirs(args.outputdir)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190607/003303c5/attachment.html>