Skip to contentSkip to conversation

net: mark tulip obsolete

PATCH NAK Jakub Kicinski 2 participants 7 messages Mar 15, 2022 – Apr 26, 2022

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 net: mark tulip obsolete

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 1397a6b039fb..9afe495a86ca 100644
@@ -19687,7 +19687,7 @@ F:	drivers/media/tuners/tua9001*
 TULIP NETWORK DRIVERS
 L:	[email protected]
 L:	[email protected]
-S:	Orphan
+S:	Orphan / Obsolete
 F:	drivers/net/ethernet/dec/tulip/
 
 TUN/TAP driver
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Jakub Kicinski

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

NAK.

This driver is needed by nearly all PA-RISC machines.

Helge

Quoted 16 lines
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 1397a6b039fb..9afe495a86ca 100644
@@ -19687,7 +19687,7 @@ F:	drivers/media/tuners/tua9001*
 TULIP NETWORK DRIVERS
 L:	[email protected]
 L:	[email protected]
-S:	Orphan
+S:	Orphan / Obsolete
 F:	drivers/net/ethernet/dec/tulip/
author maintainer
#2 lore raw
Quoted 7 lines · On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
Quoted 2 lines · Jakub Kicinski

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

NAK.

This driver is needed by nearly all PA-RISC machines.

I was just trying to steer newcomers to code that's more relevant today.

#3 lore raw
Quoted 10 lines · Jakub Kicinski
Quoted 7 lines · On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
Quoted 2 lines · Jakub Kicinski

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

NAK.

This driver is needed by nearly all PA-RISC machines.

I was just trying to steer newcomers to code that's more relevant today.

That intention is ok, but "obsolete" means it's not used any more, and that's not true.

Helge

author maintainer
#4 lore raw
Quoted 6 lines · On Tue, 15 Mar 2022 23:18:38 +0100 Helge Deller wrote:
Quoted 5 lines · Jakub Kicinski
Quoted 4 lines · On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
Quoted 2 lines · Jakub Kicinski

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

NAK.

This driver is needed by nearly all PA-RISC machines.

I was just trying to steer newcomers to code that's more relevant today.

That intention is ok, but "obsolete" means it's not used any more, and that's not true.

Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly? I'd like to try to remove DE4X5, if that's not the one you need (getting rid of virt_to_bus()-using drivers).

#5 lore raw

Hi Jakub,

Quoted 9 lines · Jakub Kicinski
Quoted 8 lines · On Tue, 15 Mar 2022 23:18:38 +0100 Helge Deller wrote:
Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
Quoted 2 lines · Jakub Kicinski

It's ancient, an likely completely unused at this point. Let's mark it obsolete to prevent refactoring.

NAK.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

This driver is needed by nearly all PA-RISC machines.

I was just trying to steer newcomers to code that's more relevant today.

That intention is ok, but "obsolete" means it's not used any more, and that's not true.

Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly?

For parisc I have:

CONFIG_NET_TULIP=y
# CONFIG_DE2104X is not set
CONFIG_TULIP=y
# CONFIG_TULIP_MWI is not set
# CONFIG_TULIP_MMIO is not set
# CONFIG_TULIP_NAPI is not set
# CONFIG_DE4X5 is not set
# CONFIG_WINBOND_840 is not set
# CONFIG_DM9102 is not set
# CONFIG_ULI526X is not set
# CONFIG_PCMCIA_XIRCOM is not set
# CONFIG_NET_VENDOR_DLINK is not set
# CONFIG_NET_VENDOR_EMULEX is not set

So not the DE4X5.

Quoted 2 lines

I'd like to try to remove DE4X5, if that's not the one you need (getting rid of virt_to_bus()-using drivers).

I've CC'ed the linux-alpha mailing list, as the DE4X5 driver might be needed there, so removing it completely might not be the best idea.

But since you want to remove virt_to_bus()....
It seems this virt_to_bus() call is used for really old x86 machines/cards, which probably aren't supported any longer.

See drivers/net/ethernet/dec/tulip/de4x5.c:
...
#if !defined(__alpha__) && !defined(__powerpc__) && !defined(CONFIG_SPARC) && !defined(DE4X5_DO_MEMCPY)
...

    tmp = virt_to_bus(p->data);

...

Maybe you could simply remove the part inside #if...#else and insert a pr_err() instead (and return NULL)?

Helge

author maintainer
#6 lore raw
Quoted 37 lines · On Tue, 26 Apr 2022 22:53:00 +0200 Helge Deller wrote:
Quoted 4 lines
Quoted 2 lines

That intention is ok, but "obsolete" means it's not used any more, and that's not true.

Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly?

For parisc I have:

CONFIG_NET_TULIP=y
# CONFIG_DE2104X is not set
CONFIG_TULIP=y
# CONFIG_TULIP_MWI is not set
# CONFIG_TULIP_MMIO is not set
# CONFIG_TULIP_NAPI is not set
# CONFIG_DE4X5 is not set
# CONFIG_WINBOND_840 is not set
# CONFIG_DM9102 is not set
# CONFIG_ULI526X is not set
# CONFIG_PCMCIA_XIRCOM is not set
# CONFIG_NET_VENDOR_DLINK is not set
# CONFIG_NET_VENDOR_EMULEX is not set

So not the DE4X5.

Quoted 2 lines

I'd like to try to remove DE4X5, if that's not the one you need (getting rid of virt_to_bus()-using drivers).

I've CC'ed the linux-alpha mailing list, as the DE4X5 driver might be needed there, so removing it completely might not be the best idea.

But since you want to remove virt_to_bus()....
It seems this virt_to_bus() call is used for really old x86 machines/cards, which probably aren't supported any longer.

See drivers/net/ethernet/dec/tulip/de4x5.c:
...
#if !defined(__alpha__) && !defined(__powerpc__) && !defined(CONFIG_SPARC) && !defined(DE4X5_DO_MEMCPY)
...

Quoted 5 lines
    tmp = virt_to_bus(p->data);

...

Maybe you could simply remove the part inside #if...#else and insert a pr_err() instead (and return NULL)?

Ah, good find, thanks for taking a look! I'll look into dropping just sections of the code.