Skip to contentSkip to conversation

md/persistent-data: exit_ro_spine func return void

PATCH In review Zhiqiang Liu 1 participant 2 messages Apr 15, 2020 – Apr 21, 2020 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 md/persistent-data: exit_ro_spine func return void

From: Zhiqiang Liu <[email protected]>

In commit 4c7da06f5a78 ("dm persistent data: eliminate unnecessary return values"), r value in exit_ro_spine will not changes, so exit_ro_spine donot need to return values.

---
 drivers/md/persistent-data/dm-btree-internal.h | 2 +-
 drivers/md/persistent-data/dm-btree-spine.c    | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)
drivers/md/persistent-data/dm-btree-internal.h +1 -1
index a240990a7f33..55a4096f1334 100644
@@ -68,7 +68,7 @@ struct ro_spine {
 };
 
 void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info);
-int exit_ro_spine(struct ro_spine *s);
+void exit_ro_spine(struct ro_spine *s);
 int ro_step(struct ro_spine *s, dm_block_t new_child);
 void ro_pop(struct ro_spine *s);
 struct btree_node *ro_node(struct ro_spine *s);
drivers/md/persistent-data/dm-btree-spine.c +2 -4
index b27b8091a1ca..e03cb9e48773 100644
@@ -132,15 +132,13 @@ void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info)
 	s->nodes[1] = NULL;
 }
 
-int exit_ro_spine(struct ro_spine *s)
+void exit_ro_spine(struct ro_spine *s)
 {
-	int r = 0, i;
+	int i;
 
 	for (i = 0; i < s->count; i++) {
 		unlock_block(s->info, s->nodes[i]);
 	}
-
-	return r;
 }
 
 int ro_step(struct ro_spine *s, dm_block_t new_child)
Signature · 1 line
2.19.1
#1 lore raw

Friendly ping..

Quoted 48 lines · Zhiqiang Liu

From: Zhiqiang Liu <[email protected]>

In commit 4c7da06f5a78 ("dm persistent data: eliminate unnecessary return values"), r value in exit_ro_spine will not changes, so exit_ro_spine donot need to return values.

---
 drivers/md/persistent-data/dm-btree-internal.h | 2 +-
 drivers/md/persistent-data/dm-btree-spine.c    | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)
drivers/md/persistent-data/dm-btree-internal.h +1 -1
index a240990a7f33..55a4096f1334 100644
@@ -68,7 +68,7 @@ struct ro_spine {
 };
 
 void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info);
-int exit_ro_spine(struct ro_spine *s);
+void exit_ro_spine(struct ro_spine *s);
 int ro_step(struct ro_spine *s, dm_block_t new_child);
 void ro_pop(struct ro_spine *s);
 struct btree_node *ro_node(struct ro_spine *s);
drivers/md/persistent-data/dm-btree-spine.c +2 -4
index b27b8091a1ca..e03cb9e48773 100644
@@ -132,15 +132,13 @@ void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info)
 	s->nodes[1] = NULL;
 }
 
-int exit_ro_spine(struct ro_spine *s)
+void exit_ro_spine(struct ro_spine *s)
 {
-	int r = 0, i;
+	int i;
 
 	for (i = 0; i < s->count; i++) {
 		unlock_block(s->info, s->nodes[i]);
 	}
-
-	return r;
 }
 
 int ro_step(struct ro_spine *s, dm_block_t new_child)