Skip to contentSkip to conversation

usb: chipidea: host: fix disconnection detect issue

PATCH New Mats Karrman 1 participant 1 message Jun 6, 2018 USB

lore
Share & tools
lore

Mats Karrman

author
#0 lore raw

PATCH 1/1 usb: chipidea: host: fix disconnection detect issue

Quoted 11 lines · Peter Chen

The commit 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd") delete the assignment for hcd->usb_phy, it causes usb_phy_notify_connect{disconnect) are not called, the USB PHY driver is not notified of hot plug event, then the disconnection will not be detected by hardware.

Fixes 4e88d4c08301 ("usb: add a flag to skip PHY initialization

to struct usb_hcd")

Cc Martin Blumenstingl <[email protected]>
Reported-by Mats Karrman <[email protected]>
Signed-off-by Peter Chen <[email protected]>

Works for me!
Tested on SolidRun Hummingboard fsl,imx6dl

Tested-by Mats Karrman <[email protected]>

Thanks,
Mats

Quoted 11 lines
---
  drivers/usb/chipidea/host.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
drivers/usb/chipidea/host.c +0 -0
index af45aa3222b5..4638d9b066be 100644
@@ -124,8 +124,11 @@ static int host_start(struct ci_hdrc *ci)
 
  	hcd->power_budget = ci->platdata->power_budget;

drivers/usb/chipidea/host.c static int host_start(struct ci_hdrc *ci) · line 134

Quoted 10 lines
drivers/usb/chipidea/host.c +4 -1
  	hcd->tpl_support = ci->platdata->tpl_support;
-	if (ci->phy || ci->usb_phy)
+	if (ci->phy || ci->usb_phy) {
  		hcd->skip_phy_initialization = 1;
+		if (ci->usb_phy)
+			hcd->usb_phy = ci->usb_phy;
+	}
 
  	ehci = hcd_to_ehci(hcd);
  	ehci->caps = ci->hw_bank.cap;

---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html