Skip tmp-dir check unless actualy used
PATCH 1/1 Skip tmp-dir check unless actualy used
As per the manual, it is subject to chroot and used only by client-connect and plugin.
Without additional code being run and chroot /var/empty/ (amongst user, persist-*, etc.) set to reduce run-time privileges as much as possible, the default temporary is still required upon start:
Options error: Temporary directory (--tmp-dir) fails with '/var/empty///tmp': No such file or directory (errno=2)
tmp-dir / works around this, but should not be needed.
In this setup, client and server have no create/write filesystem access at all after privilege drop; with this fix, ktrace(1) (on OpenBSD) shows no namei(9) lookup being made at runtime (after chroot):
# ktrace -d -i -tn ./openvpn --config ./conf --tmp-dir /nonexistent/ ...^C # kdump | grep -q -e/tmp -e/nonexistent ; echo $? --- src/openvpn/options.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
src/openvpn/options.c +11 -2
@@ -4149,8 +4149,17 @@ options_postprocess_filechecks(struct options *options)/* ** Config related ** */ errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->client_config_dir,R_OK |X_OK ,"--client-config-dir" ); - errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, -R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + +msg (M_WARN |M_NOPREFIX ,"tmp_dir = '%s'" , options->tmp_dir); +if (options->client_connect_script +#ifdef ENABLE_PLUGIN + || options->plugin_list +#endif /* ENABLE_PLUGIN */ + ) + { + errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, +R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + }if (errs) {
Signature · 1 line
2.49.0
PATCH 1/1 Skip tmp-dir check unless actually used
As per the manual, it is subject to chroot and used only by client-connect and plugin.
Without additional code being run and chroot /var/empty/ (amongst user, persist-*, etc.) set to reduce run-time privileges as much as possible, the default temporary is still required upon start:
Options error: Temporary directory (--tmp-dir) fails with '/var/empty///tmp': No such file or directory (errno=2)
tmp-dir / works around this, but should not be needed.
In this setup, client and server effectively have no create/write filesystem access after privilege drop; with this fix, ktrace(1) (on OpenBSD) shows no namei(9) lookup at runtime (after chroot):
# ktrace -d -i -tn ./openvpn --config ./conf --tmp-dir /nonexistent/ ...^C # kdump | grep -q -e/tmp -e/nonexistent ; echo $? 1 --- src/openvpn/options.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
src/openvpn/options.c +11 -2
@@ -4149,8 +4149,17 @@ options_postprocess_filechecks(struct options *options)/* ** Config related ** */ errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->client_config_dir,R_OK |X_OK ,"--client-config-dir" ); - errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, -R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + +msg (M_WARN |M_NOPREFIX ,"tmp_dir = '%s'" , options->tmp_dir); +if (options->client_connect_script +#ifdef ENABLE_PLUGIN + || options->plugin_list +#endif /* ENABLE_PLUGIN */ + ) + { + errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, +R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + }if (errs) {
Signature · 1 line
2.49.0
Am 28.04.2025 um 23:46 schrieb Klemens Nanni:
Quoted 34 lines
As per the manual, it is subject to
chrootand used only byclient-connectandplugin.Without additional code being run and
chroot /var/empty/(amongstuser,persist-*, etc.) set to reduce run-time privileges as much as possible, the default temporary is still required upon start:Options error: Temporary directory (--tmp-dir) fails with '
/var/empty///tmp': No such file or directory (errno=2)
tmp-dir /works around this, but should not be needed.In this setup, client and server have no create/write filesystem access at all after privilege drop; with this fix, ktrace(1) (on OpenBSD) shows no namei(9) lookup being made at runtime (after
chroot):# ktrace -d -i -tn ./openvpn --config ./conf --tmp-dir /nonexistent/ ...^C # kdump | grep -q -e/tmp -e/nonexistent ; echo $? --- src/openvpn/options.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)src/openvpn/options.c +2
-2@@ -4149,8 +4149,17 @@ options_postprocess_filechecks(struct options *options)/* ** Config related ** */ errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->client_config_dir,R_OK |X_OK ,"--client-config-dir" ); - errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, -R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + +msg (M_WARN |M_NOPREFIX ,"tmp_dir = '%s'" , options->tmp_dir);
src/openvpn/options.c options_postprocess_filechecks(struct options *options) · line 4163
Quoted 10 lines
src/openvpn/options.c +9
-0+if (options->client_connect_script +#ifdef ENABLE_PLUGIN + || options->plugin_list +#endif /* ENABLE_PLUGIN */ + ) + { + errs |=check_file_access_chroot (options->chroot_dir,CHKACC_FILE , options->tmp_dir, +R_OK |W_OK |X_OK ,"Temporary directory (--tmp-dir)" ); + }
There are more instances where the tmp dir is used. Just to name one of the top of my head is tls-crypt-v2-verify. I wonder if the benefit herre is big enough. As you said, even in your ro scenario it can be workarounded with specifying an existing directory.
Arne
29 апреля 2025 г. 08:24:12 UTC, Arne Schwabe <[email protected]...> пишет:
Quoted 1 line
There are more instances where the tmp dir is used. Just to name one of the top of my head is tls-crypt-v2-verify. I wonder if the benefit herre is big enough. As you said, even in your ro scenario it can be workarounded with specifying an existing directory.
Right, so docs need more fixing.
It is a marginal benefit indeed, but nevertheless strikes me as "correct".
I'll go over the code come back with a manual patch. Afterwards there be a second iteration of this one.
Thanks.