Skip to contentSkip to conversation

x86/HVM: drop dead code from HVM_PARAM_IDENT_PT setting

PATCH In review Jan Beulich 2 participants 2 messages Apr 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/HVM: drop dead code from HVM_PARAM_IDENT_PT setting

The setting of d->arch.hvm.params[] will uniformly happen at the bottom of hvm_set_param(), hence as per Misra's classification redundantly doing so earlier is "dead code".

xen/arch/x86/hvm/hvm.c +0 -3
@@ -4242,10 +4242,7 @@ static int hvm_set_param(struct domain *
          * capabilities.  Short circuit the pause if possible.
          */
         if ( paging_mode_shadow(d) || !using_vmx() )
-        {
-            d->arch.hvm.params[index] = value;
             break;
-        }
 
         /*
          * Update GUEST_CR3 in each VMCS to point at identity map.