nvme/018: Ignore message generated by nvme read
PATCH 1/1 nvme/018: Ignore message generated by nvme read
nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just stderr. This lets the test fail as well.
--- tests/nvme/018 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/nvme/018 +1 -1
@@ -43,7 +43,7 @@ test() { sectors="$(blockdev --getsz "/dev/${nvmedev}n1")" bs="$(blockdev --getbsz "/dev/${nvmedev}n1")" - nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \ + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \ && echo "ERROR: Successfully read out of device lba range" nvme disconnect -n "${subsys_name}"
Signature · 1 line
2.16.4
Quoted 14 lines · Daniel Wagner
nvme-cli writes '
CAP_EXCEEDED' message also on stdout not just stderr. This lets the test fail as well.Fixes 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")Signed-off-by Daniel Wagner <[email protected]>--- tests/nvme/018 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/nvme/018 +0
-0
tests/nvme/018 test() { · line 47
Quoted 6 lines
tests/nvme/018 +1
-1@@ -43,7 +43,7 @@ test() { sectors="$(blockdev --getsz "/dev/${nvmedev}n1")" bs="$(blockdev --getbsz "/dev/${nvmedev}n1")" - nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \ + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \ && echo "ERROR: Successfully read out of device lba range"
That's an odd message for an error... Error! I succeeded!
Quoted 2 lines
tests/nvme/018 +0
-0nvme disconnect -n "${subsys_name}"
Quoted 5 lines · Logan Gunthorpe
tests/nvme/018 test() { · line 47
Quoted 3 lines
tests/nvme/018 +1
-1- nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \ + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \ && echo "ERROR: Successfully read out of device lba range"That's an odd message for an error... Error! I succeeded!
I think the idea is that the command should *not* succeed. So 'nvme read' is expected to fail.
It is a bit confusing. What about something like
"ERROR: lba range read was unexpected successfull"?
Quoted 1 line · Daniel Wagner
"ERROR: lba range read was unexpected successfull"?
nit :- s/successfull/successful/
How about ?
"ERROR: nvme read was successful for out of range lba" ?