Skip to contentSkip to conversation

drm: drm_of.c: Using EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL

PATCH In review Sui Jingfeng 2 participants 3 messages Apr 29, 2024 – Apr 30, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: drm_of.c: Using EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL

Linux kernel puts strict limits on which functions and data structures are available to loadable kernel modules; only those that have been explicitly exported with EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL() are accessible. In the case of EXPORT_SYMBOL_GPL(), only modules that declare a GPL-compatible license will be able to see the symbol.

Since the whole drm_of.c file is declared with GPL-2.0-only license, so let us keep functions in that source file consistently.

---
 drivers/gpu/drm/drm_of.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_of.c +3 -3
index 177b600895d3..1ca36d654e61 100644
@@ -44,7 +44,7 @@ uint32_t drm_of_crtc_port_mask(struct drm_device *dev,
 
 	return 0;
 }
-EXPORT_SYMBOL(drm_of_crtc_port_mask);
+EXPORT_SYMBOL_GPL(drm_of_crtc_port_mask);
 
 /**
  * drm_of_find_possible_crtcs - find the possible CRTCs for an encoder port
@@ -77,7 +77,7 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
 
 	return possible_crtcs;
 }
-EXPORT_SYMBOL(drm_of_find_possible_crtcs);
+EXPORT_SYMBOL_GPL(drm_of_find_possible_crtcs);
 
 /**
  * drm_of_component_match_add - Add a component helper OF node match rule
@@ -181,7 +181,7 @@ int drm_of_component_probe(struct device *dev,
 
 	return component_master_add_with_match(dev, m_ops, match);
 }
-EXPORT_SYMBOL(drm_of_component_probe);
+EXPORT_SYMBOL_GPL(drm_of_component_probe);
 
 /*
  * drm_of_encoder_active_endpoint - return the active encoder endpoint
Signature · 1 line
2.34.1
maintainer
#1 lore raw

Hi,

Quoted 8 lines · Sui Jingfeng

Linux kernel puts strict limits on which functions and data structures are available to loadable kernel modules; only those that have been explicitly exported with EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL() are accessible. In the case of EXPORT_SYMBOL_GPL(), only modules that declare a GPL-compatible license will be able to see the symbol.

Since the whole drm_of.c file is declared with GPL-2.0-only license, so let us keep functions in that source file consistently.

You're conflating two things: the license of the code itself (GPL2 here), and the license of the users of the symbols exported in that file (anything).

There's no relationship between the two, and you have to make an argument for changing the latter other than just because the license is GPL because, again, those are two different things.

Maxime

#2 lore raw

Hi,

Quoted 11 lines · Maxime Ripard

Hi,

Quoted 8 lines · Sui Jingfeng

Linux kernel puts strict limits on which functions and data structures are available to loadable kernel modules; only those that have been explicitly exported with EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL() are accessible. In the case of EXPORT_SYMBOL_GPL(), only modules that declare a GPL-compatible license will be able to see the symbol.

Since the whole drm_of.c file is declared with GPL-2.0-only license, so let us keep functions in that source file consistently.

Quoted 7 lines

You're conflating two things: the license of the code itself (GPL2 here), and the license of the users of the symbols exported in that file (anything).

There's no relationship between the two, and you have to make an argument for changing the latter other than just because the license is GPL because, again, those are two different things.

Yeah, I think you might be correct.

It seems that it is valid to have EXPORT_SYMBOL() in GPL-2.0-only licensed file.

Quoted 1 line

Maxime

Signature · 2 lines
Best regards,
Sui