Skip to contentSkip to conversation

driver-core : make sysdev_class_register check kobject_set_name return value

PATCH In review Dave Young 1 participant 1 message May 11, 2009 Driver core

lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 3/3 driver-core : make sysdev_class_register check kobject_set_name return value

sysdev_class_register should check the kobject_set_name return value.

Add the return value checking code.

---
drivers/base/sys.c | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
drivers/base/sys.c +7 -1
diff -uprN linux.old/drivers/base/sys.c linux.new/drivers/base/sys.c
@@ -131,6 +131,8 @@ static struct kset *system_kset;
 
 int sysdev_class_register(struct sysdev_class *cls)
 {
+	int retval;
+
 	pr_debug("Registering sysdev class '%s'\n", cls->name);
 
 	INIT_LIST_HEAD(&cls->drivers);
@@ -138,7 +140,11 @@ int sysdev_class_register(struct sysdev_
 	cls->kset.kobj.parent = &system_kset->kobj;
 	cls->kset.kobj.ktype = &ktype_sysdev_class;
 	cls->kset.kobj.kset = system_kset;
-	kobject_set_name(&cls->kset.kobj, cls->name);
+
+	retval = kobject_set_name(&cls->kset.kobj, cls->name);
+	if (retval)
+		return retval;
+
 	return kset_register(&cls->kset);
 }