dt-bindings: rockchip: Add support for rk809 audio codec
Subsystems (3)
v2 cover dt-bindings: rockchip: Add support for rk809 audio codec
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same rk817_codec driver. However it is missing from the bindings.
This series documents the audio codec properties in rockchip,rk809.yaml bindings and updates example.
Changes in v2:
- Fix vcc-supply warning detected by dt_binding bot
- Fix missing include and pinctrl for codec example
Tim Lunn (3):
dt-bindings: rockchip: Document rk809 support for rk817 audio codec
dt-bindings: rockchip: rk809 fix existing example
dt-bindings: rockchip: Update rk809 example with audio codec
properties
.../bindings/mfd/rockchip,rk809.yaml | 46 ++++++++++++++++--- 1 file changed, 39 insertions(+), 7 deletions(-)
Signature · 1 line
2.40.1
PATCH v2 1/3 dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same rk817_codec driver. However it is missing from the bindings.
Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:
'pinctrl-[0-9]+'
---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +29 -1
@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:
@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false + clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclk + + '#sound-dai-cells': + description: + Needed for the interpretation of sound dais. + const: 0 + + codec: + description: | + The child node for the codec to hold additional properties. If no + additional properties are required for the codec, this node can be + omitted. + type: object + additionalProperties: false + properties: + rockchip,mic-in-differential: + type: boolean + description: + Describes if the microphone uses differential mode. + allOf: - if: properties:
Signature · 1 line
2.40.1
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Quoted 35 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:'pinctrl-[0-9]+'Signed-off-by Tim Lunn <[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 10 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +9
-0+ clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclk
You have one clock only, why do you need to have clock-names?
Otherwise,
Cheers,
Conor.
Quoted 25 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +19
-0+ + '#sound-dai-cells': + description: + Needed for the interpretation of sound dais. + const: 0 + + codec: + description: | + The child node for the codec to hold additional properties. If no + additional properties are required for the codec, this node can be + omitted. + type: object + additionalProperties: false + properties: + rockchip,mic-in-differential: + type: boolean + description: + Describes if the microphone uses differential mode. + allOf: - if: properties:Signature · 1 line
2.40.1
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Quoted 37 lines · Conor Dooley
Quoted 36 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:
'pinctrl-[0-9]+'Signed-off-by Tim Lunn<[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false
Quoted 10 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 9 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +9
-0+ clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclkYou have one clock only, why do you need to have clock-names?
This is just documenting the existing rk817 codec driver, which is using the name to get the clock:
devm_clk_get(pdev->dev.parent, "mclk");
Thus i dont think clock-names can be removed in this case? atleast not without patching the driver as well?
Quoted 31 lines
Otherwise,
Acked-by Conor Dooley<[email protected]>Cheers,
Conor.Quoted 25 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +19
-0+ + '#sound-dai-cells': + description: + Needed for the interpretation of sound dais. + const: 0 + + codec: + description: | + The child node for the codec to hold additional properties. If no + additional properties are required for the codec, this node can be + omitted. + type: object + additionalProperties: false + properties: + rockchip,mic-in-differential: + type: boolean + description: + Describes if the microphone uses differential mode. + allOf: - if: properties:Signature · 1 line
2.40.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Quoted 49 lines · Tim Lunn
Quoted 37 lines · Conor Dooley
Quoted 36 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:
'pinctrl-[0-9]+'Signed-off-by Tim Lunn<[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: falseQuoted 10 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 9 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +9
-0+ clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclkYou have one clock only, why do you need to have clock-names?
Quoted 8 lines
This is just documenting the existing rk817 codec driver, which is using the name to get the clock:
devm_clk_get(pdev->dev.parent, "mclk");Thus i dont think clock-names can be removed in this case? atleast not without patching the driver as well?
Quoted 1 line
Your commit msg claims this is for existing driver using rk817_codec. So what about rk817? It does not use clocks?
Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Quoted 52 lines · Krzysztof Kozlowski
Quoted 51 lines · Tim Lunn
Quoted 37 lines · Conor Dooley
Quoted 36 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:
'pinctrl-[0-9]+'Signed-off-by Tim Lunn<[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: falseQuoted 10 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 9 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +9
-0+ clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclkYou have one clock only, why do you need to have clock-names?
This is just documenting the existing rk817 codec driver, which is using the name to get the clock:
Quoted 7 lines
Quoted 4 lines
devm_clk_get(pdev->dev.parent, "mclk");Thus i dont think clock-names can be removed in this case? atleast not without patching the driver as well?
Your commit msg claims this is for existing driver using
rk817_codec. So what about rk817? It does not use clocks?
rk817 uses exactly the same properties as what I included here. i.e it includes both clocks and clock-names. My point above was that I dont think I can just remove the clock-names property as Conor suggested? I could be wrong though.
Quoted 4 lines
Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Quoted 55 lines · Tim Lunn
Quoted 53 lines · Krzysztof Kozlowski
Quoted 52 lines · Tim Lunn
Quoted 36 lines · Conor Dooley
Quoted 35 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:
'pinctrl-[0-9]+'Signed-off-by Tim Lunn<[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +3
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false + clocks: + description:Quoted 8 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 7 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +7
-0+ The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclkYou have one clock only, why do you need to have clock-names?
This is just documenting the existing rk817 codec driver, which is using the name to get the clock:
devm_clk_get(pdev->dev.parent, "mclk");Thus i dont think clock-names can be removed in this case? atleast not without patching the driver as well?
Quoted 7 lines
Quoted 3 lines
Your commit msg claims this is for existing driver using
rk817_codec. So what about rk817? It does not use clocks?rk817 uses exactly the same properties as what I included here. i.e it includes both clocks and clock-names.
My point above was that I dont think I can just remove the clock-names property as Conor suggested? I could be wrong though.
You can't remove it from the rk817 binding, but that doesn't mean you should add it here. If the rk817 only has one clock too, then the driver could be modified to not rely on the clock names at all. I'd be inclined to allow it here since that makes the binding compatible with the existing driver for the other device.
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
In reply to Conor DooleyQuoted 49 lines · Conor Dooley
Quoted 35 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:'pinctrl-[0-9]+'Signed-off-by Tim Lunn <[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: falseDocumentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 104
Quoted 10 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +9
-0+ clocks: + description: + The input clock for the audio codec. + + clock-names: + description: + The clock name for the codec clock. + items: + - const: mclkYou have one clock only, why do you need to have clock-names?
Quoted 5 lines
Otherwise,
Acked-by Conor Dooley <[email protected]>Cheers,
Conor.
The codec driver currently looks for a clock named "mclk".
Thank you,
Chris.
Quoted 33 lines
Quoted 26 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +19
-0+ + '#sound-dai-cells': + description: + Needed for the interpretation of sound dais. + const: 0 + + codec: + description: | + The child node for the codec to hold additional properties. If no + additional properties are required for the codec, this node can be + omitted. + type: object + additionalProperties: false + properties: + rockchip,mic-in-differential: + type: boolean + description: + Describes if the microphone uses differential mode. + allOf: - if: properties:Signature · 1 line
2.40.1_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
In reply to Tim LunnQuoted 33 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.Update dt-binding documentation for rk809 to include the audio codec properties. This fixes the following warning from dtb check:
pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
'clock-names', 'clocks', 'codec' do not match any of the regexes:'pinctrl-[0-9]+'Signed-off-by Tim Lunn <[email protected]>---
(no changes since v1)
.../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-1@@ -12,7 +12,7 @@ maintainers: description: | Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD - that includes regulators, an RTC, and power button. + that includes regulators, an RTC, a power button, and an audio codec. properties: compatible:
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml properties: · line 98
Quoted 6 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +3
-0@@ -93,6 +93,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false + clocks: + description: + The input clock for the audio codec.
Nothing improved here. Implement the feedback.
Don't send the patchsets more than once per day, so reviewers can actually review it.
Best regards,
Krzysztof
PATCH v2 2/3 dt-bindings: rockchip: rk809 fix existing example
In reply to Tim LunnFix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809.
---
Changes in v2:
- Fix vcc-supply warning detected by dt_binding bot
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +2 -5
@@ -154,8 +154,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - rk808: pmic@1b { - compatible = "rockchip,rk808"; + rk809: pmic@1b { + compatible = "rockchip,rk809"; reg = <0x1b>; #clock-cells = <1>; clock-output-names = "xin32k", "rk808-clkout2";
@@ -174,9 +174,6 @@ examples: vcc7-supply = <&vcc_sysin>; vcc8-supply = <&vcc3v3_sys>; vcc9-supply = <&vcc_sysin>; - vcc10-supply = <&vcc_sysin>; - vcc11-supply = <&vcc_sysin>; - vcc12-supply = <&vcc3v3_sys>; regulators { vdd_center: DCDC_REG1 {
Signature · 1 line
2.40.1
Re: [PATCH v2 2/3] dt-bindings: rockchip: rk809 fix existing example
Quoted 4 lines · Tim Lunn
Fix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809.
Signed-off-by Tim Lunn <[email protected]>
A fixes tag would be nice too I suppose. Not worth resending for IMO since b4 will pick it up if you reply with one.
Thanks,
Conor.
Re: [PATCH v2 2/3] dt-bindings: rockchip: rk809 fix existing example
Quoted 5 lines · Conor Dooley
Quoted 4 lines · Tim Lunn
Fix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809.
Signed-off-by Tim Lunn <[email protected]>
Quoted 7 lines
Acked-by Conor Dooley <[email protected]>A fixes tag would be nice too I suppose. Not worth resending for IMO since b4 will pick it up if you reply with one.
Thanks,
Conor.
Re: [PATCH v2 2/3] dt-bindings: rockchip: rk809 fix existing example
In reply to Tim LunnQuoted 18 lines · Tim Lunn
Fix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809.
Signed-off-by Tim Lunn <[email protected]>---
Changes in v2:
- Fix vcc-supply warning detected bydt_bindingbotDocumentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +0
-0
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml examples: · line 157
Quoted 6 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-2@@ -154,8 +154,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - rk808: pmic@1b { - compatible = "rockchip,rk808"; + rk809: pmic@1b {
Drop label.
Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: rockchip: rk809 fix existing example
Hi Krzysztof,
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Tim Lunn
Fix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809.
Signed-off-by Tim Lunn <[email protected]>---
Changes in v2:
- Fix vcc-supply warning detected bydt_bindingbotDocumentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +0
-0@@ -154,8 +154,8 @@ examples: #address-cells = <1>; #size-cells = <0>;
Quoted 5 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml examples: · line 157
Quoted 3 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +1
-2- rk808: pmic@1b { - compatible = "rockchip,rk808"; + rk809: pmic@1b {Drop label.
Yep, will fix.
Quoted 3 lines
Best regards,
Krzysztof
PATCH v2 3/3 dt-bindings: rockchip: Update rk809 example with audio codec properties
In reply to Tim LunnUpdate the example provided to include the properties for using rk817 audio codec.
---
Changes in v2:
- Fix missing include and pinctrl for codec example
.../devicetree/bindings/mfd/rockchip,rk809.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +8 -1
@@ -147,6 +147,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/px30-cru.h> #include <dt-bindings/pinctrl/rockchip.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/gpio/gpio.h>
@@ -161,10 +162,13 @@ examples: clock-output-names = "xin32k", "rk808-clkout2"; interrupt-parent = <&gpio3>; interrupts = <10 IRQ_TYPE_LEVEL_LOW>; + clock-names = "mclk"; + clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default"; - pinctrl-0 = <&pmic_int_l_pin>; + pinctrl-0 = <&pmic_int_l_pin>, <&i2s1_2ch_mclk>; rockchip,system-power-controller; wakeup-source; + #sound-dai-cells = <0>; vcc1-supply = <&vcc_sysin>; vcc2-supply = <&vcc_sysin>;
@@ -309,5 +313,8 @@ examples: }; }; }; + rk817_codec: codec { + rockchip,mic-in-differential; + }; }; };
Signature · 1 line
2.40.1
Re: [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with audio codec properties
Quoted 41 lines · Tim Lunn
Update the example provided to include the properties for using rk817 audio codec.
Signed-off-by Tim Lunn <[email protected]>---
Changes in v2:
- Fix missing include and pinctrl for codec example.../devicetree/bindings/mfd/rockchip,rk809.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +5
-1@@ -147,6 +147,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/px30-cru.h> #include <dt-bindings/pinctrl/rockchip.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/gpio/gpio.h>@@ -161,10 +162,13 @@ examples: clock-output-names = "xin32k", "rk808-clkout2"; interrupt-parent = <&gpio3>; interrupts = <10 IRQ_TYPE_LEVEL_LOW>; + clock-names = "mclk"; + clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default"; - pinctrl-0 = <&pmic_int_l_pin>; + pinctrl-0 = <&pmic_int_l_pin>, <&i2s1_2ch_mclk>; rockchip,system-power-controller; wakeup-source; + #sound-dai-cells = <0>; vcc1-supply = <&vcc_sysin>; vcc2-supply = <&vcc_sysin>;
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml examples: · line 315
Quoted 3 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +0
-0@@ -309,5 +313,8 @@ examples: }; }; };
Blank line here please.
I'd squash this with the patch adding the codec as an allowed property though.
Thanks,
Conor.
Quoted 8 lines
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +3
-0+ rk817_codec: codec { + rockchip,mic-in-differential; + }; }; };Signature · 1 line
2.40.1
Rob Herring
maintainerQuoted 10 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.This series documents the audio codec properties in rockchip,rk809.yaml bindings and updates example.
Changes in v2:
- Fix vcc-supply warning detected bydt_bindingbot
- Fix missing include and pinctrl for codec example
I just reviewed v1. Please apply those comments. And wait a bit between sending new versions.
Rob
Quoted 5 lines · Rob Herring
Quoted 4 lines · Tim Lunn
Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also using the same
rk817_codecdriver. However it is missing from the bindings.
Quoted 9 lines
Quoted 6 lines
This series documents the audio codec properties in rockchip,rk809.yaml bindings and updates example.
Changes in v2:
- Fix vcc-supply warning detected bydt_bindingbot
- Fix missing include and pinctrl for codec exampleI just reviewed v1. Please apply those comments. And wait a bit between sending new versions.
Sorry about that, first series was broken as per bot response, but will wait longer in future.
Regards
Tim
Quoted 2 lines
Rob