Skip to contentSkip to conversation

glibc: ptest: Fix glibc-tests package issue

PATCH In review pgowda 2 participants 3 messages Apr 18, 2022

lore
Share & tools
lore

pgowda

author
#0 lore raw

PATCH 1/1 glibc: ptest: Fix glibc-tests package issue

The current default DISTRO_FEATURES does not support ptest. Hence, the following error is generated during "bitbake glibc-tests".
ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
Files/directories were installed but not shipped in any package The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES in Yocto supports ptest. However, when we run "glibc-tests" using Open-embedded master sources; it generates the error as default DISTRO is used.

---
 meta/conf/distro/include/default-distrovars.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/distro/include/default-distrovars.inc +1 -1
index 3edba1b6d0..d6060ad3ba 100644
@@ -16,7 +16,7 @@ DISTRO_FEATURES_DEFAULT:remove:riscv32 = "seccomp"
 # seccomp is not yet ported to ARC
 DISTRO_FEATURES_DEFAULT:remove:arc = "seccomp"
 
-DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
+DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp ptest"
 DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
 IMAGE_FEATURES ?= ""
 
Signature · 1 line
2.35.1
#1 lore raw
Quoted 9 lines · pgowda

The current default DISTRO_FEATURES does not support ptest. Hence, the following error is generated during "bitbake glibc-tests".
ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
Files/directories were installed but not shipped in any package The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES in Yocto supports ptest. However, when we run "glibc-tests" using Open-embedded master sources; it generates the error as default DISTRO is used.

Quoted 4 lines
---
 meta/conf/distro/include/default-distrovars.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This isn't quite the right approach, we should probably skip parsing of glibc- tests if ptests aren't in DISTRO_FEATURES?

Cheers,

Richard

author
#2 lore raw

Hi Richard,

Thanks very much for mentioning the correct way of fixing the issue.

The modified patch is posted as:-
https://lists.openembedded.org/g/openembedded-core/message/164524

Please let me know whether it's the way you mentioned it.
Or Can you please point me to other instances where it's been implemented.

Thanks & Regards
Pgowda

Quoted 23 lines · Richard Purdie
Quoted 9 lines · pgowda

The current default DISTRO_FEATURES does not support ptest. Hence, the following error is generated during "bitbake glibc-tests".
ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
Files/directories were installed but not shipped in any package The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES in Yocto supports ptest. However, when we run "glibc-tests" using Open-embedded master sources; it generates the error as default DISTRO is used.

Quoted 4 lines
---
 meta/conf/distro/include/default-distrovars.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This isn't quite the right approach, we should probably skip parsing of glibc- tests if ptests aren't in DISTRO_FEATURES?

Cheers,

Richard