iommu: ipmmu-vmsa: avoid Wformat-security warning
PATCH 1/1 iommu: ipmmu-vmsa: avoid Wformat-security warning
From: Arnd Bergmann <[email protected]>
iommu_device_sysfs_add() requires a constant format string, otherwise a W=1 build produces a warning:
drivers/iommu/ipmmu-vmsa.c:1093:62: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
1093 | ret = iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev));
| ^~~~~~~~~~~~~~~~~~~~drivers/iommu/ipmmu-vmsa.c:1093:62: note: treat the string as an argument to avoid this
1093 | ret = iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev));
| ^
| "%s",This was an old bug but I saw it now because the code was changed as part of commit d9d3cede4167 ("iommu/ipmmu-vmsa: Register in a sensible order").
--- drivers/iommu/ipmmu-vmsa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iommu/ipmmu-vmsa.c +2 -1
@@ -1090,7 +1090,8 @@ static int ipmmu_probe(struct platform_device *pdev)if (mmu->features->has_cache_leaf_nodes &&ipmmu_is_root (mmu))return 0 ; - ret =iommu_device_sysfs_add (&mmu->iommu, &pdev->dev,NULL ,dev_name (&pdev->dev)); + ret =iommu_device_sysfs_add (&mmu->iommu, &pdev->dev,NULL ,"%s" , +dev_name (&pdev->dev));if (ret)return ret;
Signature · 1 line
2.39.5
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
iommu_device_sysfs_add()requires a constant format string, otherwise a W=1 build produces a warning:
drivers/iommu/ipmmu-vmsa.c:1093:62: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
1093 | ret =iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev));
| ^~~~~~~~~~~~~~~~~~~~drivers/iommu/ipmmu-vmsa.c:1093:62: note: treat the string as an argument to avoid this1093 | ret = iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev)); | ^ | "%s",
Quoted 8 lines
This was an old bug but I saw it now because the code was changed as part of commit
d9d3cede4167("iommu/ipmmu-vmsa: Register in a sensible order").Fixes 7af9a5fdb9e0 ("iommu/ipmmu-vmsa: Use iommu_device_sysfs_add()/remove()")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/iommu/ipmmu-vmsa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Jason
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
iommu_device_sysfs_add()requires a constant format string, otherwise a W=1 build produces a warning:
drivers/iommu/ipmmu-vmsa.c:1093:62: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
1093 | ret =iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev));
| ^~~~~~~~~~~~~~~~~~~~drivers/iommu/ipmmu-vmsa.c:1093:62: note: treat the string as an argument to avoid this1093 | ret = iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev)); | ^ | "%s",
Quoted 5 lines
This was an old bug but I saw it now because the code was changed as part of commit
d9d3cede4167("iommu/ipmmu-vmsa: Register in a sensible order").Fixes 7af9a5fdb9e0 ("iommu/ipmmu-vmsa: Use iommu_device_sysfs_add()/remove()")Signed-off-by Arnd Bergmann <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
iommu_device_sysfs_add()requires a constant format string, otherwise a W=1 build produces a warning:
drivers/iommu/ipmmu-vmsa.c:1093:62: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
1093 | ret =iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev));
| ^~~~~~~~~~~~~~~~~~~~drivers/iommu/ipmmu-vmsa.c:1093:62: note: treat the string as an argument to avoid this1093 | ret = iommu_device_sysfs_add(&mmu->iommu, &pdev->dev, NULL, dev_name(&pdev->dev)); | ^ | "%s",
Quoted 8 lines
This was an old bug but I saw it now because the code was changed as part of commit
d9d3cede4167("iommu/ipmmu-vmsa: Register in a sensible order").Fixes 7af9a5fdb9e0 ("iommu/ipmmu-vmsa: Use iommu_device_sysfs_add()/remove()")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/iommu/ipmmu-vmsa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.