wifi: mwifiex: Don't use %pK through printk
PATCH 1/1 wifi: mwifiex: Don't use %pK through printk
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping looks in atomic contexts.
Switch to the regular pointer formatting which is safer and easier to reason about.
There are still a few users of %pK left, but these use it through seq_file, for which its usage is safe.
---
This was originally part of
https://lore.kernel.org/lkml/[email protected]/
--- drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/marvell/mwifiex/pcie.c +1 -1
@@ -2971,7 +2971,7 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter) goto err_iomap2; } -pr_notice ("PCI memory map Virt0: %pK PCI memory map Virt2: %pK\n" , +pr_notice ("PCI memory map Virt0: %p PCI memory map Virt2: %p\n" , card->pci_mmap, card->pci_mmap1); ret =mwifiex_pcie_alloc_buffers (adapter);
---
base-commit: cfb2e2c57aef75a414c0f18445c7441df5bc13be
change-id: 20250417-restricted-pointers-wifi-27aca4f6dc2e
Best regards,
Signature · 1 line
Thomas Weißschuh <[email protected]>
Quoted 8 lines · Thomas Weißschuh
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log.
Since commitad67b74d2469("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used throughprintk(). They can still unintentionally leak raw pointers or acquire sleeping looks in atomic contexts.
Quoted 7 lines
Switch to the regular pointer formatting which is safer and easier to reason about.
There are still a few users of %pK left, but these use it throughseq_file, for which its usage is safe.Signed-off-by Thomas Weißschuh <[email protected]>Reviewed-by Aleksandr Loktionov <[email protected]>
FWIW: