Skip to contentSkip to conversation

tests/docker/dockerfiles: Use Fedora 41 for the python container file

PATCH In review Thomas Huth 3 participants 4 messages Apr 22, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/docker/dockerfiles: Use Fedora 41 for the python container file

From: Thomas Huth <[email protected]>

Using "fedora:latest" now fails with Fedora 42:

Failed to resolve the transaction:
No match for argument: python3.8

Switch back to Fedora 41 for the time being, to be able to still test with Python 3.8.

---
 tests/docker/dockerfiles/python.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/python.docker +1 -1
index 8f0af9ef25f..1245523320d 100644
@@ -1,6 +1,6 @@
 # Python library testing environment
 
-FROM fedora:latest
+FROM fedora:41
 MAINTAINER John Snow <[email protected]>
 
 # Please keep this list sorted alphabetically
Signature · 1 line
2.49.0
#1 lore raw
Quoted 9 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Using "fedora:latest" now fails with Fedora 42:

Failed to resolve the transaction:
No match for argument: python3.8

Switch back to Fedora 41 for the time being, to be able to still test with Python 3.8.

This page details why it is was removed:

https://fedoraproject.org/wiki/Changes/RetirePython3.8

Based on the explanation there, it seems doubtful that any of our targetted build platforms have python 3.8. Thus I'd question whether we should test 3.8 at all.

IOW, rather than pin to fedora:41, it seems better to drop python3.8 from the dockerfile.

Quoted 22 lines
---
 tests/docker/dockerfiles/python.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/python.docker +1 -1
index 8f0af9ef25f..1245523320d 100644
@@ -1,6 +1,6 @@
 # Python library testing environment
 
-FROM fedora:latest
+FROM fedora:41
 MAINTAINER John Snow <[email protected]>
 
 # Please keep this list sorted alphabetically
Signature · 1 line
2.49.0

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
Quoted 14 lines · Daniel P. Berrangé
Quoted 9 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Using "fedora:latest" now fails with Fedora 42:

Failed to resolve the transaction:
No match for argument: python3.8

Switch back to Fedora 41 for the time being, to be able to still test with Python 3.8.

This page details why it is was removed:

Quoted 8 lines

https://fedoraproject.org/wiki/Changes/RetirePython3.8

Based on the explanation there, it seems doubtful that any of our targetted build platforms have python 3.8. Thus I'd question whether we should test 3.8 at all.

IOW, rather than pin to fedora:41, it seems better to drop python3.8 from the dockerfile.

I'm in favor of pinning so that the test is reproducible. A test that passed on a given git commit should pass again when it is re-run.

It's very inconvenient when tests fail arbitrarily due to unpinned dependencies. Often the person who has to debug a non-reproducible test failure is not knowledgeable about the test setup. They shouldn't have to debug failures unrelated to their patch series.

Stefan

Quoted 32 lines
Quoted 20 lines
---
 tests/docker/dockerfiles/python.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/python.docker +1 -2
index 8f0af9ef25f..1245523320d 100644
@@ -1,6 +1,6 @@
 # Python library testing environment
 
-FROM fedora:latest
+FROM fedora:41
 MAINTAINER John Snow <[email protected]>
 
 # Please keep this list sorted alphabetically
--
Quoted 3 lines

2.49.0

With regards,
Daniel
--

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#3 lore raw
Quoted 21 lines · Stefan Hajnoczi
Quoted 20 lines · Daniel P. Berrangé
Quoted 9 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Using "fedora:latest" now fails with Fedora 42:

Failed to resolve the transaction:
No match for argument: python3.8

Switch back to Fedora 41 for the time being, to be able to still test with Python 3.8.

This page details why it is was removed:

https://fedoraproject.org/wiki/Changes/RetirePython3.8

Based on the explanation there, it seems doubtful that any of our targetted build platforms have python 3.8. Thus I'd question whether we should test 3.8 at all.

Quoted 5 lines
Quoted 2 lines

IOW, rather than pin to fedora:41, it seems better to drop python3.8 from the dockerfile.

I'm in favor of pinning so that the test is reproducible. A test that passed on a given git commit should pass again when it is re-run.

Yes, we also don't use ":latest" in any of the other tests, so pinning to a specific version also sounds like the better idea to me.

Anyway, if we really want to drop Python 3.8 (which we likely should do now indeed), we also have to update "configure" and docs/about/build-platforms.rst and likely some other spots... John?

Thomas