misc: ti_fpc202: Fix off by one in probe()
PATCH 1/1 misc: ti_fpc202: Fix off by one in probe()
The "port_id" is used as an array index into the struct fpc202_priv priv->addr_caches[] array in fpc202_write_dev_addr(). It's a 2 by 2 array so if "port_id" is FPC202_NUM_PORTS (2) then it's one element out of bounds. Change the > to >= to fix this bug.
--- drivers/misc/ti_fpc202.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/ti_fpc202.c +1 -1
@@ -370,7 +370,7 @@ static int fpc202_probe(struct i2c_client *client) goto unregister_chans; } -if (port_id >FPC202_NUM_PORTS ) { +if (port_id >=FPC202_NUM_PORTS ) {dev_err (dev,"port ID %d is out of range!\n" , port_id); ret = -EINVAL ; goto unregister_chans;
Signature · 1 line
2.47.2
Quoted 8 lines · Dan Carpenter
The "
port_id" is used as an array index into the structfpc202_privpriv->addr_caches[] array infpc202_write_dev_addr(). It's a 2 by 2 array so if "port_id" isFPC202_NUM_PORTS(2) then it's one element out of bounds. Change the > to >= to fix this bug.Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")Signed-off-by Dan Carpenter <[email protected]>---
Quoted 16 lines · On Wednesday, 23 April 2025 10:22:30 CEST Dan Carpenter wrote:
The "
port_id" is used as an array index into the structfpc202_privpriv->addr_caches[] array infpc202_write_dev_addr(). It's a 2 by 2 array so if "port_id" isFPC202_NUM_PORTS(2) then it's one element out of bounds. Change the > to >= to fix this bug.Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")Signed-off-by Dan Carpenter <[email protected]>--- drivers/misc/ti_fpc202.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/ti_fpc202.c +0
-0
drivers/misc/ti_fpc202.c static int fpc202_probe(struct i2c_client *client) · line 376
Quoted 8 lines
drivers/misc/ti_fpc202.c +1
-1@@ -370,7 +370,7 @@ static int fpc202_probe(struct i2c_client *client) goto unregister_chans; } -if (port_id >FPC202_NUM_PORTS ) { +if (port_id >=FPC202_NUM_PORTS ) {dev_err (dev,"port ID %d is out of range!\n" , port_id); ret = -EINVAL ; goto unregister_chans;
Hi Dan,
Quoted 7 lines · Dan Carpenter
The "
port_id" is used as an array index into the structfpc202_privpriv->addr_caches[] array infpc202_write_dev_addr(). It's a 2 by 2 array so if "port_id" isFPC202_NUM_PORTS(2) then it's one element out of bounds. Change the > to >= to fix this bug.Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")Signed-off-by Dan Carpenter <[email protected]>
Thanks,
Andi