xen-hptool small cleanups
cover xen-hptool small cleanups
Two small cleanups for xen-hptool.
Jason Andryuk (2):
tools/xen-hptool: Add missing newlines
tools/xen-hptool: Replace hard tabs
tools/misc/xen-hptool.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.49.0
PATCH 1/2 tools/xen-hptool: Add missing newlines
Add some missing newlines to error messages.
--- tools/misc/xen-hptool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/misc/xen-hptool.c +2 -2
@@ -51,7 +51,7 @@ static int hp_mem_online_func(int argc, char *argv[]) ret =xc_mark_page_online (xch, mfn, mfn, &status);if (ret <0 ) -fprintf (stderr,"Onlining page mfn %lx failed, error %x" , mfn, errno); +fprintf (stderr,"Onlining page mfn %lx failed, error %x\n" , mfn, errno);else if (status & (PG_ONLINE_FAILED |PG_ONLINE_BROKEN )) {fprintf (stderr,"Onlining page mfn %lx is broken, " "Memory online failed\n" , mfn);
@@ -82,7 +82,7 @@ static int hp_mem_query_func(int argc, char *argv[]) ret =xc_query_page_offline_status (xch, mfn, mfn, &status);if (ret <0 ) -fprintf (stderr,"Querying page mfn %lx failed, error %x" , mfn, errno); +fprintf (stderr,"Querying page mfn %lx failed, error %x\n" , mfn, errno);else {printf ("Memory Status %x: [" , status);
Signature · 1 line
2.49.0
Re: [PATCH 1/2] tools/xen-hptool: Add missing newlines
Quoted 4 lines · Jason Andryuk
Add some missing newlines to error messages.
Fixes 284d5633be37 ("Tools: add online/offline hotplug user interfaces")Signed-off-by Jason Andryuk <[email protected]>
Quoted 30 lines
--- tools/misc/xen-hptool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/misc/xen-hptool.c +2
-3@@ -51,7 +51,7 @@ static int hp_mem_online_func(int argc, char *argv[]) ret =xc_mark_page_online (xch, mfn, mfn, &status);if (ret <0 ) -fprintf (stderr,"Onlining page mfn %lx failed, error %x" , mfn, errno); +fprintf (stderr,"Onlining page mfn %lx failed, error %x\n" , mfn, errno);else if (status & (PG_ONLINE_FAILED |PG_ONLINE_BROKEN )) {fprintf (stderr,"Onlining page mfn %lx is broken, " "Memory online failed\n" , mfn);@@ -82,7 +82,7 @@ static int hp_mem_query_func(int argc, char *argv[]) ret =xc_query_page_offline_status (xch, mfn, mfn, &status);if (ret <0 ) -fprintf (stderr,"Querying page mfn %lx failed, error %x" , mfn, errno); +fprintf (stderr,"Querying page mfn %lx failed, error %x\n" , mfn, errno);else {printf ("Memory Status %x: [" , status); --2.49.0
Re: [PATCH 1/2] tools/xen-hptool: Add missing newlines
In reply to Jason AndryukQuoted 4 lines · Jason Andryuk
Add some missing newlines to error messages.
Fixes 284d5633be37 ("Tools: add online/offline hotplug user interfaces")Signed-off-by Jason Andryuk <[email protected]>
Thanks,
Signature · 1 line
Anthony PERARD
PATCH 2/2 tools/xen-hptool: Replace hard tabs
In reply to Jason AndryukWith a tab stop of 8, the alignment is off. Replace the hard tabs with spaces to match the file.
--- tools/misc/xen-hptool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/misc/xen-hptool.c +3 -3
@@ -56,7 +56,7 @@ static int hp_mem_online_func(int argc, char *argv[])fprintf (stderr,"Onlining page mfn %lx is broken, " "Memory online failed\n" , mfn); ret =-1 ; - } + }else if (status &PG_ONLINE_ONLINED )printf ("Memory mfn %lx onlined successfully\n" , mfn);else
@@ -85,14 +85,14 @@ static int hp_mem_query_func(int argc, char *argv[])fprintf (stderr,"Querying page mfn %lx failed, error %x\n" , mfn, errno); else { -printf ("Memory Status %x: [" , status); +printf ("Memory Status %x: [" , status);if ( status &PG_OFFLINE_STATUS_OFFLINE_PENDING )printf (" PAGE_OFFLINE_PENDING " );if ( status &PG_OFFLINE_STATUS_BROKEN )printf (" PAGE_BROKEND " );if ( status &PG_OFFLINE_STATUS_OFFLINED )printf (" PAGE_OFFLINED " ); -else +else printf (" PAGE_ONLINED " );printf ("]\n" ); }
Signature · 1 line
2.49.0
Re: [PATCH 2/2] tools/xen-hptool: Replace hard tabs
Quoted 5 lines · Jason Andryuk
With a tab stop of 8, the alignment is off. Replace the hard tabs with spaces to match the file.
Fixes 284d5633be37 ("Tools: add online/offline hotplug user interfaces")Signed-off-by Jason Andryuk <[email protected]>
Quoted 38 lines
--- tools/misc/xen-hptool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/misc/xen-hptool.c +3
-4@@ -56,7 +56,7 @@ static int hp_mem_online_func(int argc, char *argv[])fprintf (stderr,"Onlining page mfn %lx is broken, " "Memory online failed\n" , mfn); ret =-1 ; - } + }else if (status &PG_ONLINE_ONLINED )printf ("Memory mfn %lx onlined successfully\n" , mfn);else @@ -85,14 +85,14 @@ static int hp_mem_query_func(int argc, char *argv[])fprintf (stderr,"Querying page mfn %lx failed, error %x\n" , mfn, errno); else { -printf ("Memory Status %x: [" , status); +printf ("Memory Status %x: [" , status);if ( status &PG_OFFLINE_STATUS_OFFLINE_PENDING )printf (" PAGE_OFFLINE_PENDING " );if ( status &PG_OFFLINE_STATUS_BROKEN )printf (" PAGE_BROKEND " );if ( status &PG_OFFLINE_STATUS_OFFLINED )printf (" PAGE_OFFLINED " ); -else +else printf (" PAGE_ONLINED " );printf ("]\n" ); } --2.49.0
Re: [PATCH 2/2] tools/xen-hptool: Replace hard tabs
In reply to Jason AndryukQuoted 5 lines · Jason Andryuk
With a tab stop of 8, the alignment is off. Replace the hard tabs with spaces to match the file.
Fixes 284d5633be37 ("Tools: add online/offline hotplug user interfaces")Signed-off-by Jason Andryuk <[email protected]>
Thanks,
Signature · 1 line
Anthony PERARD