phy: qcom: qmp-pcie: drop bogus x1e80100 qref supply
Subsystems (2)
PATCH 1/1 phy: qcom: qmp-pcie: drop bogus x1e80100 qref supply
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1be0000.phy: supply vdda-qref not found, using dummy regulator
--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +2 -2
@@ -4233,8 +4233,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x8_pciephy_cfg = { .reset_list = sdm845_pciephy_reset_l, .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l), - .vreg_list = sm8550_qmp_phy_vreg_l, - .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l), + .vreg_list = qmp_phy_vreg_l, + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = pciephy_v6_regs_layout, .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
Signature · 1 line
2.49.0
Quoted 8 lines · Johan Hovold
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1be0000.phy: supply vdda-qref not found, using dummy regulator
Fixes e961ec81a39b ("phy: qcom: qmp: Add phy register and clk setting for x1e80100 PCIe3")Cc Qiang Yu <[email protected]>Signed-off-by Johan Hovold <[email protected]>
Quoted 9 lines · Johan Hovold
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1be0000.phy: supply vdda-qref not found, using dummy regulator
Fixes e961ec81a39b ("phy: qcom: qmp: Add phy register and clk setting for x1e80100 PCIe3")Cc Qiang Yu <[email protected]>Signed-off-by Johan Hovold <[email protected]>---
We have QREF for each PCIe port on the X1E80100, all of which consume the regulator L3J. Although the PCIe PHY uses QREF indirectly, this creates a dependency, right? If PCIe doesn't vote for it, how can the PMIC driver decide when to disable L3J during system suspend or runtime suspend? Is there a chance that L3J could be disabled while PCIe still requires it?
Quoted 18 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +2
-2@@ -4233,8 +4233,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x8_pciephy_cfg = { .reset_list = sdm845_pciephy_reset_l, .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l), - .vreg_list = sm8550_qmp_phy_vreg_l, - .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l), + .vreg_list = qmp_phy_vreg_l, + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = pciephy_v6_regs_layout, .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
Signature · 2 lines
With best wishes Qiang Yu
Quoted 7 lines · Qiang Yu
Quoted 5 lines · Johan Hovold
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1be0000.phy: supply vdda-qref not found, using dummy regulator
Quoted 8 lines
Quoted 4 lines
Fixes e961ec81a39b ("phy: qcom: qmp: Add phy register and clk setting for x1e80100 PCIe3")Cc Qiang Yu <[email protected]>Signed-off-by Johan Hovold <[email protected]>---
We have QREF for each PCIe port on the X1E80100, all of which consume the regulator L3J. Although the PCIe PHY uses QREF indirectly, this creates a dependency, right?
The PHY binding should describe the direct dependencies for the PHY, so the addition of qref for sm8550/sm8650 was probably also a mistake.
From what I could tell there is not even a one-to-one mapping of qref supplies to PCIe ports, but perhaps you can provide more details on how this fits together here?
Quoted 4 lines
If PCIe doesn't vote for it, how can the
PMIC driver decide when to disable L3J during system suspend or runtime suspend? Is there a chance that L3J could be disabled while PCIe still requires it?
If the QREF supplies can be turned off, you may need to mark them as always-on until things are described properly. But whether that's needed is not even clear at this point:
https://lore.kernel.org/lkml/[email protected]/
Johan
Quoted 6 lines · Johan Hovold
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1be0000.phy: supply vdda-qref not found, using dummy regulator
Applied, thanks!
[1/1] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supply
commit: eb7a22f830f68997d76e660a02143c2bc72e7fb7
Best regards,
Signature · 1 line
~Vinod