Skip to contentSkip to conversation

virt: acrn: Remove unused list 'acrn_irqfd_clients'

PATCH In review [email protected] 2 participants 3 messages Apr 30, 2025 Acrn hypervisor service module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virt: acrn: Remove unused list 'acrn_irqfd_clients'

From: "Dr. David Alan Gilbert" <[email protected]>

It doesn't look like this was ever used.

Build tested only.

---
This is a repost of the patch originally posted last in May last year as id [email protected] and Ack'd by Fei Li on 20th May, in Zkq183IzBA6cV9FE@louislifei-OptiPlex-7090 No one picked it up.
(Fixed one typo in the subject line)

 drivers/virt/acrn/irqfd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/virt/acrn/irqfd.c +0 -2
index b7da24ca1475..64d32c8fbf79 100644
@@ -16,8 +16,6 @@
 
 #include "acrn_drv.h"
 
-static LIST_HEAD(acrn_irqfd_clients);
-
 /**
  * struct hsm_irqfd - Properties of HSM irqfd
  * @vm:		Associated VM pointer
Signature · 1 line
2.49.0
#1 lore raw
Quoted 23 lines · On Wed, Apr 30, 2025 at 01:36:23AM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

It doesn't look like this was ever used.

Build tested only.

---
This is a repost of the patch originally posted last in May last year as id [email protected] and Ack'd by Fei Li on 20th May, in Zkq183IzBA6cV9FE@louislifei-OptiPlex-7090 No one picked it up.
(Fixed one typo in the subject line)

 drivers/virt/acrn/irqfd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/virt/acrn/irqfd.c +0 -0
index b7da24ca1475..64d32c8fbf79 100644

drivers/virt/acrn/irqfd.c line 20

Quoted 5 lines
drivers/virt/acrn/irqfd.c +0 -2
@@ -16,8 +16,6 @@
 
 #include "acrn_drv.h"
 
-static LIST_HEAD(acrn_irqfd_clients);
-

Odd, why doesn't the compiler complain about this?

I'll queue it up in a bit, thanks!

greg k-h

#2 lore raw
Quoted 25 lines · * Greg KH ([email protected]) wrote:
Quoted 24 lines · On Wed, Apr 30, 2025 at 01:36:23AM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

It doesn't look like this was ever used.

Build tested only.

---
This is a repost of the patch originally posted last in May last year as id [email protected] and Ack'd by Fei Li on 20th May, in Zkq183IzBA6cV9FE@louislifei-OptiPlex-7090 No one picked it up.
(Fixed one typo in the subject line)

 drivers/virt/acrn/irqfd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/virt/acrn/irqfd.c +0 -0
index b7da24ca1475..64d32c8fbf79 100644
@@ -16,8 +16,6 @@
 
Quoted 6 lines

drivers/virt/acrn/irqfd.c line 20

Quoted 4 lines
drivers/virt/acrn/irqfd.c +0 -2
 #include "acrn_drv.h"
 
-static LIST_HEAD(acrn_irqfd_clients);
-

Odd, why doesn't the compiler complain about this?

Because it is used - by its own initialiser!
I filed a gcc bug for it:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115027
and someone has written a patch but it hasn't gone further.

Quoted 1 line

I'll queue it up in a bit, thanks!

Thanks!

Dave

Quoted 1 line

greg k-h

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/