Skip to contentSkip to conversation

rtc: drop unused module alias

PATCH Applied Johan Hovold 6 participants 19 messages Apr 23, 2025 – May 24, 2025

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover rtc: drop unused module alias

When working on the pm8xxx driver I noticed that it had a platform module alias while only supporting OF probe. This series drops it along with unused aliases in the other RTC drivers.

Johan

Johan Hovold (7):
rtc: at91rm9200: drop unused module alias
rtc: cpcap: drop unused module alias
rtc: da9063: drop unused module alias
rtc: jz4740: drop unused module alias
rtc: pm8xxx: drop unused module alias
rtc: s3c: drop unused module alias
rtc: stm32: drop unused module alias

 drivers/rtc/rtc-at91rm9200.c | 1 -
 drivers/rtc/rtc-cpcap.c      | 1 -
 drivers/rtc/rtc-da9063.c     | 1 -
 drivers/rtc/rtc-jz4740.c     | 1 -
 drivers/rtc/rtc-pm8xxx.c     | 1 -
 drivers/rtc/rtc-s3c.c        | 1 -
 drivers/rtc/rtc-stm32.c      | 1 -
 7 files changed, 7 deletions(-)
Signature · 1 line
2.49.0
#1 lore raw

PATCH 1/7 rtc: at91rm9200: drop unused module alias

The driver only support OF probe so drop the unused platform module alias.

Fixes 288d9cf1764a ("rtc: at91rm9200: use of_device_get_match_data()")
---
 drivers/rtc/rtc-at91rm9200.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-at91rm9200.c +0 -1
index f6b0102a843a..643734dbae33 100644
@@ -654,4 +654,3 @@ module_platform_driver_probe(at91_rtc_driver, at91_rtc_probe);
 MODULE_AUTHOR("Rick Bronson");
 MODULE_DESCRIPTION("RTC driver for Atmel AT91RM9200");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:at91_rtc");
Signature · 1 line
2.49.0
#3 lore raw

PATCH 2/7 rtc: cpcap: drop unused module alias

In reply to Johan Hovold

The driver only supports OF probe so drop the unused platform module alias.

Fixes dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
---
 drivers/rtc/rtc-cpcap.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-cpcap.c +0 -1
index 568a89e79c11..c170345ac076 100644
@@ -320,7 +320,6 @@ static struct platform_driver cpcap_rtc_driver = {
 
 module_platform_driver(cpcap_rtc_driver);
 
-MODULE_ALIAS("platform:cpcap-rtc");
 MODULE_DESCRIPTION("CPCAP RTC driver");
 MODULE_AUTHOR("Sebastian Reichel <[email protected]>");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.49.0
Reviewed-by on v1 2/7
#4 lore raw

Re: [PATCH 2/7] rtc: cpcap: drop unused module alias

Hi,

Quoted 6 lines · Johan Hovold

The driver only supports OF probe so drop the unused platform module alias.

Fixes dd3bf50b35e3 ("rtc: cpcap: new rtc driver")

---

-- Sebastian

Quoted 18 lines
 drivers/rtc/rtc-cpcap.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-cpcap.c +0 -1
index 568a89e79c11..c170345ac076 100644
@@ -320,7 +320,6 @@ static struct platform_driver cpcap_rtc_driver = {
 
 module_platform_driver(cpcap_rtc_driver);
 
-MODULE_ALIAS("platform:cpcap-rtc");
 MODULE_DESCRIPTION("CPCAP RTC driver");
 MODULE_AUTHOR("Sebastian Reichel <[email protected]>");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.49.0
#5 lore raw

PATCH 3/7 rtc: da9063: drop unused module alias

In reply to Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes 80ca3277bc7f ("rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver")
---
 drivers/rtc/rtc-da9063.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-da9063.c +0 -1
index 859397541f29..38988d952db8 100644
@@ -513,4 +513,3 @@ module_platform_driver(da9063_rtc_driver);
 MODULE_AUTHOR("S Twiss <[email protected]>");
 MODULE_DESCRIPTION("Real time clock device driver for Dialog DA9063");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DA9063_DRVNAME_RTC);
Signature · 1 line
2.49.0
#7 lore raw

PATCH 4/7 rtc: jz4740: drop unused module alias

In reply to Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes 24e1f2c9383e ("rtc: ingenic: Only support probing from devicetree")
---
 drivers/rtc/rtc-jz4740.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-jz4740.c +0 -1
index 44bba356268c..11fce47be780 100644
@@ -437,4 +437,3 @@ module_platform_driver(jz4740_rtc_driver);
 MODULE_AUTHOR("Lars-Peter Clausen <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("RTC driver for the JZ4740 SoC\n");
-MODULE_ALIAS("platform:jz4740-rtc");
Signature · 1 line
2.49.0
maintainer Acked-by on v1 4/7
#8 lore raw

Re: [PATCH 4/7] rtc: jz4740: drop unused module alias

Hi Johan,

Le mercredi 23 avril 2025 à 15:03 +0200, Johan Hovold a écrit :

Quoted 6 lines

The driver only support OF probe so drop the unused platform module alias.

Fixes 24e1f2c9383e ("rtc: ingenic: Only support probing from

devicetree")

Cheers,
-Paul

Quoted 13 lines

---
 drivers/rtc/rtc-jz4740.c | 1 -

 1 file changed, 1 deletion(-)
drivers/rtc/rtc-jz4740.c +0 -1
index 44bba356268c..11fce47be780 100644
@@ -437,4 +437,3 @@ module_platform_driver(jz4740_rtc_driver);
  MODULE_AUTHOR("Lars-Peter Clausen <[email protected]>");
  MODULE_LICENSE("GPL");
  MODULE_DESCRIPTION("RTC driver for the JZ4740 SoC\n");
-MODULE_ALIAS("platform:jz4740-rtc");
#9 lore raw

PATCH 5/7 rtc: pm8xxx: drop unused module alias

In reply to Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes 5a418558cdae ("rtc: pm8xxx: add support for devicetree")
---
 drivers/rtc/rtc-pm8xxx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-pm8xxx.c +0 -1
index 5da237e7b9b2..e624f848c22b 100644
@@ -683,7 +683,6 @@ static struct platform_driver pm8xxx_rtc_driver = {
 
 module_platform_driver(pm8xxx_rtc_driver);
 
-MODULE_ALIAS("platform:rtc-pm8xxx");
 MODULE_DESCRIPTION("PMIC8xxx RTC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Anirudh Ghayal <[email protected]>");
Signature · 1 line
2.49.0
#11 lore raw

PATCH 6/7 rtc: s3c: drop unused module alias

In reply to Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
---
 drivers/rtc/rtc-s3c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-s3c.c +0 -1
index 58c957eb753d..5dd575865adf 100644
@@ -609,4 +609,3 @@ module_platform_driver(s3c_rtc_driver);
 MODULE_DESCRIPTION("Samsung S3C RTC Driver");
 MODULE_AUTHOR("Ben Dooks <[email protected]>");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:s3c2410-rtc");
Signature · 1 line
2.49.0
Reviewed-by on v1 6/7
#12 lore raw

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

Quoted 4 lines · Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")

I believe this is not correct, but instead commit dropping last platform user, which I think was:

Fixes 0d297df03890 ("ARM: s3c: simplify platform code")

Just like in other patches here, these are old drivers and even if they have OF matching method, they can be or they were modprobed via board files.

Quoted 2 lines

---

With the fixes tag fixed (to whatever commit dropping last platform user):

Best regards,
Krzysztof

#13 lore raw

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

Quoted 10 lines · Krzysztof Kozlowski
Quoted 4 lines · Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")

I believe this is not correct, but instead commit dropping last platform user, which I think was:

Fixes 0d297df03890 ("ARM: s3c: simplify platform code")

No, as I write in the commit message, the driver only supports OF probe since the commit I refer to. It fails with -EINVAL and the following error logged:

failed getting s3c_rtc_data

for non-OF probe.

Quoted 2 lines

Just like in other patches here, these are old drivers and even if they have OF matching method, they can be or they were modprobed via board files.

See above, similar reasoning applies for the other patches.

Johan

#14 lore raw

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

Quoted 12 lines · Johan Hovold
Quoted 10 lines · Krzysztof Kozlowski
Quoted 4 lines · Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")

I believe this is not correct, but instead commit dropping last platform user, which I think was:

Fixes 0d297df03890 ("ARM: s3c: simplify platform code")
Quoted 7 lines

No, as I write in the commit message, the driver only supports OF probe since the commit I refer to. It fails with -EINVAL and the following error logged:

failed getting s3c_rtc_data

for non-OF probe.

Haha, nice, so commit in 2014 nicely broke that platform's RTC.

There is one more thing: back in 2013-2015, I don't remember exactly, the module loading/matching was not working with OF and you needed aliases for the actual bus - platform or I2C. IIRC, the bus - platform bus in this case - trigger uevent for module and then device match would be via OF.

Anyway, this would be only for s3c2410 DT platform, because all others (newer) use different compatible thus there would be no s3c2410-rtc uevent for them.

Well, does not matter much, just sharing.

Best regards,
Krzysztof

#15 lore raw

PATCH 7/7 rtc: stm32: drop unused module alias

In reply to Johan Hovold

The driver only support OF probe so drop the unused platform module alias.

Fixes 4e64350f42e2 ("rtc: add STM32 RTC driver")
---
 drivers/rtc/rtc-stm32.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-stm32.c +0 -1
index 1b715db47160..ef8fb88aab48 100644
@@ -1283,7 +1283,6 @@ static struct platform_driver stm32_rtc_driver = {
 
 module_platform_driver(stm32_rtc_driver);
 
-MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Amelie Delaunay <[email protected]>");
 MODULE_DESCRIPTION("STMicroelectronics STM32 Real Time Clock driver");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
2.49.0
#17 lore raw
In reply to Johan Hovold

Hi Alexandre,

Quoted 4 lines · Johan Hovold

When working on the pm8xxx driver I noticed that it had a platform module alias while only supporting OF probe. This series drops it along with unused aliases in the other RTC drivers.

Quoted 8 lines

Johan Hovold (7):
rtc: at91rm9200: drop unused module alias
rtc: cpcap: drop unused module alias
rtc: da9063: drop unused module alias
rtc: jz4740: drop unused module alias
rtc: pm8xxx: drop unused module alias
rtc: s3c: drop unused module alias
rtc: stm32: drop unused module alias

With the merge window around corner, could you pick these up for 6.16?

Johan

maintainer Applied
#18 lore raw
In reply to Johan Hovold
Quoted 8 lines · Johan Hovold

When working on the pm8xxx driver I noticed that it had a platform module alias while only supporting OF probe. This series drops it along with unused aliases in the other RTC drivers.

Johan

[...]

Applied, thanks!

[1/7] rtc: at91rm9200: drop unused module alias

      https://git.kernel.org/abelloni/c/9f05c3943eb6
[2/7] rtc: cpcap: drop unused module alias
      https://git.kernel.org/abelloni/c/5f28ab049fb3
[3/7] rtc: da9063: drop unused module alias
      https://git.kernel.org/abelloni/c/ac45f6e2473b
[4/7] rtc: jz4740: drop unused module alias
      https://git.kernel.org/abelloni/c/c61f165617b1
[5/7] rtc: pm8xxx: drop unused module alias
      https://git.kernel.org/abelloni/c/d5e85c8bfaa6
[6/7] rtc: s3c: drop unused module alias
      https://git.kernel.org/abelloni/c/149834a414e1
[7/7] rtc: stm32: drop unused module alias
      https://git.kernel.org/abelloni/c/3639b35857e2

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com