Skip to contentSkip to conversation

staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

PATCH RESEND In review Rujra Bhatt 3 participants 3 messages May 7, 2025 Staging

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gpib/agilent_82350b/agilent_82350b.c +1 -1
index b326058a10c0..94bbb3b6576d 100644
@@ -479,7 +479,7 @@ static void agilent_82350b_return_to_local(struct gpib_board *board)
 
 static int agilent_82350b_allocate_private(struct gpib_board *board)
 {
-	board->private_data = kzalloc(sizeof(struct * board->private_data), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(struct agilent_82350b_priv), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	return 0;
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 4 lines · Rujra Bhatt
---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Something went really wrong with your subject line :(

#2 lore raw
In reply to Rujra Bhatt

I think you sent an incorrect patch earlier and you're trying to revert that patch now? We never applied the patch so there is no need.

regards,
dan carpenter