question on sound/isa/msnd/msnd_midi.c
Hi,
I noticed that nothing calls snd_msndmidi_new insound/isa/msnd/msnd_midi.c and was about to delete it, but I'm not too sure - I think it's actually a bug where it should be called.
This code was added in 2009 by
commit f6c638350275 ("ALSA: Turtle Beach Multisound Classic/Pinnacle driver") (Pretty new for an ISA card!)
Looking at msnd_midi.c the only function in there that anything calls is snd_msndmidi_input_read() called by msnd_pinnacle.c but that is guarded by a check:
146 if (chip->msndmidi_mpu) 147 snd_msndmidi_input_read(chip->msndmidi_mpu);
but I don't think anything sets that msndmidi_mpu, since the only thing that could is snd_msndmidi_new() which isn't called.
I see that the original poster didn't test the external midi:
https://mailman.alsa-project.org/hyperkitty/list/[email protected]/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
so I guess this has always been missing.
I don't have the hardware to test.
Thoughts?
Dave
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Quoted 20 lines · Dr. David Alan Gilbert
Hi,
I noticed that nothing callssnd_msndmidi_newinsound/isa/msnd/msnd_midi.cand was about to delete it, but I'm not too sure - I think it's actually a bug where it should be called.This code was added in 2009 by
commitf6c638350275("ALSA: Turtle Beach Multisound Classic/Pinnacle driver") (Pretty new for an ISA card!)Looking at
msnd_midi.cthe only function in there that anything calls issnd_msndmidi_input_read()called bymsnd_pinnacle.cbut that is guarded by a check:146 if (chip->msndmidi_mpu) 147 snd_msndmidi_input_read(chip->msndmidi_mpu);but I don't think anything sets that
msndmidi_mpu, since the only thing that could issnd_msndmidi_new()which isn't called.
Quoted 7 lines
I see that the original poster didn't test the external midi:
https://mailman.alsa-project.org/hyperkitty/list/[email protected]/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
so I guess this has always been missing.I don't have the hardware to test.
Thoughts?
Well, it's a very old code on an old interface, and if it's not used (even because of a typo or an overlook), then it's basically no chance to be used in future. Let's rip off.
thanks,
Takashi
Quoted 26 lines · * Takashi Iwai ([email protected]) wrote:
Quoted 24 lines · Dr. David Alan Gilbert
Hi,
I noticed that nothing callssnd_msndmidi_newinsound/isa/msnd/msnd_midi.cand was about to delete it, but I'm not too sure - I think it's actually a bug where it should be called.This code was added in 2009 by
commitf6c638350275("ALSA: Turtle Beach Multisound Classic/Pinnacle driver") (Pretty new for an ISA card!)Looking at
msnd_midi.cthe only function in there that anything calls issnd_msndmidi_input_read()called bymsnd_pinnacle.cbut that is guarded by a check:146 if (chip->msndmidi_mpu) 147 snd_msndmidi_input_read(chip->msndmidi_mpu);but I don't think anything sets that
msndmidi_mpu, since the only thing that could issnd_msndmidi_new()which isn't called.I see that the original poster didn't test the external midi:
https://mailman.alsa-project.org/hyperkitty/list/[email protected]/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
so I guess this has always been missing.
Quoted 7 lines
Quoted 3 lines
I don't have the hardware to test.
Thoughts?
Well, it's a very old code on an old interface, and if it's not used (even because of a typo or an overlook), then it's basically no chance to be used in future. Let's rip off.
Ok, I'll cut a patch to remove snd_msndmidi_new() and then probably the whole of msnd_midi.c and the call in msnd_pinnacle.c
Dave
Quoted 5 lines
thanks,
Takashi
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Quoted 29 lines · * Dr. David Alan Gilbert ([email protected]) wrote:
Quoted 28 lines · * Takashi Iwai ([email protected]) wrote:
Quoted 26 lines · Dr. David Alan Gilbert
Hi,
I noticed that nothing callssnd_msndmidi_newinsound/isa/msnd/msnd_midi.cand was about to delete it, but I'm not too sure - I think it's actually a bug where it should be called.This code was added in 2009 by
commitf6c638350275("ALSA: Turtle Beach Multisound Classic/Pinnacle driver") (Pretty new for an ISA card!)Looking at
msnd_midi.cthe only function in there that anything calls issnd_msndmidi_input_read()called bymsnd_pinnacle.cbut that is guarded by a check:146 if (chip->msndmidi_mpu) 147 snd_msndmidi_input_read(chip->msndmidi_mpu);but I don't think anything sets that
msndmidi_mpu, since the only thing that could issnd_msndmidi_new()which isn't called.I see that the original poster didn't test the external midi:
https://mailman.alsa-project.org/hyperkitty/list/[email protected]/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
so I guess this has always been missing.I don't have the hardware to test.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Thoughts?
Well, it's a very old code on an old interface, and if it's not used (even because of a typo or an overlook), then it's basically no chance to be used in future. Let's rip off.
Ok, I'll cut a patch to remove
snd_msndmidi_new()and then probably the whole ofmsnd_midi.cand the call inmsnd_pinnacle.c
Patch sent, see message: [email protected]
Thanks,
Dave
Quoted 13 lines
Dave
Quoted 5 lines
thanks,
Takashi
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/