selftests: timers: valid-adjtimex: fix coding style issues
Subsystems (3)
PATCH v2 1/1 selftests: timers: valid-adjtimex: fix coding style issues
This patch corrects minor coding style issues to comply with the Linux kernel coding style:
- Align closing parentheses to match opening ones in printf statements.
- Break long lines to keep them within the 100-column limit.
These changes address warnings reported by checkpatch.pl and do not affect functionality.
changes in v2 :
- Resubmitted the patch with a properly formatted commit message, following patch submission guidelines, as suggested by Shuah Khan.
--- tools/testing/selftests/timers/valid-adjtimex.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
(quoted diff) +0 -0
b/tools/testing/selftests/timers/valid-adjtimex.c
index 6b7801055ad1..5110f9ee285c 100644
tools/testing/selftests/timers/valid-adjtimex.c +1 -1
@@ -157,7 +157,7 @@ int validate_freq(void)if (tx.freq == outofrange_freq[i]) {printf ("[FAIL]\n" );printf ("ERROR: out of range value %ld actually set!\n" , - tx.freq); + tx.freq); pass =-1 ; goto out; }
@@ -172,7 +172,7 @@ int validate_freq(void)if (ret >=0 ) {printf ("[FAIL]\n" ); printf("Error: No failure on invalid
ADJ_FREQUENCY %ld\n",
- invalid_freq[i]);
+ invalid_freq[i]);
pass = -1;
goto out;
}
@@ -238,7 +238,8 @@ int set_bad_offset(long sec, long usec, int use_nano)
tmx.time.tv_usec = usec;
ret = clock_adjtime(CLOCK_REALTIME, &tmx);
if (ret >= 0) {
- printf("Invalid (sec: %ld usec: %ld) did not fail! ",
tmx.time.tv_sec, tmx.time.tv_usec);
+ printf("Invalid (sec: %ld usec: %ld) did not fail! ",
+ tmx.time.tv_sec, tmx.time.tv_usec);
printf("[FAIL]\n");
return -1;
}--
2.43.0
Shuah Khan
maintainerQuoted 6 lines · Rujra Bhatt
This patch corrects minor coding style issues to comply with the Linux kernel coding style:
- Align closing parentheses to match opening ones in printf statements.
- Break long lines to keep them within the 100-column limit.
Quoted 8 lines
These changes address warnings reported by checkpatch.pl and do not affect functionality.
changes in v2 :
- Resubmitted the patch with a properly formatted commit message, following patch submission guidelines, as suggested by Shuah Khan.Signed-off-by Rujra Bhatt <[email protected]>
Sorry - I didn't realize these are all coding style related printf - I am no longer concerned about the length of print statements.
It is too much churn with little benefit.
thanks,
-- Shuah
Respected Shuah,
Quoted 15 lines · Shuah Khan
Quoted 13 lines · Rujra Bhatt
This patch corrects minor coding style issues to comply with the Linux kernel coding style:
- Align closing parentheses to match opening ones in printf statements.
- Break long lines to keep them within the 100-column limit.These changes address warnings reported by checkpatch.pl and do not affect functionality.
changes in v2 :
- Resubmitted the patch with a properly formatted commit message, following patch submission guidelines, as suggested by Shuah Khan.
Quoted 8 lines
Quoted 1 line
Signed-off-by Rujra Bhatt <[email protected]>Sorry - I didn't realize these are all coding style related printf - I am no longer concerned about the length of print statements.
It is too much churn with little benefit.
Thank you for the feedback , also understanding your perspective. For future contributions, I will focus on more substantive changes, unless stylistic
fixes are explicitly requested.
thank you,
regards,
Rujra Bhatt