Skip to contentSkip to conversation

drm/amdgpu: check return value of xa_store()

PATCH Superseded Salah Triki 2 participants 2 messages May 16, 2025 – Jul 27, 2025

Subsystems (2)
DRM drivers Radeon and amdgpu DRM drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Salah Triki

author
#0 lore raw

PATCH 1/1 drm/amdgpu: check return value of xa_store()

xa_store() may fail so check its return value and if error occurred free numa_info and return NULL.

Signed-off-by Salah Triki <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +6 -2
index 707e131f89d2..bff82ac651f4 100644
@@ -876,7 +876,7 @@ static inline uint64_t amdgpu_acpi_get_numa_size(int nid)
 
 static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm)
 {
-	struct amdgpu_numa_info *numa_info;
+	struct amdgpu_numa_info *numa_info, *old;
 	int nid;
 
 	numa_info = xa_load(&numa_info_xa, pxm);

@@ -898,7 +898,11 @@ static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm)
 		} else {
 			numa_info->size = amdgpu_acpi_get_numa_size(nid);
 		}
-		xa_store(&numa_info_xa, numa_info->pxm, numa_info, GFP_KERNEL);
+		old  = xa_store(&numa_info_xa, numa_info->pxm, numa_info, GFP_KERNEL);
+		if (xa_is_err(old)) {
+			kfree(numa_info);
+			return NULL;
+		}
 	}
 
 	return numa_info;
Signature · 1 line
2.43.0