perf trace: set errpid to false for rseq and set_robust_list
PATCH 1/1 perf trace: set errpid to false for rseq and set_robust_list
rseq and set_robust_list don't return a pid, so set errpid for both to false.
Fixes 0c1019e3463b2 and 1de5b5dcb8353.
--- tools/perf/builtin-trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/builtin-trace.c +2 -2
@@ -1348,7 +1348,7 @@ static const struct syscall_fmt syscall_fmts[] = { .arg = { [0] = { .scnprintf = SCA_FDAT, /* olddirfd */ }, [2] = { .scnprintf = SCA_FDAT, /* newdirfd */ }, [4] = { .scnprintf = SCA_RENAMEAT2_FLAGS, /* flags */ }, }, }, - { .name = "rseq", .errpid = true, + { .name = "rseq", .errpid = false, .arg = { [0] = { .from_user = true /* rseq */, }, }, }, { .name = "rt_sigaction", .arg = { [0] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, },
@@ -1372,7 +1372,7 @@ static const struct syscall_fmt syscall_fmts[] = { { .name = "sendto", .arg = { [3] = { .scnprintf = SCA_MSG_FLAGS, /* flags */ }, [4] = SCA_SOCKADDR_FROM_USER(addr), }, }, - { .name = "set_robust_list", .errpid = true, + { .name = "set_robust_list", .errpid = false, .arg = { [0] = { .from_user = true /* head */, }, }, }, { .name = "set_tid_address", .errpid = true, }, { .name = "setitimer",
Signature · 1 line
2.49.0
Quoted 6 lines · Anubhav Shelat
rseq and
set_robust_listdon't return a pid, so set errpid for both to false.Fixes
0c1019e3463b2and1de5b5dcb8353.Signed-off-by Anubhav Shelat <[email protected]>
Some minor nits on the commit log messages, I did some adjustments, please take a look.
Thanks, applied to perf-tools-next,
- Arnaldo
----
perf trace: Set errpid to false for rseq and set_robust_list
The 'rseq' and 'set_robust_list' syscalls don't return a pid, so set errpid for both to false.
Namhyung Kim
maintainerHello,
Quoted 15 lines · Anubhav Shelat
rseq and
set_robust_listdon't return a pid, so set errpid for both to false.Fixes
0c1019e3463b2and1de5b5dcb8353.Signed-off-by Anubhav Shelat <[email protected]>--- tools/perf/builtin-trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/builtin-trace.c +0
-0
tools/perf/builtin-trace.c static const struct syscall_fmt syscall_fmts[] = { · line 1351
Quoted 5 lines
tools/perf/builtin-trace.c +1
-1@@ -1348,7 +1348,7 @@ static const struct syscall_fmt syscall_fmts[] = { .arg = { [0] = { .scnprintf = SCA_FDAT, /* olddirfd */ }, [2] = { .scnprintf = SCA_FDAT, /* newdirfd */ }, [4] = { .scnprintf = SCA_RENAMEAT2_FLAGS, /* flags */ }, }, }, - { .name = "rseq", .errpid = true, + { .name = "rseq", .errpid = false,
Probably better to just remove the errpid part.
tools/perf/builtin-trace.c static const struct syscall_fmt syscall_fmts[] = { · line 1375
Quoted 9 lines
tools/perf/builtin-trace.c +1
-1.arg = { [0] = { .from_user = true /* rseq */, }, }, }, { .name = "rt_sigaction", .arg = { [0] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, },@@ -1372,7 +1372,7 @@ static const struct syscall_fmt syscall_fmts[] = { { .name = "sendto", .arg = { [3] = { .scnprintf = SCA_MSG_FLAGS, /* flags */ }, [4] = SCA_SOCKADDR_FROM_USER(addr), }, }, - { .name = "set_robust_list", .errpid = true, + { .name = "set_robust_list", .errpid = false,
Ditto.
Thanks,
Namhyung
Quoted 6 lines
tools/perf/builtin-trace.c +0
-0.arg = { [0] = { .from_user = true /* head */, }, }, }, { .name = "set_tid_address", .errpid = true, }, { .name = "setitimer",Signature · 1 line
2.49.0