Skip to contentSkip to conversation

binder: fix reversed pid/tid in log

PATCH In review Carlos Llamas 2 participants 2 messages Jun 5, 2025 – Jun 6, 2025 Android drivers

lore
Share & tools
lore

Carlos Llamas

author maintainer
#0 lore raw

PATCH 1/1 binder: fix reversed pid/tid in log

The "pid:tid" format is used consistently throughout the driver's logs with the exception of this one place where the arguments are reversed. Let's fix that. Also, collapse a multi-line comment into a single line.

Cc Steven Moreland <[email protected]>
---
 drivers/android/binder.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/android/binder.c +2 -4
index c463ca4a8fff..2bd8ac943171 100644
@@ -3144,10 +3144,8 @@ static void binder_transaction(struct binder_proc *proc,
 		}
 		if (!target_node) {
 			binder_txn_error("%d:%d cannot find target node\n",
-				thread->pid, proc->pid);
-			/*
-			 * return_error is set above
-			 */
+					 proc->pid, thread->pid);
+			/* return_error is set above */
 			return_error_param = -EINVAL;
 			return_error_line = __LINE__;
 			goto err_dead_binder;
Signature · 1 line
2.49.0.1266.g31b7d2e469-goog