Skip to contentSkip to conversation

ALSA: hda/ca0132: use snprintf() for kernel hardenning

PATCH In review Dan Carpenter 2 participants 2 messages Jun 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/ca0132: use snprintf() for kernel hardenning

In this sprintf():

	sprintf(namestr, "%s %s Volume", name, dirstr[dir]);

Then "namestr" and "name" buffer are both SNDRV_CTL_ELEM_ID_NAME_MAXLEN
(44) characters long. We never actually use that full amount in real life so everything works fine, but static checkers complain that if name is 44 characters then when you combine that with the other strings it will lead to a buffer overflow. Using snprintf() silences the warning and makes the code a little bit safer for the future.

---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_ca0132.c +1 -1
index cfe422a79703..5815552cbf89 100644
@@ -4409,7 +4410,7 @@ static int add_tuning_control(struct hda_codec *codec,
 	}
 	knew.private_value =
 		HDA_COMPOSE_AMP_VAL(nid, 1, 0, type);
-	sprintf(namestr, "%s %s Volume", name, dirstr[dir]);
+	snprintf(namestr, sizeof(namestr), "%s %s Volume", name, dirstr[dir]);
 	return snd_hda_ctl_add(codec, nid, snd_ctl_new1(&knew, codec));
 }
 
Signature · 1 line
2.47.2
#1 lore raw
Quoted 5 lines · Dan Carpenter

In this sprintf():

	sprintf(namestr, "%s %s Volume", name, dirstr[dir]);
Quoted 8 lines

Then "namestr" and "name" buffer are both SNDRV_CTL_ELEM_ID_NAME_MAXLEN
(44) characters long. We never actually use that full amount in real life so everything works fine, but static checkers complain that if name is 44 characters then when you combine that with the other strings it will lead to a buffer overflow. Using snprintf() silences the warning and makes the code a little bit safer for the future.

Thanks for the patch, but the very same fix was already submitted from Lucy and merged in commit a409c60111e6.

Takashi