ima: add a knob ima= to make IMA be able to be disabled
Subsystems (5)
PATCH v2 1/1 ima: add a knob ima= to make IMA be able to be disabled
Kdump kernel doesn't need IMA functionality, and enabling IMA will cost extra memory. It would be very helpful to allow IMA to be disabled for kdump kernel.
Hence add a knob ima=on|off here to allow turning IMA off in kdump kernel if needed.
Note that this IMA disabling is only limited to kdump kernel, please don't abuse it in other kernel and thus serious consequences are caused.
---v1->v2:
- Improve patch log and doc description;
- Make slight adjustment in code;
These are all made according to Mimi's great suggestions.
.../admin-guide/kernel-parameters.txt | 5 ++++ security/integrity/ima/ima_main.c | 26 +++++++++++++++++++ 2 files changed, 31 insertions(+)
Documentation/admin-guide/kernel-parameters.txt +5 -0
@@ -2214,6 +2214,11 @@ different crypto accelerators. This option can be used to achieve best performance for particular HW. + ima= [IMA] Enable or disable IMA + Format: { "off" | "on" } + Default: "on" + Note that this is only limited to kdump kernel. + indirect_target_selection= [X86,Intel] Mitigation control for Indirect Target Selection(ITS) bug in Intel CPUs. Updated microcode is also required for a fix in IBPB.
security/integrity/ima/ima_main.c +26 -0
@@ -27,6 +27,7 @@#include <linux/fs.h> #include <linux/iversion.h> #include <linux/evm.h> +#include <linux/crash_dump.h> #include "ima.h"
@@ -38,11 +39,30 @@ int ima_appraise;int __ro_after_init ima_hash_algo =HASH_ALGO_SHA1 ;static int hash_setup_done; +static int ima_disabled__ro_after_init ;static struct notifier_block ima_lsm_policy_notifier = { .notifier_call = ima_lsm_policy_change, }; +static int __init ima_setup (char *str) +{ +if (!is_kdump_kernel ()) { +pr_info ("Warning: ima setup option only permitted in kdump" ); +return 1 ; + } + +if (strncmp (str,"off" ,3 ) ==0 ) + ima_disabled =1 ; +else if (strncmp (str,"on" ,2 ) ==0 ) + ima_disabled =0 ; +else +pr_err ("Invalid ima setup option: \"%s\" , please specify ima=on|off." , str); + +return 1 ; +} +__setup ("ima=" , ima_setup); +static int __init hash_setup (char *str) {struct ima_template_desc *template_desc =ima_template_desc_current ();
@@ -1186,6 +1206,12 @@ static int __init init_ima(void) {int error; +/*Note that turning IMA off is only limited to kdump kernel.*/ +if (ima_disabled &&is_kdump_kernel ()) { +pr_info ("IMA functionality is disabled" ); +return 0 ; + } +ima_appraise_parse_cmdline ();ima_init_template_list ();hash_setup (CONFIG_IMA_DEFAULT_HASH );
Signature · 1 line
2.41.0
Mimi Zohar
maintainerHi Baoquan,
As discussed
https://lore.kernel.org/linux-integrity/aC6ezNcUZ%2FulKgpv@MiWiFi-R3L-srv/ the Subject line should indicate disabling IMA is limited to kdump.
Quoted 9 lines · Baoquan He
Kdump kernel doesn't need IMA functionality, and enabling IMA will cost extra memory. It would be very helpful to allow IMA to be disabled for kdump kernel.
Hence add a knob ima=on|off here to allow turning IMA off in kdump kernel if needed.
Note that this IMA disabling is only limited to kdump kernel, please don't abuse it in other kernel and thus serious consequences are caused.
Remove the word 'only', here, and in other places.
Quoted 17 lines
Signed-off-by Baoquan He <[email protected]>---
v1->v2:
- Improve patch log and doc description;
- Make slight adjustment in code;
These are all made according to Mimi's great suggestions..../admin-guide/kernel-parameters.txt | 5 ++++ security/integrity/ima/ima_main.c | 26 +++++++++++++++++++ 2 files changed, 31 insertions(+)Documentation/admin-guide/kernel-parameters.txt +0
-0
Documentation/admin-guide/kernel-parameters.txt line 2220
Quoted 7 lines
Documentation/admin-guide/kernel-parameters.txt +4
-0@@ -2214,6 +2214,11 @@ different crypto accelerators. This option can be used to achieve best performance for particular HW. + ima= [IMA] Enable or disable IMA + Format: { "off" | "on" } + Default: "on" + Note that this is only limited to kdump kernel.
Remove the word 'only' -> Note that disabling IMA is limited to kdump kernel.
Quoted 48 lines
Documentation/admin-guide/kernel-parameters.txt +1
-0+ indirect_target_selection= [X86,Intel] Mitigation control for Indirect Target Selection(ITS) bug in Intel CPUs. Updated microcode is also required for a fix in IBPB.security/integrity/ima/ima_main.c +20
-0@@ -27,6 +27,7 @@#include <linux/fs.h> #include <linux/iversion.h> #include <linux/evm.h> +#include <linux/crash_dump.h> #include "ima.h" @@ -38,11 +39,30 @@ int ima_appraise;int __ro_after_init ima_hash_algo =HASH_ALGO_SHA1 ;static int hash_setup_done; +static int ima_disabled__ro_after_init ;static struct notifier_block ima_lsm_policy_notifier = { .notifier_call = ima_lsm_policy_change, }; +static int __init ima_setup (char *str) +{ +if (!is_kdump_kernel ()) { +pr_info ("Warning: ima setup option only permitted in kdump" ); +return 1 ; + } + +if (strncmp (str,"off" ,3 ) ==0 ) + ima_disabled =1 ; +else if (strncmp (str,"on" ,2 ) ==0 ) + ima_disabled =0 ; +else +pr_err ("Invalid ima setup option: \"%s\" , please specify ima=on|off." , str); + +return 1 ; +} +__setup ("ima=" , ima_setup); +static int __init hash_setup (char *str) {struct ima_template_desc *template_desc =ima_template_desc_current ();
security/integrity/ima/ima_main.c static int __init init_ima(void) · line 1209
Quoted 4 lines
security/integrity/ima/ima_main.c +1
-0@@ -1186,6 +1206,12 @@ static int __init init_ima(void) {int error; +/*Note that turning IMA off is only limited to kdump kernel.*/
Remove the word "only" -> Note that turning IMA off is intentionally limited to kdump kernel."
security/integrity/ima/ima_main.c static int __init init_ima(void) · line 1217
Quoted 8 lines
security/integrity/ima/ima_main.c +5
-0+if (ima_disabled &&is_kdump_kernel ()) { +pr_info ("IMA functionality is disabled" ); +return 0 ; + } +ima_appraise_parse_cmdline ();ima_init_template_list ();hash_setup (CONFIG_IMA_DEFAULT_HASH );
Mimi
Quoted 5 lines · Mimi Zohar
Hi Baoquan,
As discussed
https://lore.kernel.org/linux-integrity/aC6ezNcUZ%2FulKgpv@MiWiFi-R3L-srv/ the Subject line should indicate disabling IMA is limited to kdump.
Oops, my bad, I forgot this one.
Quoted 6 lines · Baoquan He
Quoted 4 lines
Kdump kernel doesn't need IMA functionality, and enabling IMA will cost extra memory. It would be very helpful to allow IMA to be disabled for kdump kernel.
Quoted 7 lines
Quoted 5 lines
Hence add a knob ima=on|off here to allow turning IMA off in kdump kernel if needed.
Note that this IMA disabling is only limited to kdump kernel, please don't abuse it in other kernel and thus serious consequences are caused.
Remove the word 'only', here, and in other places.
Sure, will udpate in all relevant places. Thanks.
Quoted 95 lines
Quoted 18 lines
Signed-off-by Baoquan He <[email protected]>---
v1->v2:
- Improve patch log and doc description;
- Make slight adjustment in code;
These are all made according to Mimi's great suggestions..../admin-guide/kernel-parameters.txt | 5 ++++ security/integrity/ima/ima_main.c | 26 +++++++++++++++++++ 2 files changed, 31 insertions(+)Documentation/admin-guide/kernel-parameters.txt +0
-0Documentation/admin-guide/kernel-parameters.txt line 2220
Quoted 7 lines
Documentation/admin-guide/kernel-parameters.txt +4
-0@@ -2214,6 +2214,11 @@ different crypto accelerators. This option can be used to achieve best performance for particular HW. + ima= [IMA] Enable or disable IMA + Format: { "off" | "on" } + Default: "on" + Note that this is only limited to kdump kernel.Remove the word 'only' -> Note that disabling IMA is limited to kdump kernel.
Quoted 48 lines
Documentation/admin-guide/kernel-parameters.txt +1
-0+ indirect_target_selection= [X86,Intel] Mitigation control for Indirect Target Selection(ITS) bug in Intel CPUs. Updated microcode is also required for a fix in IBPB.security/integrity/ima/ima_main.c +20
-0@@ -27,6 +27,7 @@#include <linux/fs.h> #include <linux/iversion.h> #include <linux/evm.h> +#include <linux/crash_dump.h> #include "ima.h" @@ -38,11 +39,30 @@ int ima_appraise;int __ro_after_init ima_hash_algo =HASH_ALGO_SHA1 ;static int hash_setup_done; +static int ima_disabled__ro_after_init ;static struct notifier_block ima_lsm_policy_notifier = { .notifier_call = ima_lsm_policy_change, }; +static int __init ima_setup (char *str) +{ +if (!is_kdump_kernel ()) { +pr_info ("Warning: ima setup option only permitted in kdump" ); +return 1 ; + } + +if (strncmp (str,"off" ,3 ) ==0 ) + ima_disabled =1 ; +else if (strncmp (str,"on" ,2 ) ==0 ) + ima_disabled =0 ; +else +pr_err ("Invalid ima setup option: \"%s\" , please specify ima=on|off." , str); + +return 1 ; +} +__setup ("ima=" , ima_setup); +static int __init hash_setup (char *str) {struct ima_template_desc *template_desc =ima_template_desc_current ();security/integrity/ima/ima_main.c static int __init init_ima(void) · line 1209
Quoted 4 lines
security/integrity/ima/ima_main.c +1
-0@@ -1186,6 +1206,12 @@ static int __init init_ima(void) {int error; +/*Note that turning IMA off is only limited to kdump kernel.*/ Remove the word "only" -> Note that turning IMA off is intentionally limited to kdump kernel."
security/integrity/ima/ima_main.c static int __init init_ima(void) · line 1217
Quoted 8 lines
security/integrity/ima/ima_main.c +5
-0+if (ima_disabled &&is_kdump_kernel ()) { +pr_info ("IMA functionality is disabled" ); +return 0 ; + } +ima_appraise_parse_cmdline ();ima_init_template_list ();hash_setup (CONFIG_IMA_DEFAULT_HASH );Mimi