ASoC: SDCA: add a HID device for HIDE entity
Subsystems (3)
PATCH 3/3 ASoC: SDCA: add a HID device for HIDE entity
From: Shuming Fan <[email protected]>
This patch supports to add a HID device for SDCA HIDE entity. The codec driver could call 'hid_input_report' to report events.
--- include/sound/sdca_hid.h | 25 +++++++ sound/soc/sdca/Kconfig | 4 + sound/soc/sdca/Makefile | 3 + sound/soc/sdca/sdca_functions.c | 9 +++ sound/soc/sdca/sdca_hid.c | 127 ++++++++++++++++++++++++++++++++ 5 files changed, 168 insertions(+) create mode 100644 include/sound/sdca_hid.h create mode 100644 sound/soc/sdca/sdca_hid.c
include/sound/sdca_hid.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ +/* +* The MIPI SDCA specification is available for public downloads at +* https://www.mipi.org/mipi-sdca-v1-0-download +* +*/ + +#ifndef __SDCA_HID_H__ +#define __SDCA_HID_H__ + +#include <linux/types.h> +#include <linux/hid.h> + +#if IS_ENABLED (CONFIG_SND_SOC_SDCA_HID ) +int sdca_add_hid_device (struct device *dev,struct sdca_entity *entity); + +#else +static inline int sdca_add_hid_device (struct device *dev,struct sdca_entity *entity) +{ +return 0 ; +} + +#endif + +#endif /* __SDCA_HID_H__ */
sound/soc/sdca/Kconfig +4 -0
@@ -9,3 +9,7 @@ config SND_SOC_SDCA config SND_SOC_SDCA_OPTIONAL def_tristate SND_SOC_SDCA || !SND_SOC_SDCA + +config SND_SOC_SDCA_HID + tristate "SDCA HID support" + depends on SND_SOC_SDCA && HID
sound/soc/sdca/Makefile +3 -0
@@ -2,4 +2,7 @@ snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o +snd-soc-sdca-hid-y := sdca_hid.o + +obj-$(CONFIG_SND_SOC_SDCA_HID) += snd-soc-sdca-hid.o obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o
sound/soc/sdca/sdca_functions.c +9 -0
@@ -19,6 +19,7 @@#include <linux/types.h> #include <sound/sdca.h> #include <sound/sdca_function.h> +#include <sound/sdca_hid.h> /* * Should be long enough to encompass all the MIPI DisCo properties.
@@ -1294,6 +1295,13 @@ find_sdca_entity_hide(struct device *dev, struct fwnode_handle *function_node, hide->hid_report_desc = report_desc;fwnode_property_read_u8_array (function_node,"mipi-sdca-report-descriptor" , report_desc, nval); + +/* add HID device */ + ret =sdca_add_hid_device (dev, entity); +if (ret) { +dev_err (dev,"%pfwP: failed to add HID device: %d\n" , entity_node, ret); +return ret; + } } }
@@ -1933,3 +1941,4 @@ EXPORT_SYMBOL_NS(sdca_parse_function, "SND_SOC_SDCA");MODULE_LICENSE ("Dual BSD/GPL" );MODULE_DESCRIPTION ("SDCA library" ); +MODULE_IMPORT_NS ("SND_SOC_SDCA_HID" );
sound/soc/sdca/sdca_hid.c new file +127 -0
127 lines not on this page · raw message
Signature · 1 line
2.34.1
Charles Keepax
maintainerOn Wed, Jun 11, 2025 at 06:27:09PM +0800, [email protected] wrote:
Adding Pierre.
Quoted 238 lines
From: Shuming Fan <[email protected]>
This patch supports to add a HID device for SDCA HIDE entity. The codec driver could call '
hid_input_report' to report events.Signed-off-by Shuming Fan <[email protected]>--- include/sound/sdca_hid.h | 25 +++++++ sound/soc/sdca/Kconfig | 4 + sound/soc/sdca/Makefile | 3 + sound/soc/sdca/sdca_functions.c | 9 +++ sound/soc/sdca/sdca_hid.c | 127 ++++++++++++++++++++++++++++++++ 5 files changed, 168 insertions(+) create mode 100644 include/sound/sdca_hid.h create mode 100644 sound/soc/sdca/sdca_hid.cinclude/sound/sdca_hid.h new file +25
-0@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ +/* +* The MIPI SDCA specification is available for public downloads at +* https://www.mipi.org/mipi-sdca-v1-0-download +* +*/ + +#ifndef __SDCA_HID_H__ +#define __SDCA_HID_H__ + +#include <linux/types.h> +#include <linux/hid.h> + +#if IS_ENABLED (CONFIG_SND_SOC_SDCA_HID ) +int sdca_add_hid_device (struct device *dev,struct sdca_entity *entity); + +#else +static inline int sdca_add_hid_device (struct device *dev,struct sdca_entity *entity) +{ +return 0 ; +} + +#endif + +#endif /* __SDCA_HID_H__ */ sound/soc/sdca/Kconfig +4
-0@@ -9,3 +9,7 @@ config SND_SOC_SDCA config SND_SOC_SDCA_OPTIONAL def_tristate SND_SOC_SDCA || !SND_SOC_SDCA + +config SND_SOC_SDCA_HID + tristate "SDCA HID support" + depends on SND_SOC_SDCA && HIDsound/soc/sdca/Makefile +3
-0@@ -2,4 +2,7 @@ snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o +snd-soc-sdca-hid-y := sdca_hid.o + +obj-$(CONFIG_SND_SOC_SDCA_HID) += snd-soc-sdca-hid.o obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.osound/soc/sdca/sdca_functions.c +9
-0@@ -19,6 +19,7 @@#include <linux/types.h> #include <sound/sdca.h> #include <sound/sdca_function.h> +#include <sound/sdca_hid.h> /* * Should be long enough to encompass all the MIPI DisCo properties. @@ -1294,6 +1295,13 @@ find_sdca_entity_hide(struct device *dev, struct fwnode_handle *function_node, hide->hid_report_desc = report_desc;fwnode_property_read_u8_array (function_node,"mipi-sdca-report-descriptor" , report_desc, nval); + +/* add HID device */ + ret =sdca_add_hid_device (dev, entity); +if (ret) { +dev_err (dev,"%pfwP: failed to add HID device: %d\n" , entity_node, ret); +return ret; + } } }@@ -1933,3 +1941,4 @@ EXPORT_SYMBOL_NS(sdca_parse_function, "SND_SOC_SDCA");MODULE_LICENSE ("Dual BSD/GPL" );MODULE_DESCRIPTION ("SDCA library" ); +MODULE_IMPORT_NS ("SND_SOC_SDCA_HID" );sound/soc/sdca/sdca_hid.c new file +127
-0@@ -0,0 +1,127 @@ +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) + +/* +* The MIPI SDCA specification is available for public downloads at +* https://www.mipi.org/mipi-sdca-v1-0-download +*/ + +#include <linux/acpi.h> +#include <linux/byteorder/generic.h> +#include <linux/cleanup.h> +#include <linux/device.h> +#include <linux/dev_printk.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/soundwire/sdw.h> +#include <linux/types.h> +#include <sound/sdca.h> +#include <sound/sdca_function.h> +#include <sound/sdca_hid.h> + +static int sdwhid_parse (struct hid_device *hid) +{ +struct sdca_entity *entity = hid->driver_data; +unsigned int rsize; +int ret; + + rsize = entity->hide.hid_desc.rpt_desc.wDescriptorLength; + +if (!rsize || rsize >HID_MAX_DESCRIPTOR_SIZE ) { +dev_err (&hid->dev,"invalid size of report descriptor (%u)\n" , rsize); +return -EINVAL ; + } + + ret =hid_parse_report (hid, entity->hide.hid_report_desc, rsize); + +if (!ret) +return 0 ; + +dev_err (&hid->dev,"parsing report descriptor failed\n" ); +return ret; +} + +static int sdwhid_start (struct hid_device *hid) +{ +return 0 ; +} + +static void sdwhid_stop (struct hid_device *hid) +{ +} + +static int sdwhid_raw_request (struct hid_device *hid,unsigned char reportnum, +__u8 *buf,size_t len,unsigned char rtype,int reqtype) +{ +switch (reqtype) { +case HID_REQ_GET_REPORT : +/* not implemented yet */ +return 0 ; +case HID_REQ_SET_REPORT : +/* not implemented yet */ +return 0 ; +default : +return -EIO ; + } +} + +static int sdwhid_open (struct hid_device *hid) +{ +return 0 ; +} + +static void sdwhid_close (struct hid_device *hid) +{ +} + +static const struct hid_ll_driver sdw_hid_driver = { + .parse = sdwhid_parse, + .start = sdwhid_start, + .stop = sdwhid_stop, + .open = sdwhid_open, + .close = sdwhid_close, + .raw_request = sdwhid_raw_request, +}; + +int sdca_add_hid_device (struct device *dev,struct sdca_entity *entity) +{ +struct sdw_bus *bus; +struct hid_device *hid; +struct sdw_slave *slave =dev_to_sdw_dev (dev); +int ret; + + bus = slave->bus; + + hid =hid_allocate_device (); +if (IS_ERR (hid)) +return PTR_ERR (hid); + + hid->ll_driver = &sdw_hid_driver; + + hid->dev.parent = dev; + hid->bus =BUS_SDW ; + hid->version =le16_to_cpu (entity->hide.hid_desc.bcdHID); + +snprintf (hid->name,sizeof (hid->name), +"HID sdw:%01x:%01x:%04x:%04x:%02x" , + bus->controller_id, bus->link_id, slave->id.mfg_id, + slave->id.part_id, slave->id.class_id); + +snprintf (hid->phys,sizeof (hid->phys),"%s" , dev->bus->name); + + hid->driver_data = entity; + + ret =hid_add_device (hid); +if (ret && ret != -ENODEV ) { +dev_err (dev,"can't add hid device: %d\n" , ret); +hid_destroy_device (hid); +return ret; + } + + entity->hide.hid = hid; + +return 0 ; +} +EXPORT_SYMBOL_NS (sdca_add_hid_device,"SND_SOC_SDCA_HID" ); + +MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_DESCRIPTION ("SDCA HID library" );Signature · 1 line
2.34.1
Quoted 8 lines · On Wed, Jun 11, 2025 at 06:27:09PM +0800, [email protected] wrote:
From: Shuming Fan <[email protected]>
This patch supports to add a HID device for SDCA HIDE entity. The codec driver could call '
hid_input_report' to report events.Signed-off-by Shuming Fan <[email protected]>---
sound/soc/sdca/sdca_functions.c find_sdca_entity_hide(struct device *dev, struct fwnode_handle *function_node, · line 1302
Quoted 8 lines
sound/soc/sdca/sdca_functions.c +5
-0@@ -1294,6 +1295,13 @@ find_sdca_entity_hide(struct device *dev, struct fwnode_handle *function_node, hide->hid_report_desc = report_desc;fwnode_property_read_u8_array (function_node,"mipi-sdca-report-descriptor" , report_desc, nval); + +/* add HID device */ + ret =sdca_add_hid_device (dev, entity); +if (ret) { +dev_err (dev,"%pfwP: failed to add HID device: %d\n" , entity_node, ret);
Minor nit: Not sure we need this error message and...
sound/soc/sdca/sdca_hid.c line 115
Quoted 3 lines
sound/soc/sdca/sdca_hid.c new file +3
-0+ ret =hid_add_device (hid); +if (ret && ret != -ENODEV ) { +dev_err (dev,"can't add hid device: %d\n" , ret);
this error message, perhaps remove one of them I don't feel super strongly which one.
Otherwise:
Thanks,
Charles