Skip to contentSkip to conversation

gpio: ts5500: use new GPIO line value setter callbacks

PATCH Applied Daniel Sullivan 2 participants 2 messages Jun 22, 2025 – Jun 23, 2025 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: ts5500: use new GPIO line value setter callbacks

struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them.

---
 drivers/gpio/gpio-ts5500.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpio/gpio-ts5500.c +4 -2
index 61cbec5c06a7..bb432ed73698 100644
@@ -244,7 +244,7 @@ static int ts5500_gpio_output(struct gpio_chip *chip, unsigned offset, int val)
 	return 0;
 }
 
-static void ts5500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
+static int ts5500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
 {
 	struct ts5500_priv *priv = gpiochip_get_data(chip);
 	const struct ts5500_dio line = priv->pinout[offset];
@@ -256,6 +256,8 @@ static void ts5500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
 	else
 		ts5500_clear_mask(line.value_mask, line.value_addr);
 	spin_unlock_irqrestore(&priv->lock, flags);
+
+	return 0;
 }
 
 static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
@@ -338,7 +340,7 @@ static int ts5500_dio_probe(struct platform_device *pdev)
 	priv->gpio_chip.direction_input = ts5500_gpio_input;
 	priv->gpio_chip.direction_output = ts5500_gpio_output;
 	priv->gpio_chip.get = ts5500_gpio_get;
-	priv->gpio_chip.set = ts5500_gpio_set;
+	priv->gpio_chip.set_rv = ts5500_gpio_set;
 	priv->gpio_chip.to_irq = ts5500_gpio_to_irq;
 	priv->gpio_chip.base = -1;
 
Signature · 1 line
2.43.0
#1 lore raw

From: Bartosz Golaszewski <[email protected]>

Quoted 5 lines · Daniel Sullivan

struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them.

Applied, thanks!

[1/1] gpio: ts5500: use new GPIO line value setter callbacks

      https://git.kernel.org/brgl/linux/c/a0cfbc67d71c763357a8847305e3d5254028c0da

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>