pppoe: drop PACKET_OTHERHOST before skb_share_check()
PATCH 1/1 pppoe: drop PACKET_OTHERHOST before skb_share_check()
Align with ip_rcv() by dropping PACKET_OTHERHOST packets before calling skb_share_check(). This avoids unnecessary skb processing for packets that will be discarded anyway.
--- drivers/net/ppp/pppoe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ppp/pppoe.c +3 -3
@@ -372,9 +372,6 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)* can't change. */ -if (skb->pkt_type ==PACKET_OTHERHOST ) - goto abort_kfree; -if (sk->sk_state &PPPOX_BOUND ) {ppp_input (&po->chan, skb); }else if (sk->sk_state &PPPOX_RELAY ) {
@@ -418,6 +415,9 @@ static int pppoe_rcv(struct sk_buff *skb, struct net_device *dev,struct pppoe_net *pn;int len; +if (skb->pkt_type ==PACKET_OTHERHOST ) + goto drop; + skb =skb_share_check (skb,GFP_ATOMIC );if (!skb) goto out;
Signature · 1 line
2.43.0
Quoted 24 lines · Qingfang Deng
Align with
ip_rcv()by droppingPACKET_OTHERHOSTpackets before callingskb_share_check(). This avoids unnecessary skb processing for packets that will be discarded anyway.Signed-off-by Qingfang Deng <[email protected]>--- drivers/net/ppp/pppoe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/ppp/pppoe.c +0
-3@@ -372,9 +372,6 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)* can't change. */ -if (skb->pkt_type ==PACKET_OTHERHOST ) - goto abort_kfree; -if (sk->sk_state &PPPOX_BOUND ) {ppp_input (&po->chan, skb); }else if (sk->sk_state &PPPOX_RELAY ) {
drivers/net/ppp/pppoe.c static int pppoe_rcv(struct sk_buff *skb, struct net_device *dev, · line 423
Quoted 9 lines
drivers/net/ppp/pppoe.c +3
-0@@ -418,6 +415,9 @@ static int pppoe_rcv(struct sk_buff *skb, struct net_device *dev,struct pppoe_net *pn;int len; +if (skb->pkt_type ==PACKET_OTHERHOST ) + goto drop; + skb =skb_share_check (skb,GFP_ATOMIC );if (!skb) goto out;
Agree. You can also refine the condition and reject broadcast packets by using "if (skb->pkt_type != PACKET_HOST)". PPPoE session packets should always be unicast.
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 23 Jun 2025 11:34:31 +0800 you wrote:
Align with
ip_rcv()by droppingPACKET_OTHERHOSTpackets before callingskb_share_check(). This avoids unnecessary skb processing for packets that will be discarded anyway.Signed-off-by Qingfang Deng <[email protected]>--- drivers/net/ppp/pppoe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] pppoe: drop PACKET_OTHERHOST before skb_share_check()
https://git.kernel.org/netdev/net-next/c/7eebd219feda
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html