media: venus: Add QCM2290 support with AR50_LITE core
Subsystems (6)
v4 cover media: venus: Add QCM2290 support with AR50_LITE core
Changes since v3:
- Fixed schema commit subject.
Changes since v2:
- Removed IS_HFI/IS_VPU macros
- checkpatch.pl --strict fixes:
- convert macro to static inline to avoid argument reuse side effect
Changes since v1:
- Added IS_HFI macro usage
- Moved schema patch to top
- Fixed commit messages
This patch series adds support for the Venus video decoder/encoder block present on the Qualcomm QCM2290.
The QCM2290 integrates an AR50_LITE core, a low-power implementation of Venus supporting H.264, HEVC (H.265), and VP9 decoding.
The series includes:
- DT binding schema for qcom,qcm2290-venus
- SoC integration via qcm2290.dtsi
- Resource table definitions and frequency scaling
- Platform capability registration for the AR50_LITE core
Decoding was verified on the QCOM RB1 platform using GStreamer with V4L2-based decode plugins. The following pipelines were used for playback 1280x720 and 1920x1080 H.264, HEVC and VP9 videos from https://www.elecard.com/videos.
[H.264]
gst-launch-1.0 filesrc location=videos/xxxxx.mp4 \
! qtdemux name=demux demux.video_0 ! queue ! h264parse ! v4l2h264dec \
! videoconvert ! autovideosink
[H.265]
gst-launch-1.0 filesrc location=videos/xxxxx.mp4 \
! qtdemux name=demux demux.video_0 ! queue ! h265parse ! v4l2h265dec \
! videoconvert ! autovideosink
[VP9]
gst-launch-1.0 filesrc location=videos/xxxxx.webm \
! matroskademux ! queue ! v4l2vp9dec \
! videoconvert ! autovideosink
[Fluster]
The H.264 decoder was also tested using the Fluster test suite (version: v0.4.0-12-g33566abd0964).
Target: GStreamer-H.264-V4L2-Gst1.0, Test Suite: JVT-AVC_V1
Result: 126/135 tests passed
Failures:
FM1_BT_B, FM1_FT_E, FM2_SVA_C, BA3_SVA_C, SP1_BT_A, SP2_BT_B, MR6_BT_B, MR7_BT_B, MR8_BT_B
---
Jorge Ramirez-Ortiz (5):
media: dt-bindings: venus: Add qcm2290 dt schema
media: venus: vdec: AR50_LITE video core support
media: venus: hfi_plat_v6_lite: Populate decode capabilities
media: venus: core: Add qcm2290 DT compatible and resource data
arm64: dts: qcom: qcm2290: Add venus video node
.../bindings/media/qcom,qcm2290-venus.yaml | 117 ++++++++++++++ arch/arm64/boot/dts/qcom/qcm2290.dtsi | 45 ++++++ drivers/media/platform/qcom/venus/Makefile | 2 +- drivers/media/platform/qcom/venus/core.c | 51 +++++- drivers/media/platform/qcom/venus/core.h | 11 +- drivers/media/platform/qcom/venus/firmware.c | 8 +- drivers/media/platform/qcom/venus/helpers.c | 80 ++++++++++ drivers/media/platform/qcom/venus/helpers.h | 2 + .../media/platform/qcom/venus/hfi_helper.h | 10 +- .../media/platform/qcom/venus/hfi_platform.c | 2 + .../media/platform/qcom/venus/hfi_platform.h | 1 + .../qcom/venus/hfi_platform_v6_lite.c | 148 ++++++++++++++++++ drivers/media/platform/qcom/venus/hfi_venus.c | 14 +- .../media/platform/qcom/venus/pm_helpers.c | 1 + drivers/media/platform/qcom/venus/vdec.c | 15 +- 15 files changed, 482 insertions(+), 25 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml create mode 100644 drivers/media/platform/qcom/venus/hfi_platform_v6_lite.c
Signature · 1 line
2.34.1
PATCH v4 1/5 media: dt-bindings: venus: Add qcm2290 dt schema
Add a schema for the venus video encoder/decoder on the qcm2290.
--- .../bindings/media/qcom,qcm2290-venus.yaml | 117 ++++++++++++++++++ 1 file changed, 117 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml new file +117 -0
@@ -0,0 +1,117 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/qcom,qcm2290-venus.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm QCM2290 Venus video encode and decode accelerators + +maintainers: + - Vikash Garodia <[email protected]> + +description: + The Venus AR50_LITE IP is a video encode and decode accelerator present + on Qualcomm platforms + +allOf: + - $ref: qcom,venus-common.yaml# + +properties: + compatible: + const: qcom,qcm2290-venus + + power-domains: + maxItems: 3 + + power-domain-names: + items: + - const: venus + - const: vcodec0 + - const: cx + + clocks: + maxItems: 6 + + clock-names: + items: + - const: core + - const: iface + - const: bus + - const: throttle + - const: vcodec0_core + - const: vcodec0_bus + + iommus: + minItems: 1 + maxItems: 5 + + interconnects: + maxItems: 2 + + interconnect-names: + items: + - const: video-mem + - const: cpu-cfg + + operating-points-v2: true + opp-table: + type: object + +required: + - compatible + - power-domain-names + - iommus + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/qcom,gcc-qcm2290.h> + #include <dt-bindings/interconnect/qcom,qcm2290.h> + #include <dt-bindings/interconnect/qcom,rpm-icc.h> + #include <dt-bindings/power/qcom-rpmpd.h> + + venus: video-codec@5a00000 { + compatible = "qcom,qcm2290-venus"; + reg = <0x5a00000 0xff000>; + interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>; + + power-domains = <&gcc GCC_VENUS_GDSC>, + <&gcc GCC_VCODEC0_GDSC>, + <&rpmpd QCM2290_VDDCX>; + power-domain-names = "venus", "vcodec0", "cx"; + operating-points-v2 = <&venus_opp_table>; + + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, + <&gcc GCC_VIDEO_AHB_CLK>, + <&gcc GCC_VENUS_CTL_AXI_CLK>, + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, + <&gcc GCC_VCODEC0_AXI_CLK>; + clock-names = "core", "iface", "bus", "throttle", + "vcodec0_core", "vcodec0_bus"; + + memory-region = <&pil_video_mem>; + iommus = <&apps_smmu 0x860 0x0>, + <&apps_smmu 0x880 0x0>, + <&apps_smmu 0x861 0x04>, + <&apps_smmu 0x863 0x0>, + <&apps_smmu 0x804 0xE0>; + + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; + interconnect-names = "video-mem", "cpu-cfg"; + + venus_opp_table: opp-table { + compatible = "operating-points-v2"; + opp-133000000 { + opp-hz = /bits/ 64 <133000000>; + required-opps = <&rpmpd_opp_low_svs>; + }; + opp-240000000 { + opp-hz = /bits/ 64 <240000000>; + required-opps = <&rpmpd_opp_svs>; + }; + }; + };
Signature · 1 line
2.34.1
Re: [PATCH v4 1/5] media: dt-bindings: venus: Add qcm2290 dt schema
Quoted 4 lines · Jorge Ramirez-Ortiz
Add a schema for the venus video encoder/decoder on the qcm2290.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Don't send multiple versions per day and allow other to actually perform review of your patchset instead of sending for every little thing.
<form letter>
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
If a tag was not added on purpose, please state why and what changed. </form letter>
Best regards,
Krzysztof
Re: [PATCH v4 1/5] media: dt-bindings: venus: Add qcm2290 dt schema
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Jorge Ramirez-Ortiz
Add a schema for the venus video encoder/decoder on the qcm2290.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Don't send multiple versions per day and allow other to actually perform review of your patchset instead of sending for every little thing.
No. this is not what this was about - I already explained to you the call I chose to make. You can disagree but you should not misrepresent it.
Re: [PATCH v4 1/5] media: dt-bindings: venus: Add qcm2290 dt schema
Quoted 4 lines · Jorge Ramirez
Quoted 3 lines · Krzysztof Kozlowski
Quoted 2 lines · Jorge Ramirez-Ortiz
Add a schema for the venus video encoder/decoder on the qcm2290.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Don't send multiple versions per day and allow other to actually perform review of your patchset instead of sending for every little thing.
No. this is not what this was about - I already explained to you the call I chose to make. You can disagree but you should not misrepresent it.
No, you did not explain me anything. You sent v4 with only one little change:
"Changes since v3:
- Fixed schema commit subject."
The same day, also skipping review.
So no, don't do that. One patchset per day.
Best regards,
Krzysztof
Re: [PATCH v4 1/5] media: dt-bindings: venus: Add qcm2290 dt schema
Quoted 15 lines · Krzysztof Kozlowski
Quoted 4 lines · Jorge Ramirez
Quoted 3 lines · Krzysztof Kozlowski
Quoted 2 lines · Jorge Ramirez-Ortiz
Add a schema for the venus video encoder/decoder on the qcm2290.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Don't send multiple versions per day and allow other to actually perform review of your patchset instead of sending for every little thing.
No. this is not what this was about - I already explained to you the call I chose to make. You can disagree but you should not misrepresent it.
Quoted 4 lines
No, you did not explain me anything. You sent v4 with only one little change:
"Changes since v3:
- Fixed schema commit subject."
um, I dont want to delve in this (only because the conversation takes longer than actual changes but just to close the loop), I did acknowledge that you had trouble receiving my patches - since they were threaded - and that I would be respining on the same day in case others were having the same issue.
Quoted 2 lines
The same day, also skipping review.
yep. will repost later today and thanks for the persistance (dont think I dont value it!).
PATCH v4 2/5 media: venus: vdec: AR50_LITE video core support
In reply to Jorge Ramirez-OrtizThe AR50_LITE is a streamlined variant of the AR50 video core, designed for power and cost-efficient platforms.
It supports hardware-accelerated decoding of H.264, HEVC, and VP9 formats.
--- drivers/media/platform/qcom/venus/core.c | 11 ++- drivers/media/platform/qcom/venus/core.h | 11 ++- drivers/media/platform/qcom/venus/firmware.c | 8 +- drivers/media/platform/qcom/venus/helpers.c | 80 +++++++++++++++++++ drivers/media/platform/qcom/venus/helpers.h | 2 + .../media/platform/qcom/venus/hfi_helper.h | 10 ++- drivers/media/platform/qcom/venus/hfi_venus.c | 14 ++-- .../media/platform/qcom/venus/pm_helpers.c | 1 + drivers/media/platform/qcom/venus/vdec.c | 15 ++-- 9 files changed, 128 insertions(+), 24 deletions(-)
drivers/media/platform/qcom/venus/core.c +8 -3
@@ -254,14 +254,19 @@ static int venus_enumerate_codecs(struct venus_core *core, u32 type)static void venus_assign_register_offsets (struct venus_core *core) { -if (IS_IRIS2 (core) ||IS_IRIS2_1 (core)) { - core->vbif_base = core->base +VBIF_BASE ; +if (IS_IRIS2 (core) ||IS_IRIS2_1 (core) ||IS_AR50_LITE (core)) { core->cpu_base = core->base +CPU_BASE_V6 ; core->cpu_cs_base = core->base +CPU_CS_BASE_V6 ; core->cpu_ic_base = core->base +CPU_IC_BASE_V6 ; core->wrapper_base = core->base +WRAPPER_BASE_V6 ; core->wrapper_tz_base = core->base +WRAPPER_TZ_BASE_V6 ; - core->aon_base = core->base +AON_BASE_V6 ; +if (IS_AR50_LITE (core)) { + core->vbif_base =NULL ; + core->aon_base =NULL ; + }else { + core->vbif_base = core->base +VBIF_BASE ; + core->aon_base = core->base +AON_BASE_V6 ; + } }else { core->vbif_base = core->base +VBIF_BASE ; core->cpu_base = core->base +CPU_BASE ;
drivers/media/platform/qcom/venus/core.h +10 -1
@@ -382,6 +382,7 @@ enum venus_inst_modes {* @lock: instance lock * @core: a reference to the core struct * @clk_data: clock data per core ID +* @eosbufs: a lit of EOS buffers * @dpbbufs: a list of decoded picture buffers * @internalbufs: a list of internal bufferes * @registeredbufs: a list of registered capture bufferes
@@ -450,6 +451,7 @@ struct venus_inst {struct mutex lock;struct venus_core *core;struct clock_data clk_data; +struct list_head eosbufs;struct list_head dpbbufs;struct list_head internalbufs;struct list_head registeredbufs;
@@ -520,7 +522,14 @@ struct venus_inst {#define IS_V1 (core) ((core)->res->hfi_version == HFI_VERSION_1XX)#define IS_V3 (core) ((core)->res->hfi_version == HFI_VERSION_3XX)#define IS_V4 (core) ((core)->res->hfi_version == HFI_VERSION_4XX) -#define IS_V6 (core) ((core)->res->hfi_version == HFI_VERSION_6XX) +static inline bool IS_V6 (struct venus_core *core) +{ +if (WARN_ON_ONCE (!core)) +return false; + +return core->res->hfi_version ==HFI_VERSION_6XX || + core->res->hfi_version ==HFI_VERSION_6XX_LITE ; +}#define IS_AR50 (core) ((core)->res->vpu_version == VPU_VERSION_AR50)#define IS_AR50_LITE (core) ((core)->res->vpu_version == VPU_VERSION_AR50_LITE)
drivers/media/platform/qcom/venus/firmware.c +4 -4
@@ -30,7 +30,7 @@ static void venus_reset_cpu(struct venus_core *core)u32 fw_size = core->fw.mapped_mem_size;void __iomem *wrapper_base; -if (IS_IRIS2_1 (core)) +if (IS_IRIS2_1 (core) ||IS_AR50_LITE (core)) wrapper_base = core->wrapper_tz_base;else wrapper_base = core->wrapper_base;
@@ -42,7 +42,7 @@ static void venus_reset_cpu(struct venus_core *core)writel (fw_size, wrapper_base +WRAPPER_NONPIX_START_ADDR );writel (fw_size, wrapper_base +WRAPPER_NONPIX_END_ADDR ); -if (IS_IRIS2_1 (core)) { +if (IS_IRIS2_1 (core) ||IS_AR50_LITE (core)) {/* Bring XTSS out of reset */ writel (0 , wrapper_base +WRAPPER_TZ_XTSS_SW_RESET ); }else {
@@ -68,7 +68,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume)if (resume) {venus_reset_cpu (core); }else { -if (IS_IRIS2_1 (core)) +if (IS_IRIS2_1 (core) ||IS_AR50_LITE (core))writel (WRAPPER_XTSS_SW_RESET_BIT , core->wrapper_tz_base +WRAPPER_TZ_XTSS_SW_RESET );else
@@ -181,7 +181,7 @@ static int venus_shutdown_no_tz(struct venus_core *core)void __iomem *wrapper_base = core->wrapper_base;void __iomem *wrapper_tz_base = core->wrapper_tz_base; -if (IS_IRIS2_1 (core)) { +if (IS_IRIS2_1 (core) ||IS_AR50_LITE (core)) {/* Assert the reset to XTSS */ reg =readl (wrapper_tz_base +WRAPPER_TZ_XTSS_SW_RESET ); reg |=WRAPPER_XTSS_SW_RESET_BIT ;
drivers/media/platform/qcom/venus/helpers.c +80 -0
92 lines not on this page · raw message
drivers/media/platform/qcom/venus/helpers.h +2 -0
@@ -58,6 +58,8 @@ int venus_helper_get_out_fmts(struct venus_inst *inst, u32 fmt, u32 *out_fmt,bool venus_helper_check_format (struct venus_inst *inst,u32 v4l2_pixfmt);int venus_helper_alloc_dpb_bufs (struct venus_inst *inst);int venus_helper_free_dpb_bufs (struct venus_inst *inst); +int venus_helper_alloc_eos_buf (struct venus_inst *inst,struct hfi_frame_data *data); +int venus_helper_free_eos_bufs (struct venus_inst *inst);int venus_helper_intbufs_alloc (struct venus_inst *inst);int venus_helper_intbufs_free (struct venus_inst *inst);int venus_helper_intbufs_realloc (struct venus_inst *inst);
drivers/media/platform/qcom/venus/hfi_helper.h +7 -3
@@ -397,13 +397,16 @@#define HFI_BUFFER_INTERNAL_PERSIST_1 0x5#define HFI_BUFFER_INTERNAL_SCRATCH (ver) \ (((ver) == HFI_VERSION_4XX || \ - (ver) == HFI_VERSION_6XX) ? 0x6 : 0x1000001) + (ver) == HFI_VERSION_6XX || (ver) == HFI_VERSION_6XX_LITE) \ + ? 0x6 : 0x1000001)#define HFI_BUFFER_INTERNAL_SCRATCH_1 (ver) \ (((ver) == HFI_VERSION_4XX || \ - (ver) == HFI_VERSION_6XX) ? 0x7 : 0x1000005) + (ver) == HFI_VERSION_6XX || (ver) == HFI_VERSION_6XX_LITE) \ + ? 0x7 : 0x1000005)#define HFI_BUFFER_INTERNAL_SCRATCH_2 (ver) \ (((ver) == HFI_VERSION_4XX || \ - (ver) == HFI_VERSION_6XX) ? 0x8 : 0x1000006) + (ver) == HFI_VERSION_6XX || (ver) == HFI_VERSION_6XX_LITE) \ + ? 0x8 : 0x1000006)#define HFI_BUFFER_EXTRADATA_INPUT (ver) \ (((ver) == HFI_VERSION_4XX) ? 0xc : 0x1000002)#define HFI_BUFFER_EXTRADATA_OUTPUT (ver) \
@@ -561,6 +564,7 @@ enum hfi_version {HFI_VERSION_3XX ,HFI_VERSION_4XX ,HFI_VERSION_6XX , + HFI_VERSION_6XX_LITE, }; struct hfi_buffer_info {
drivers/media/platform/qcom/venus/hfi_venus.c +9 -5
@@ -497,7 +497,7 @@ static int venus_boot_core(struct venus_hfi_device *hdev)if (count >= max_tries) ret = -ETIMEDOUT ; -if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core)) { +if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core) ||IS_AR50_LITE (hdev->core)) {writel (0x1 , cpu_cs_base +CPU_CS_H2XSOFTINTEN_V6 );writel (0x0 , cpu_cs_base +CPU_CS_X2RPMH_V6 ); }
@@ -565,6 +565,9 @@ static int venus_halt_axi(struct venus_hfi_device *hdev)u32 mask_val;int ret; +if (IS_AR50_LITE (hdev->core)) +return 0 ; +if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core)) {writel (0x3 , cpu_cs_base +CPU_CS_X2RPMH_V6 );
@@ -1134,7 +1137,8 @@ static irqreturn_t venus_isr(struct venus_core *core) wrapper_base = hdev->core->wrapper_base; status =readl (wrapper_base +WRAPPER_INTR_STATUS ); -if (IS_IRIS2 (core) ||IS_IRIS2_1 (core)) { + +if (IS_IRIS2 (core) ||IS_IRIS2_1 (core) ||IS_AR50_LITE (core)) {if (status &WRAPPER_INTR_STATUS_A2H_MASK || status &WRAPPER_INTR_STATUS_A2HWD_MASK_V6 || status &CPU_CS_SCIACMDARG0_INIT_IDLE_MSG_MASK )
@@ -1146,7 +1150,7 @@ static irqreturn_t venus_isr(struct venus_core *core) hdev->irq_status = status; }writel (1 , cpu_cs_base +CPU_CS_A2HSOFTINTCLR ); -if (!(IS_IRIS2 (core) ||IS_IRIS2_1 (core))) +if (!(IS_IRIS2 (core) ||IS_IRIS2_1 (core) ||IS_AR50_LITE (core)))writel (status, wrapper_base +WRAPPER_INTR_CLEAR );return IRQ_WAKE_THREAD ;
@@ -1531,7 +1535,7 @@ static bool venus_cpu_and_video_core_idle(struct venus_hfi_device *hdev)void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;u32 ctrl_status, cpu_status; -if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core)) +if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core) ||IS_AR50_LITE (hdev->core)) cpu_status =readl (wrapper_tz_base +WRAPPER_TZ_CPU_STATUS_V6 );else cpu_status =readl (wrapper_base +WRAPPER_CPU_STATUS );
@@ -1551,7 +1555,7 @@ static bool venus_cpu_idle_and_pc_ready(struct venus_hfi_device *hdev)void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;u32 ctrl_status, cpu_status; -if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core)) +if (IS_IRIS2 (hdev->core) ||IS_IRIS2_1 (hdev->core) ||IS_AR50_LITE (hdev->core)) cpu_status =readl (wrapper_tz_base +WRAPPER_TZ_CPU_STATUS_V6 );else cpu_status =readl (wrapper_base +WRAPPER_CPU_STATUS );
drivers/media/platform/qcom/venus/pm_helpers.c +1 -0
@@ -1168,6 +1168,7 @@ const struct venus_pm_ops *venus_pm_get(enum hfi_version version)return &pm_ops_v3;case HFI_VERSION_4XX :case HFI_VERSION_6XX : +case HFI_VERSION_6XX_LITE :return &pm_ops_v4; }
drivers/media/platform/qcom/venus/vdec.c +7 -8
@@ -550,7 +550,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) {struct venus_inst *inst =to_inst (file);struct vb2_queue *dst_vq; -struct hfi_frame_data fdata = {0 }; +struct hfi_frame_data fdata;int ret; ret =v4l2_m2m_ioctl_try_decoder_cmd (file, fh, cmd);
@@ -561,18 +561,15 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd)if (cmd->cmd ==V4L2_DEC_CMD_STOP ) {/* -* Implement V4L2_DEC_CMD_STOP by enqueue an empty buffer on +* Implement V4L2_DEC_CMD_STOP by enqueue a buffer on * decoder input to signal EOS. */ if (!(inst->streamon_out && inst->streamon_cap)) goto unlock; - fdata.buffer_type =HFI_BUFFER_INPUT ; - fdata.flags |=HFI_BUFFERFLAG_EOS ; -if (IS_V6 (inst->core) &&is_fw_rev_or_older (inst->core,1 ,0 ,87 )) - fdata.device_addr =0 ; -else - fdata.device_addr =0xdeadb000 ; + ret =venus_helper_alloc_eos_buf (inst, &fdata); +if (ret) + goto unlock; ret =hfi_session_process_buf (inst, &fdata);
@@ -1332,6 +1329,7 @@ static void vdec_session_release(struct venus_inst *inst)hfi_session_abort (inst);venus_helper_free_dpb_bufs (inst); +venus_helper_free_eos_bufs (inst);venus_pm_load_scale (inst);INIT_LIST_HEAD (&inst->registeredbufs);mutex_unlock (&inst->lock);
@@ -1682,6 +1680,7 @@ static int vdec_open(struct file *file)if (!inst)return -ENOMEM ; +INIT_LIST_HEAD (&inst->eosbufs);INIT_LIST_HEAD (&inst->dpbbufs);INIT_LIST_HEAD (&inst->registeredbufs);INIT_LIST_HEAD (&inst->internalbufs);
Signature · 1 line
2.34.1
PATCH v4 3/5 media: venus: hfi_plat_v6_lite: Populate decode capabilities
In reply to Jorge Ramirez-OrtizAdd hfi platform file with decoding capabilities for hfi v6_lite.
--- drivers/media/platform/qcom/venus/Makefile | 2 +- .../media/platform/qcom/venus/hfi_platform.c | 2 + .../media/platform/qcom/venus/hfi_platform.h | 1 + .../qcom/venus/hfi_platform_v6_lite.c | 148 ++++++++++++++++++ 4 files changed, 152 insertions(+), 1 deletion(-) create mode 100644 drivers/media/platform/qcom/venus/hfi_platform_v6_lite.c
drivers/media/platform/qcom/venus/Makefile +1 -1
@@ -5,7 +5,7 @@ venus-core-objs += core.o helpers.o firmware.o \ hfi_venus.o hfi_msgs.o hfi_cmds.o hfi.o \ hfi_parser.o pm_helpers.o dbgfs.o \ hfi_platform.o hfi_platform_v4.o \ - hfi_platform_v6.o hfi_plat_bufs_v6.o \ + hfi_platform_v6.o hfi_plat_bufs_v6.o hfi_platform_v6_lite.o \ venus-dec-objs += vdec.o vdec_ctrls.o venus-enc-objs += venc.o venc_ctrls.o
drivers/media/platform/qcom/venus/hfi_platform.c +2 -0
@@ -13,6 +13,8 @@ const struct hfi_platform *hfi_platform_get(enum hfi_version version)return &hfi_plat_v4;case HFI_VERSION_6XX :return &hfi_plat_v6; +case HFI_VERSION_6XX_LITE : +return &hfi_plat_v6_lite;default :break ; }
drivers/media/platform/qcom/venus/hfi_platform.h +1 -0
@@ -58,6 +58,7 @@ struct hfi_platform {extern const struct hfi_platform hfi_plat_v4;extern const struct hfi_platform hfi_plat_v6; +extern const struct hfi_platform hfi_plat_v6_lite;const struct hfi_platform *hfi_platform_get (enum hfi_version version); unsigned long hfi_platform_get_codec_vpp_freq(enum hfi_version version, u32 codec,
drivers/media/platform/qcom/venus/hfi_platform_v6_lite.c new file +148 -0
148 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v4 4/5 media: venus: core: Add qcm2290 DT compatible and resource data
In reply to Jorge Ramirez-OrtizAdd a qcm2290 compatible binding to the venus core.
--- drivers/media/platform/qcom/venus/core.c | 40 ++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
drivers/media/platform/qcom/venus/core.c +40 -0
@@ -1062,6 +1062,45 @@ static const struct venus_resources sc7280_res = { .enc_nodename = "video-encoder", }; +static const struct freq_tbl qcm2290_freq_table[] = { + {352800 ,240000000 },/* 1920x1088 @ 30 + 1280x720 @ 30 */ + {244800 ,133000000 },/* 1920x1088 @ 30 */ +}; + +static const struct bw_tbl qcm2290_bw_table_dec[] = { + {244800 ,2128000 ,0 ,2128000 ,0 },/* 1920x1088 @ 30 */ +}; + +static const struct venus_resources qcm2290_res = { + .freq_tbl = qcm2290_freq_table, + .freq_tbl_size =ARRAY_SIZE (qcm2290_freq_table), + .bw_tbl_dec = qcm2290_bw_table_dec, + .bw_tbl_dec_size =ARRAY_SIZE (qcm2290_bw_table_dec), + .clks = {"core" ,"iface" ,"bus" ,"throttle" }, + .clks_num =4 , + .vcodec0_clks = {"vcodec0_core" ,"vcodec0_bus" }, + .vcodec_clks_num =2 , + .vcodec_pmdomains = (const char *[]) {"venus" ,"vcodec0" }, + .vcodec_pmdomains_num =2 , + .opp_pmdomain = (const char *[]) {"cx" }, + .vcodec_num =1 , + .hfi_version =HFI_VERSION_6XX_LITE , + .vpu_version =VPU_VERSION_AR50_LITE , + .max_load =352800 , + .num_vpp_pipes =1 , + .vmem_id =VIDC_RESOURCE_NONE , + .vmem_size =0 , + .vmem_addr =0 , + .cp_start =0 , + .cp_size =0x70800000 , + .cp_nonpixel_start =0x1000000 , + .cp_nonpixel_size =0x24800000 , + .dma_mask =0xe0000000 -1 , + .fwname ="qcom/venus-6.0/venus.mbn" , + .dec_nodename ="video-decoder" , + .enc_nodename ="video-encoder" , +}; +static const struct of_device_id venus_dt_match[] = { { .compatible ="qcom,msm8916-venus" , .data = &msm8916_res, }, { .compatible ="qcom,msm8996-venus" , .data = &msm8996_res, },
@@ -1072,6 +1111,7 @@ static const struct of_device_id venus_dt_match[] = { { .compatible = "qcom,sc7180-venus", .data = &sc7180_res, }, { .compatible = "qcom,sc7280-venus", .data = &sc7280_res, }, { .compatible = "qcom,sm8250-venus", .data = &sm8250_res, }, + { .compatible = "qcom,qcm2290-venus", .data = &qcm2290_res, }, { } }; MODULE_DEVICE_TABLE(of, venus_dt_match);
Signature · 1 line
2.34.1
Re: [PATCH v4 4/5] media: venus: core: Add qcm2290 DT compatible and resource data
Quoted 5 lines · Jorge Ramirez-Ortiz
Add a qcm2290 compatible binding to the venus core.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>
Wrong order of tags here as well. There is a direct example in submitting patches, so it is confusing to see something different.
Best regards,
Krzysztof
Re: [PATCH v4 4/5] media: venus: core: Add qcm2290 DT compatible and resource data
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Jorge Ramirez-Ortiz
Add a qcm2290 compatible binding to the venus core.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>Wrong order of tags here as well.
but of course, this was not an oversight - I followed what was done in some other commits (but yeah, I should have remembered not to use past commits as reference)
Quoted 3 lines
There is a direct example in
submitting patches, so it is confusing to see something different.
yep I remember now when this was pushed 6 years ago (you can find me in the patch - I was part of some earlier discussion on co-developed. ok will revisit this doc).
PATCH v4 5/5 arm64: dts: qcom: qcm2290: Add venus video node
In reply to Jorge Ramirez-OrtizAdd DT entries for the qcm2290 venus encoder/decoder.
--- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
arch/arm64/boot/dts/qcom/qcm2290.dtsi +45 -0
@@ -1628,6 +1628,51 @@ adreno_smmu: iommu@59a0000 { #iommu-cells = <2>; }; + venus: video-codec@5a00000 { + compatible = "qcom,qcm2290-venus"; + reg = <0 0x5a00000 0 0xff000>; + interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>; + + power-domains = <&gcc GCC_VENUS_GDSC>, + <&gcc GCC_VCODEC0_GDSC>, + <&rpmpd QCM2290_VDDCX>; + power-domain-names = "venus", "vcodec0", "cx"; + operating-points-v2 = <&venus_opp_table>; + + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, + <&gcc GCC_VIDEO_AHB_CLK>, + <&gcc GCC_VENUS_CTL_AXI_CLK>, + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, + <&gcc GCC_VCODEC0_AXI_CLK>; + clock-names = "core", "iface", "bus", "throttle", + "vcodec0_core", "vcodec0_bus"; + + memory-region = <&pil_video_mem>; + iommus = <&apps_smmu 0x860 0x0>, + <&apps_smmu 0x880 0x0>, + <&apps_smmu 0x861 0x04>, + <&apps_smmu 0x863 0x0>, + <&apps_smmu 0x804 0xE0>; + + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; + interconnect-names = "video-mem", "cpu-cfg"; + + venus_opp_table: opp-table { + compatible = "operating-points-v2"; + opp-133000000 { + opp-hz = /bits/ 64 <133000000>; + required-opps = <&rpmpd_opp_low_svs>; + }; + + opp-240000000 { + opp-hz = /bits/ 64 <240000000>; + required-opps = <&rpmpd_opp_svs>; + }; + }; + }; + mdss: display-subsystem@5e00000 { compatible = "qcom,qcm2290-mdss"; reg = <0x0 0x05e00000 0x0 0x1000>;
Signature · 1 line
2.34.1
Re: [PATCH v4 5/5] arm64: dts: qcom: qcm2290: Add venus video node
Quoted 6 lines · Jorge Ramirez-Ortiz
Add DT entries for the qcm2290 venus encoder/decoder.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>---
[...]
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1633
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +3
-0+ venus: video-codec@5a00000 { + compatible = "qcom,qcm2290-venus"; + reg = <0 0x5a00000 0 0xff000>;
the size seems to be 0xf0000 instead
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1639
Quoted 6 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +6
-0+ interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>; + + power-domains = <&gcc GCC_VENUS_GDSC>, + <&gcc GCC_VCODEC0_GDSC>, + <&rpmpd QCM2290_VDDCX>; + power-domain-names = "venus", "vcodec0", "cx";
one per line, please, also below
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1643
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +4
-0+ operating-points-v2 = <&venus_opp_table>; + + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, + <&gcc GCC_VIDEO_AHB_CLK>,
On other platforms, this clock is consumed by videocc
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1656
Quoted 13 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +13
-0+ <&gcc GCC_VENUS_CTL_AXI_CLK>, + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, + <&gcc GCC_VCODEC0_AXI_CLK>; + clock-names = "core", "iface", "bus", "throttle", + "vcodec0_core", "vcodec0_bus"; + + memory-region = <&pil_video_mem>; + iommus = <&apps_smmu 0x860 0x0>, + <&apps_smmu 0x880 0x0>, + <&apps_smmu 0x861 0x04>, + <&apps_smmu 0x863 0x0>, + <&apps_smmu 0x804 0xE0>;
lowercase hex is preferred
Review
Quoted 2 lines
(quoted diff) +2
-0+ + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>,
for this path: RPM_ALWAYS_TAG> + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>;
for this one: RPM_ACTIVE_TAG
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1664
Quoted 5 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +5
-0+ interconnect-names = "video-mem", "cpu-cfg"; + + venus_opp_table: opp-table { + compatible = "operating-points-v2"; + opp-133000000 {
please add a newline before the subnode
Konrad
Re: [PATCH v4 5/5] arm64: dts: qcom: qcm2290: Add venus video node
Quoted 7 lines · Konrad Dybcio
Quoted 6 lines · Jorge Ramirez-Ortiz
Add DT entries for the qcm2290 venus encoder/decoder.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>---
[...]
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1643
Quoted 2 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +2
-0+ clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, + <&gcc GCC_VIDEO_AHB_CLK>,On other platforms, this clock is consumed by videocc
..except I didn't notice there's no videocc on this one
Konrad
Re: [PATCH v4 5/5] arm64: dts: qcom: qcm2290: Add venus video node
In reply to Konrad DybcioQuoted 8 lines · Konrad Dybcio
Quoted 6 lines · Jorge Ramirez-Ortiz
Add DT entries for the qcm2290 venus encoder/decoder.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>---
Quoted 7 lines
[...]
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1633
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +3
-0+ venus: video-codec@5a00000 { + compatible = "qcom,qcm2290-venus"; + reg = <0 0x5a00000 0 0xff000>;the size seems to be
0xf0000instead
you are right
Quoted 9 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1639
Quoted 7 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +6
-0+ interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>; + + power-domains = <&gcc GCC_VENUS_GDSC>, + <&gcc GCC_VCODEC0_GDSC>, + <&rpmpd QCM2290_VDDCX>; + power-domain-names = "venus", "vcodec0", "cx";one per line, please, also below
ok
Quoted 8 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1643
Quoted 5 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +4
-0+ operating-points-v2 = <&venus_opp_table>; + + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, + <&gcc GCC_VIDEO_AHB_CLK>,On other platforms, this clock is consumed by videocc
Quoted 15 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1656
Quoted 13 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +13
-0+ <&gcc GCC_VENUS_CTL_AXI_CLK>, + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, + <&gcc GCC_VCODEC0_AXI_CLK>; + clock-names = "core", "iface", "bus", "throttle", + "vcodec0_core", "vcodec0_bus"; + + memory-region = <&pil_video_mem>; + iommus = <&apps_smmu 0x860 0x0>, + <&apps_smmu 0x880 0x0>, + <&apps_smmu 0x861 0x04>, + <&apps_smmu 0x863 0x0>, + <&apps_smmu 0x804 0xE0>;lowercase hex is preferred
yep
Quoted 8 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>,for this path:
RPM_ALWAYS_TAG> + <&bimcMASTER_APPSS_PROC0&config_nocSLAVE_VENUS_CFG0>;for this one:
RPM_ACTIVE_TAG
ok
Quoted 7 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi adreno_smmu: iommu@59a0000 { · line 1664
Quoted 5 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +5
-0+ interconnect-names = "video-mem", "cpu-cfg"; + + venus_opp_table: opp-table { + compatible = "operating-points-v2"; + opp-133000000 {please add a newline before the subnode
ok
Quoted 2 lines
Konrad
Re: [PATCH v4 5/5] arm64: dts: qcom: qcm2290: Add venus video node
In reply to Jorge Ramirez-OrtizQuoted 5 lines · Jorge Ramirez-Ortiz
Add DT entries for the qcm2290 venus encoder/decoder.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>Co-developed-by Loic Poulain <[email protected]>Signed-off-by Loic Poulain <[email protected]>
Wrong order of tags.
See submitting patches (and see submitting patches also for explanation how to thread patchsets, what to do with the review tags... several issues are clearly explained there, so please read it carefully)
Best regards,
Krzysztof