staging: greybus: gbphy: fix up const issue with the match callback
Greg Kroah-Hartman
maintainerPATCH v2 1/1 staging: greybus: gbphy: fix up const issue with the match callback
gbphy_dev_match_id() should be taking a const pointer, as the pointer passed to it from the container_of() call was const to start with (it was accidentally cast away with the call.) Fix this all up by correctly marking the pointer types.
---
v2: - add Fixes: line as pointed out by Johan
- don't make gbphy_dev const, it's not needed, as pointed out by Johan
drivers/staging/greybus/gbphy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/gbphy.c +3 -3
@@ -102,8 +102,8 @@ static int gbphy_dev_uevent(const struct device *dev, struct kobj_uevent_env *en }static const struct gbphy_device_id * -gbphy_dev_match_id (struct gbphy_device *gbphy_dev, -struct gbphy_driver *gbphy_drv) +gbphy_dev_match_id (const struct gbphy_device *gbphy_dev, +const struct gbphy_driver *gbphy_drv) {const struct gbphy_device_id *id = gbphy_drv->id_table;
@@ -119,7 +119,7 @@ gbphy_dev_match_id(struct gbphy_device *gbphy_dev,static int gbphy_dev_match (struct device *dev,const struct device_driver *drv) { -struct gbphy_driver *gbphy_drv =to_gbphy_driver (drv); +const struct gbphy_driver *gbphy_drv =to_gbphy_driver (drv);struct gbphy_device *gbphy_dev =to_gbphy_dev (dev);const struct gbphy_device_id *id;
Signature · 1 line
2.50.0
Quoted 10 lines · Greg Kroah-Hartman
gbphy_dev_match_id()should be taking a const pointer, as the pointer passed to it from thecontainer_of()call was const to start with (it was accidentally cast away with the call.) Fix this all up by correctly marking the pointer types.Cc Johan Hovold <[email protected]>Cc Alex Elder <[email protected]>Fixes d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 4 lines
---
v2: - add Fixes: line as pointed out by Johan
- don't makegbphy_devconst, it's not needed, as pointed out by Johan