Skip to contentSkip to conversation

arm64: dts: qcom: sdm670-google-sargo: enable charger

PATCH Applied Richard Acayan 3 participants 5 messages Jun 30, 2025 – Aug 12, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sdm670-google-sargo: enable charger

The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable its charging controller in PM660.

---
 .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +17 -0
index 74b5d9c68eb6..d01422844fbf 100644
@@ -33,6 +33,14 @@ / {
 
 	aliases { };
 
+	battery: battery {
+		compatible = "simple-battery";
+
+		voltage-min-design-microvolt = <3312000>;
+		voltage-max-design-microvolt = <4400000>;
+		charge-full-design-microamp-hours = <3000000>;
+	};
+
 	chosen {
 		stdout-path = "serial0:115200n8";
 
@@ -478,6 +486,15 @@ &mdss_mdp {
 	status = "okay";
 };
 
+&pm660_charger {
+	monitored-battery = <&battery>;
+	status = "okay";
+};
+
+&pm660_rradc {
+	status = "okay";
+};
+
 &pm660l_flash {
 	status = "okay";
 
Signature · 1 line
2.50.0
#1 lore raw
Quoted 13 lines · Richard Acayan

The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable its charging controller in PM660.

---
 .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +0 -0
index 74b5d9c68eb6..d01422844fbf 100644

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts / { · line 40

Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +5 -0
@@ -33,6 +33,14 @@ / {
 
 	aliases { };
 
+	battery: battery {
+		compatible = "simple-battery";
+
+		voltage-min-design-microvolt = <3312000>;
+		voltage-max-design-microvolt = <4400000>;

Does this match what downstream sets into the hw?

Konrad

#2 lore raw
Quoted 19 lines · Konrad Dybcio
Quoted 16 lines · Richard Acayan

The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable its charging controller in PM660.

---
 .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +0 -0
index 74b5d9c68eb6..d01422844fbf 100644
@@ -33,6 +33,14 @@ / {
 
 	aliases { };
 
Quoted 7 lines

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts / { · line 40

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +5 -0
+	battery: battery {
+		compatible = "simple-battery";
+
+		voltage-min-design-microvolt = <3312000>;
+		voltage-max-design-microvolt = <4400000>;

Does this match what downstream sets into the hw?

Actually, downstream sets the "empty" voltage to 2.6 V. This minimum is closer to the "cutoff" voltage at 3.3 V.

The maximum voltage is consistent with downstream.

Reviewed-by
#3 lore raw
Quoted 28 lines · Richard Acayan
Quoted 19 lines · Konrad Dybcio
Quoted 16 lines · Richard Acayan

The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable its charging controller in PM660.

---
 .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +0 -0
index 74b5d9c68eb6..d01422844fbf 100644
@@ -33,6 +33,14 @@ / {
 
 	aliases { };
 
Quoted 7 lines

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts / { · line 40

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts +5 -0
+	battery: battery {
+		compatible = "simple-battery";
+
+		voltage-min-design-microvolt = <3312000>;
+		voltage-max-design-microvolt = <4400000>;

Does this match what downstream sets into the hw?

Quoted 4 lines

Actually, downstream sets the "empty" voltage to 2.6 V. This minimum is closer to the "cutoff" voltage at 3.3 V.

The maximum voltage is consistent with downstream.

Alright, thanks

Konrad

maintainer Applied
#4 lore raw
In reply to Richard Acayan
Quoted 4 lines · Richard Acayan

The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable its charging controller in PM660.

Applied, thanks!

[1/1] arm64: dts: qcom: sdm670-google-sargo: enable charger

      commit: 8839b8e6e849e209b52bf0ae4d0770d89c036b0e

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>