Skip to contentSkip to conversation

firmware/nvram: bcm47xx: Don't use "proxy" headers

PATCH Applied Andy Shevchenko 3 participants 3 messages Jun 26, 2025 – Jul 2, 2025 MIPS

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware/nvram: bcm47xx: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

Note that kernel.h is discouraged to be included as it's written at the top of that file.

---
 include/linux/bcm47xx_nvram.h | 1 -
 include/linux/bcm47xx_sprom.h | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
include/linux/bcm47xx_nvram.h +0 -1
index 7615f8d7b1ed..e4b6ce953ddb 100644
@@ -7,7 +7,6 @@
 
 #include <linux/errno.h>
 #include <linux/types.h>
-#include <linux/kernel.h>
 #include <linux/vmalloc.h>
 
 #ifdef CONFIG_BCM47XX_NVRAM
include/linux/bcm47xx_sprom.h +1 -1
index f8254fd53e15..40a7da3ef50e 100644
@@ -5,8 +5,8 @@
 #ifndef __BCM47XX_SPROM_H
 #define __BCM47XX_SPROM_H
 
+#include <linux/errno.h>
 #include <linux/types.h>
-#include <linux/kernel.h>
 #include <linux/vmalloc.h>
 
 struct ssb_sprom;
Signature · 1 line
2.47.2
maintainer Applied
#2 lore raw
Quoted 4 lines · Florian Fainelli
Quoted 3 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Quoted 8 lines
Quoted 4 lines

Note that kernel.h is discouraged to be included as it's written at the top of that file.

Thomas, can you pick this up? Thanks!

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]