net: ipv4: fix incorrect MTU in broadcast routes
Subsystems (5)
PATCH v2 1/2 net: ipv4: fix incorrect MTU in broadcast routes
Currently, __mkroute_output overrules the MTU value configured for broadcast routes.
This buggy behaviour can be reproduced with:
ip link set dev eth1 mtu 9000
ip route del broadcast 192.168.0.255 dev eth1 proto kernel scope link src 192.168.0.2 ip route add broadcast 192.168.0.255 dev eth1 proto kernel scope link src 192.168.0.2 mtu 1500
The maximum packet size should be 1500, but it is actually 8000:
ping -b 192.168.0.255 -s 8000
Fix __mkroute_output to allow MTU values to be configured for for broadcast routes (to support a mixed-MTU local-area-network).
--- net/ipv4/route.c | 1 - 1 file changed, 1 deletion(-)
net/ipv4/route.c +0 -1
@@ -2585,7 +2585,6 @@ static struct rtable *__mkroute_output(const struct fib_result *res, do_cache = true;if (type ==RTN_BROADCAST ) { flags |=RTCF_BROADCAST |RTCF_LOCAL ; - fi =NULL ; } else if (type == RTN_MULTICAST) { flags |= RTCF_MULTICAST | RTCF_LOCAL; if (!ip_check_mc_rcu(in_dev, fl4->daddr, fl4->saddr,
Signature · 1 line
2.39.5
PATCH v2 2/2 selftests: net: add test for variable PMTU in broadcast routes
Added a test for variable PMTU in broadcast routes.
This test uses iputils' ping and attempts to send a ping between two peers, which should result in a regular echo reply.
This test will fail when the receiving peer does not receive the echo request due to a lack of packet fragmentation.
--- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/broadcast_pmtu.sh | 47 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100755 tools/testing/selftests/net/broadcast_pmtu.sh
tools/testing/selftests/net/Makefile +1 -0
@@ -112,6 +112,7 @@ TEST_PROGS += skf_net_off.sh TEST_GEN_FILES += skf_net_off TEST_GEN_FILES += tfo TEST_PROGS += tfo_passive.sh +TEST_PROGS += broadcast_pmtu.sh # YNL files, must be before "include ..lib.mk" YNL_GEN_FILES := busy_poller netlink-dumps
tools/testing/selftests/net/broadcast_pmtu.sh new file +47 -0
47 lines not on this page · raw message
Signature · 1 line
2.39.5
kernel test robot
build botFYI: kernel test robot notices the stable kernel rule is not satisfied.
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH net v2 1/2] net: ipv4: fix incorrect MTU in broadcast routes
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Jakub Kicinski
maintainernet/ipv4/route.c static struct rtable *__mkroute_output(const struct fib_result *res, · line 2590
Quoted 6 lines · On Thu, 3 Jul 2025 17:28:37 +0200 Oscar Maes wrote:
net/ipv4/route.c +0
-1if (type ==RTN_BROADCAST ) { flags |=RTCF_BROADCAST |RTCF_LOCAL ; - fi =NULL ; } else if (type == RTN_MULTICAST) { flags |= RTCF_MULTICAST | RTCF_LOCAL; if (!ip_check_mc_rcu(in_dev, fl4->daddr, fl4->saddr,
Not super familiar with this code, but do we not need to set do_cache = false; ? I'm guessing cache interactions may have been the reason fib_info was originally cleared, not sure if that's still relevant..
I'd also target this at net-next, unless you can pinpoint some kernel version where MTU on bcast routes worked..
Signature · 1 line
pw-bot: cr
Quoted 13 lines · Jakub Kicinski
net/ipv4/route.c static struct rtable *__mkroute_output(const struct fib_result *res, · line 2590
Quoted 6 lines · On Thu, 3 Jul 2025 17:28:37 +0200 Oscar Maes wrote:
net/ipv4/route.c +0
-1if (type ==RTN_BROADCAST ) { flags |=RTCF_BROADCAST |RTCF_LOCAL ; - fi =NULL ; } else if (type == RTN_MULTICAST) { flags |= RTCF_MULTICAST | RTCF_LOCAL; if (!ip_check_mc_rcu(in_dev, fl4->daddr, fl4->saddr,Not super familiar with this code, but do we not need to set
do_cache= false; ? I'm guessing cache interactions may have been the reasonfib_infowas originally cleared, not sure if that's still relevant..
Quoted 4 lines
I'd also target this at net-next, unless you can pinpoint some kernel version where MTU on bcast routes worked..
Signature · 1 line
pw-bot: cr
The caching mechanism was introduced after this line, back when nhc was embedded in fib_info. (see https://lore.kernel.org/netdev/[email protected]/)
I'll resend to net-next.