Skip to contentSkip to conversation

regulator: tps6286x-regulator: Enable REGCACHE_MAPLE

PATCH In review Jisheng Zhang 2 participants 4 messages Jun 29, 2025 – Jul 7, 2025 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: tps6286x-regulator: Enable REGCACHE_MAPLE

Enable regmap cache to reduce i2c transactions and corresponding interrupts if regulator is accessed frequently.

---
 drivers/regulator/tps6286x-regulator.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/regulator/tps6286x-regulator.c +9 -0
index 75f441f36de7..778f169b0acc 100644
@@ -19,13 +19,22 @@
 #define TPS6286X_CONTROL_FPWM	BIT(4)
 #define TPS6286X_CONTROL_SWEN	BIT(5)
 
+#define TPS6286X_STATUS		0x05
+
 #define TPS6286X_MIN_MV		400
 #define TPS6286X_MAX_MV		1675
 #define TPS6286X_STEP_MV	5
 
+static bool tps6287x_volatile_reg(struct device *dev, unsigned int reg)
+{
+	return reg == TPS6286X_STATUS;
+}
+
 static const struct regmap_config tps6286x_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
+	.cache_type = REGCACHE_MAPLE,
+	.volatile_reg = tps6287x_volatile_reg,
 };
 
 static int tps6286x_set_mode(struct regulator_dev *rdev, unsigned int mode)
Signature · 1 line
2.49.0
maintainer
#1 lore raw
Quoted 4 lines · Jisheng Zhang

Enable regmap cache to reduce i2c transactions and corresponding interrupts if regulator is accessed frequently.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: tps6286x-regulator: Enable REGCACHE_MAPLE

      commit: 427ceac823e58813b510e585011488f603f0d891

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#2 lore raw
In reply to Jisheng Zhang
Quoted 13 lines · Jisheng Zhang

Enable regmap cache to reduce i2c transactions and corresponding interrupts if regulator is accessed frequently.

---
 drivers/regulator/tps6286x-regulator.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/regulator/tps6286x-regulator.c +0 -0
index 75f441f36de7..778f169b0acc 100644

drivers/regulator/tps6286x-regulator.c line 28

Quoted 10 lines
drivers/regulator/tps6286x-regulator.c +3 -0
@@ -19,13 +19,22 @@
 #define TPS6286X_CONTROL_FPWM	BIT(4)
 #define TPS6286X_CONTROL_SWEN	BIT(5)
 
+#define TPS6286X_STATUS		0x05
+
 #define TPS6286X_MIN_MV		400
 #define TPS6286X_MAX_MV		1675
 #define TPS6286X_STEP_MV	5
 
+static bool tps6287x_volatile_reg(struct device *dev, unsigned int reg)

Hi Mark,

I made a copy and paste error here: should be tps6286x_volatile_reg I have seen v1 has been merged, so how to cope with this? Do I need to send a v2?

Sorry for catching this a bit late.

Thanks

drivers/regulator/tps6286x-regulator.c line 37

Quoted 9 lines
drivers/regulator/tps6286x-regulator.c +6 -0
+{
+	return reg == TPS6286X_STATUS;
+}
+
 static const struct regmap_config tps6286x_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
+	.cache_type = REGCACHE_MAPLE,
+	.volatile_reg = tps6287x_volatile_reg,

ditto

Quoted 6 lines
drivers/regulator/tps6286x-regulator.c +0 -0
 };
 
 static int tps6286x_set_mode(struct regulator_dev *rdev, unsigned int mode)
Signature · 1 line
2.49.0
maintainer
#3 lore raw
Quoted 5 lines · Jisheng Zhang

I made a copy and paste error here: should be tps6286x_volatile_reg I have seen v1 has been merged, so how to cope with this? Do I need to send a v2?

Sorry for catching this a bit late.

As covered in the mail you got when the patch was applied:

| If any updates are required or you are submitting further changes they
| should be sent as incremental updates against current git, existing
| patches will not be replaced.