drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST
DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
convert drm_mm selftest to KUnit) and all functions under it were converted to KUnit, under the DRM_KUNIT_TEST option
This conversion however did not occur in the Kconfig.debug file in the i915 directory.
This patch replaces the select for DRM_DEBUG_SELFTEST, an option that no longer exists, with the correct select, DRM_KUNIT_TEST.
---
v2 changes:
- update commit message to contain more detail about the background of the change and why it is necessary
--- drivers/gpu/drm/i915/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/Kconfig.debug +1 -1
@@ -50,7 +50,7 @@ config DRM_I915_DEBUG select DRM_VGEM # used by igt/prime_vgem (dmabuf interop checks) select DRM_DEBUG_MM if DRM=y select DRM_EXPORT_FOR_TESTS if m - select DRM_DEBUG_SELFTEST + select DRM_KUNIT_TEST select DMABUF_SELFTESTS select SW_SYNC # signaling validation framework (igt/syncobj*) select DRM_I915_WERROR
Signature · 1 line
2.48.1
Quoted 34 lines · Ruben Wauters
DRM_DEBUG_SELFTESTwas removed in commitfc8d29e298cf(drm: selftest:
convertdrm_mmselftest to KUnit) and all functions under it were converted to KUnit, under theDRM_KUNIT_TESToptionThis conversion however did not occur in the
Kconfig.debugfile in the
i915 directory.This patch replaces the select for
DRM_DEBUG_SELFTEST, an option that no
longer exists, with the correct select,DRM_KUNIT_TEST.Signed-off-by Ruben Wauters <[email protected]>---
v2 changes:
- update commit message to contain more detail about the background of
the change and why it is necessary
---
drivers/gpu/drm/i915/Kconfig.debug | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/Kconfig.debug +0
-0@@ -50,7 +50,7 @@ config DRM_I915_DEBUGselect
DRM_VGEM# used by igt/prime_vgem (dmabuf interop checks)
selectDRM_DEBUG_MMif DRM=y
selectDRM_EXPORT_FOR_TESTSif mdrivers/gpu/drm/i915/Kconfig.debug +1
-1- select DRM_DEBUG_SELFTEST + select DRM_KUNIT_TEST
Quoted 4 lines
select
DMABUF_SELFTESTS
selectSW_SYNC# signaling validation framework (igt/syncobj*)
selectDRM_I915_WERROR
Hello, I was wondering if it'd be possible to have this patch reviewed. Having an incorrect Kconfig entry isn't ideal and it'd be good if this could be fixed if possible
Thanks
Ruben Wauters
Rodrigo Vivi
maintainerQuoted 8 lines · Ruben Wauters
Quoted 7 lines · Ruben Wauters
DRM_DEBUG_SELFTESTwas removed in commitfc8d29e298cf(drm: selftest:
convertdrm_mmselftest to KUnit) and all functions under it were converted to KUnit, under theDRM_KUNIT_TESToptionThis conversion however did not occur in the
Kconfig.debugfile in the
i915 directory.
I wonder if some deeper conversion is needed on the selftests. But well, I couldn't spot anything and if CI is happy, let's go with ti.
Quoted 27 lines
Quoted 27 lines
This patch replaces the select for
DRM_DEBUG_SELFTEST, an option that no
longer exists, with the correct select,DRM_KUNIT_TEST.Signed-off-by Ruben Wauters <[email protected]>---
v2 changes:
- update commit message to contain more detail about the background of
the change and why it is necessary
---
drivers/gpu/drm/i915/Kconfig.debug | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/Kconfig.debug +0
-0@@ -50,7 +50,7 @@ config DRM_I915_DEBUGselect
DRM_VGEM# used by igt/prime_vgem (dmabuf interop checks)
selectDRM_DEBUG_MMif DRM=y
selectDRM_EXPORT_FOR_TESTSif mdrivers/gpu/drm/i915/Kconfig.debug +1
-1- select DRM_DEBUG_SELFTEST + select DRM_KUNIT_TEST
Quoted 8 lines
Quoted 4 lines
select
DMABUF_SELFTESTS
selectSW_SYNC# signaling validation framework (igt/syncobj*)
selectDRM_I915_WERRORHello, I was wondering if it'd be possible to have this patch reviewed. Having an incorrect
Kconfigentry isn't ideal and it'd be good if this could be fixed if possible
I just resent for CI before we can merge.
Thanks for the patch...
Quoted 4 lines
Thanks
Ruben Wauters
Quoted 49 lines · Rodrigo Vivi
Quoted 8 lines · Ruben Wauters
Quoted 7 lines · Ruben Wauters
DRM_DEBUG_SELFTESTwas removed in commitfc8d29e298cf(drm: selftest:
convertdrm_mmselftest to KUnit) and all functions under it were converted to KUnit, under theDRM_KUNIT_TESToptionThis conversion however did not occur in the
Kconfig.debugfile in the
i915 directory.I wonder if some deeper conversion is needed on the selftests. But well, I couldn't spot anything and if CI is happy, let's go with ti.
Quoted 27 lines
Quoted 27 lines
This patch replaces the select for
DRM_DEBUG_SELFTEST, an option that no
longer exists, with the correct select,DRM_KUNIT_TEST.Signed-off-by Ruben Wauters <[email protected]>---
v2 changes:
- update commit message to contain more detail about the background of
the change and why it is necessary
---
drivers/gpu/drm/i915/Kconfig.debug | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/Kconfig.debug +0
-0@@ -50,7 +50,7 @@ config DRM_I915_DEBUGselect
DRM_VGEM# used by igt/prime_vgem (dmabuf interop checks)
selectDRM_DEBUG_MMif DRM=y
selectDRM_EXPORT_FOR_TESTSif mdrivers/gpu/drm/i915/Kconfig.debug +1
-1- select DRM_DEBUG_SELFTEST + select DRM_KUNIT_TESTQuoted 8 lines
Quoted 4 lines
select
DMABUF_SELFTESTS
selectSW_SYNC# signaling validation framework (igt/syncobj*)
selectDRM_I915_WERRORHello, I was wondering if it'd be possible to have this patch reviewed. Having an incorrect
Kconfigentry isn't ideal and it'd be good if this could be fixed if possible
Quoted 1 line
I just resent for CI before we can merge.
pushed to drm-intel-next
Thanks for the patch.
Quoted 7 lines
Thanks for the patch...
Quoted 4 lines
Thanks
Ruben Wauters
Patchwork
CI✗ LGCI.VerificationFailed: failure for drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST (rev2)
In reply to a message not in the archive== Series Details ==
== Series Details ==
Series: drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST (rev2)
URL : https://patchwork.freedesktop.org/series/151085/
State : failure
== Summary ==
Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!