drivers:zorro:zorro-sysfs.c Replace sprintf() with sysfs_emit()
PATCH 1/1 drivers:zorro:zorro-sysfs.c Replace sprintf() with sysfs_emit()
Reply-To:
replace sprintf() with sysfs_emit() in sysfs*_show() functions in zorro-sysfs.c to follow the kernel's guidelines from Documentation/filesystems/sysfs.rst.
This improves consistency, safety, and makes the code easier to maintain and update in the future.
--- drivers/zorro/zorro-sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/zorro/zorro-sysfs.c +4 -4
@@ -29,7 +29,7 @@ static ssize_t name##_show(struct device *dev, \struct zorro_dev *z; \ \ z =to_zorro_dev (dev); \ -return sprintf (buf, format_string, z->field); \ +return sysfs_emit (buf, format_string, z->field); \ } \static DEVICE_ATTR_RO (name);
@@ -44,7 +44,7 @@ static ssize_t serial_show(struct device *dev, struct device_attribute *attr,struct zorro_dev *z; z =to_zorro_dev (dev); -return sprintf (buf,"0x%08x\n" ,be32_to_cpu (z->rom.er_SerialNumber)); +return sysfs_emit (buf,"0x%08x\n" ,be32_to_cpu (z->rom.er_SerialNumber)); }static DEVICE_ATTR_RO (serial);
@@ -53,7 +53,7 @@ static ssize_t resource_show(struct device *dev, struct device_attribute *attr, {struct zorro_dev *z =to_zorro_dev (dev); -return sprintf (buf,"0x%08lx 0x%08lx 0x%08lx\n" , +return sysfs_emit (buf,"0x%08lx 0x%08lx 0x%08lx\n" , (unsigned long )zorro_resource_start (z), (unsigned long )zorro_resource_end (z),zorro_resource_flags (z));
@@ -65,7 +65,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, {struct zorro_dev *z =to_zorro_dev (dev); -return sprintf (buf,ZORRO_DEVICE_MODALIAS_FMT "\n" , z->id); +return sysfs_emit (buf,ZORRO_DEVICE_MODALIAS_FMT "\n" , z->id); }static DEVICE_ATTR_RO (modalias);
Signature · 1 line
2.43.0
Quoted 1 line · Rujra Bhatt
Reply-To:
Why is this here?
Quoted 7 lines
replace
sprintf()withsysfs_emit()in sysfs*_show()functions inzorro-sysfs.cto follow the kernel's guidelines fromDocumentation/filesystems/sysfs.rst.This improves consistency, safety, and makes the code easier to maintain and update in the future.
No, not really. For new code, always use sysfs_emit(). For existing code, that you can not even test, just leave it alone unless you can prove it is wrong.
This code looks fine as-is. No need to change it unless you really want to, but there is no requriement.
thanks,
greg k-h