Skip to contentSkip to conversation

pata_rdc: Use registered definition for the RDC vendor

PATCH Applied Andy Shevchenko 4 participants 6 messages Jul 11, 2025 – Jul 14, 2025 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pata_rdc: Use registered definition for the RDC vendor

Convert to PCI_VDEVICE() and use registered definition for RDC vendor from pci_ids.h.

---
 drivers/ata/pata_rdc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_rdc.c +2 -2
index 09792aac7f9d..19cbb5c94b42 100644
@@ -359,8 +359,8 @@ static void rdc_remove_one(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id rdc_pci_tbl[] = {
-	{ PCI_DEVICE(0x17F3, 0x1011), },
-	{ PCI_DEVICE(0x17F3, 0x1012), },
+	{ PCI_VDEVICE(RDC, 0x1011) },
+	{ PCI_VDEVICE(RDC, 0x1012) },
 	{ }	/* terminate list */
 };
 
Signature · 1 line
2.47.2
#2 lore raw
Quoted 7 lines · Damien Le Moal
Quoted 4 lines · Andy Shevchenko

Convert to PCI_VDEVICE() and use registered definition for RDC vendor from pci_ids.h.

Commit title needs "ata: " prefix. Niklas, can you add it when applying ?

I took the output of

$ git log --oneline --no-merges -- drivers/ata/pata_rdc.c

and tried to deduct what will be the driver specific prefix, there are no
ata: pata_rdc: prefixed changes, so it appears that I made wrong assumption.

Quoted 1 line

Thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#3 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Damien Le Moal
Quoted 4 lines · Andy Shevchenko

Convert to PCI_VDEVICE() and use registered definition for RDC vendor from pci_ids.h.

Quoted 8 lines
Quoted 1 line

Commit title needs "ata: " prefix. Niklas, can you add it when applying ?

I took the output of

$ git log --oneline --no-merges -- drivers/ata/pata_rdc.c

and tried to deduct what will be the driver specific prefix, there are no
ata: pata_rdc: prefixed changes, so it appears that I made wrong assumption.

It is probably because that driver has not been touched in a long time :) These days, we try to be consistent with the patch titles and have the "ata: " prefix for all of them to make git log searches easier.

Signature · 2 lines
Damien Le Moal
Western Digital Research