i386: Build SEV only for 64-bit target
PATCH 1/1 i386: Build SEV only for 64-bit target
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/Kconfig +1 -1
@@ -4,7 +4,7 @@ config X86_FW_OVMF config SEV bool select X86_FW_OVMF - depends on KVM + depends on KVM && X86_64 config SGX bool
Signature · 1 line
2.50.1
Quoted 7 lines · Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
Signed-off-by Cédric Le Goater <[email protected]>--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Matches what we just did for TDX too.
Quoted 18 lines
hw/i386/Kconfig +1
-1@@ -4,7 +4,7 @@ config X86_FW_OVMF config SEV bool select X86_FW_OVMF - depends on KVM + depends on KVM && X86_64 config SGX boolSignature · 1 line
2.50.1
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 4 lines · Daniel P. Berrangé
Quoted 3 lines · Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Cédric Le Goater <[email protected]>--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by Daniel P. Berrangé <[email protected]>Matches what we just did for TDX too.
What about SGX ?
Thanks,
C.
Quoted 10 lines · Cédric Le Goater
Quoted 9 lines · Daniel P. Berrangé
Quoted 7 lines · Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
Signed-off-by Cédric Le Goater <[email protected]>--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines
Reviewed-by Daniel P. Berrangé <[email protected]>Matches what we just did for TDX too.
What about SGX ?
Our SGX features only require kernel support.
The SGX userspace SDK can build for 32 & 64 bit, though in Fedora/RHEL I will only build it for 64-bit, but that's not relevant for QEMU's needs anyway.
Ultimately we're dropping 32-bit host support for QEMU in general at the end of this year, so we don't need to go out of our way to selectively drop things before then unless they're giving us trouble today.
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 4 lines · Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
Signed-off-by Cédric Le Goater <[email protected]>
Quoted 17 lines
--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/i386/Kconfig +1
-1@@ -4,7 +4,7 @@ config X86_FW_OVMF config SEV bool select X86_FW_OVMF - depends on KVM + depends on KVM && X86_64 config SGX bool
Cédric Le Goater
AppliedQuoted 13 lines · Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit support, restrict SEV to 64-bit.
Signed-off-by Cédric Le Goater <[email protected]>--- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/i386/Kconfig +0
-0
hw/i386/Kconfig config X86_FW_OVMF · line 10
Quoted 8 lines
hw/i386/Kconfig +1
-1@@ -4,7 +4,7 @@ config X86_FW_OVMF config SEV bool select X86_FW_OVMF - depends on KVM + depends on KVM && X86_64 config SGX bool
Applied to vfio-next.
Thanks,
C.