Skip to contentSkip to conversation

misc: ti_fpc202: Switch to of_fwnode_handle()

PATCH In review Jiri Slaby (SUSE) 3 participants 5 messages Jul 23, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: ti_fpc202: Switch to of_fwnode_handle()

of_node_to_fwnode() is an irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

This is the last in-tree user.

Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Wolfram Sang <[email protected]>
---
 drivers/misc/ti_fpc202.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/ti_fpc202.c +1 -1
index f84cae50e2c9..0b1a6350c02b 100644
@@ -281,7 +281,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv, struct device_node *i2c_h
 
 	desc.chan_id = port_id;
 	desc.parent = dev;
-	desc.bus_handle = of_node_to_fwnode(i2c_handle);
+	desc.bus_handle = of_fwnode_handle(i2c_handle);
 	desc.num_aliases = FPC202_ALIASES_PER_PORT;
 
 	fpc202_fill_alias_table(priv->client, aliases, port_id);
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Jiri Slaby (SUSE)

of_node_to_fwnode() is an irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

Quoted 8 lines

This is the last in-tree user.

Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Wolfram Sang <[email protected]>
author
#2 lore raw
Quoted 7 lines · Wolfram Sang
Quoted 6 lines · Jiri Slaby (SUSE)

of_node_to_fwnode() is an irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

This is the last in-tree user.

Quoted 8 lines
Quoted 6 lines
Fixes 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Wolfram Sang <[email protected]>

Well, who is supposed to pick this up? I thought you.

But given you marked it as such -- Greg?

thanks,

Signature · 2 lines
js
suse labs
#3 lore raw
Quoted 6 lines
Quoted 2 lines

Well, who is supposed to pick this up? I thought you.

But given you marked it as such -- Greg?

Technically, yes, Greg. I took the driver together with the I2C ATR feature because it was its first user. But other than that, it doesn't belong to the I2C realm. That being said, I can pick this patch to help removing the deprecated function if Greg doesn't pick it in the next days.

#4 lore raw
Quoted 5 lines · Wolfram Sang
Quoted 5 lines
Quoted 2 lines

Well, who is supposed to pick this up? I thought you.

Quoted 7 lines
Quoted 1 line

But given you marked it as such -- Greg?

Technically, yes, Greg. I took the driver together with the I2C ATR feature because it was its first user. But other than that, it doesn't belong to the I2C realm. That being said, I can pick this patch to help removing the deprecated function if Greg doesn't pick it in the next days.

I can grab it later today, not a problem,

greg k-h